make sure log-gathering for clients is controllable by overwriting the log_gatherer.furl #363

New Issue

zooko · 2008-03-21T23:03:58Z

zooko commented

2008-03-21 23:03:58 +00:00

Make sure that an empty log_gatherer.furl won't cause a client to fail on startup.

The conf wizard backend for allmydata.com can add or overwrite configuration files in the client's basedir, but it can't delete them, so if it needs to turn off a client's log_gatherer.furl, it will have to do it by overwriting it with the empty file.

Make sure that an empty log_gatherer.furl won't cause a client to fail on startup. The conf wizard backend for allmydata.com can add or overwrite configuration files in the client's basedir, but it can't delete them, so if it needs to turn off a client's log_gatherer.furl, it will have to do it by overwriting it with the empty file.

zooko added the

labels 2008-03-21 23:03:58 +00:00

zooko added this to the 1.0.0 milestone 2008-03-21 23:03:58 +00:00

warner commented

2008-03-25 19:01:44 +00:00

According to the code, an empty furlfile will be treated exactly as if it didn't exist.

Manual testing confirms this. Note that the file must be of zero length to be ignored. If the file contains a single newline (anything that doesn't evaluate as False) will cause an exception, probably fatal.

According to the code, an empty furlfile will be treated exactly as if it didn't exist. Manual testing confirms this. Note that the file must be of zero length to be ignored. If the file contains a single newline (anything that doesn't evaluate as False) will cause an exception, probably fatal.