Add pre-commits with lint checks #3398

New Issue

jaraco · 2020-08-30T15:14:54Z

jaraco commented

2020-08-30 15:14:54 +00:00

CI includes "code checks" including flake8 checks. It's common for a developer to make changes, test, commit, then push only to find that linter checks fail. To avoid this unwelcoming workflow, the team would like to declare pre-commit hooks that a developer could run to avoid committing code that will fail code checks (at least flake8).

jaraco added the

labels 2020-08-30 15:14:54 +00:00

jaraco added this to the Support Python 3 milestone 2020-08-30 15:14:54 +00:00

jaraco self-assigned this 2020-08-30 15:48:52 +00:00

jaraco commented

2020-09-12 13:53:51 +00:00

PR: https://github.com/tahoe-lafs/tahoe-lafs/pull/798

It's failing due to flaky tests.

PR: <https://github.com/tahoe-lafs/tahoe-lafs/pull/798> It's failing due to flaky tests.

rpatterson commented

2020-09-27 15:56:36 +00:00

Here's another PR that runs the full test suite before allowing a push and includes setting up the hook in the local checkout into the ./Makefile.

Here's [another PR](https://github.com/tahoe-lafs/tahoe-lafs/pull/830) that runs the full test suite before allowing a push and includes setting up the hook in the local checkout into the `./Makefile`.

itamarst commented

2023-09-05 14:20:22 +00:00

Ticket retargeted after milestone closed

itamarst removed this from the Support Python 3 milestone 2023-09-05 14:20:22 +00:00

Sign in to join this conversation.