stop using deprecated twisted.web.client.getPage #2857
Labels
No Label
0.2.0
0.3.0
0.4.0
0.5.0
0.5.1
0.6.0
0.6.1
0.7.0
0.8.0
0.9.0
1.0.0
1.1.0
1.10.0
1.10.1
1.10.2
1.10a2
1.11.0
1.12.0
1.12.1
1.13.0
1.14.0
1.15.0
1.15.1
1.2.0
1.3.0
1.4.1
1.5.0
1.6.0
1.6.1
1.7.0
1.7.1
1.7β
1.8.0
1.8.1
1.8.2
1.8.3
1.8β
1.9.0
1.9.0-s3branch
1.9.0a1
1.9.0a2
1.9.0b1
1.9.1
1.9.2
1.9.2a1
LeastAuthority.com automation
blocker
cannot reproduce
cloud-branch
code
code-dirnodes
code-encoding
code-frontend
code-frontend-cli
code-frontend-ftp-sftp
code-frontend-magic-folder
code-frontend-web
code-mutable
code-network
code-nodeadmin
code-peerselection
code-storage
contrib
critical
defect
dev-infrastructure
documentation
duplicate
enhancement
fixed
invalid
major
minor
n/a
normal
operational
packaging
somebody else's problem
supercritical
task
trivial
unknown
was already fixed
website
wontfix
worksforme
No Milestone
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Reference: tahoe-lafs/trac-2024-07-25#2857
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Twisted-16.7.0 is coming soon, and it deprecates
twisted.web.client.getPage
(andclient.HTTPClientFactory
). We use these in some of the unit tests, to fetch one of the HTTP WAPI/WUI pages and make sure the contents look right.We need to change these tests to use
twisted.web.client.Agent
instead, or a package named "treq", which is a Twisted flavor of the excellent (but blocking)requests
library.This was caught by the Deprecations buildbot, testing Tahoe against Twisted trunk: https://tahoe-lafs.org/buildbot-tahoe-lafs/builders/deprecations/builds/160/steps/upcoming-deprecations/logs/warnings
The Twisted deprecation ticket was https://twistedmatrix.com/trac/ticket/8960
(https://github.com/tahoe-lafs/tahoe-lafs/pull/425) is a PR to fix 23 of the 31 current warnings. I'm still working on the remaining 8.
In 0386e0d/trunk: