remove/conditionalize "shutilwhich" dependency #2856

New Issue

warner · 2016-12-25T18:55:27Z

warner commented

2016-12-25 18:55:27 +00:00

Somewhere in the 1.12 development cycle, _auto_deps.py acquired an unconditional dependency upon a package named shutilwhich. This impacts downstream packagers (i.e. it isn't in Debian yet). Looking at the code, it seems that shutilwhich is only used by the integration tests, and thus should probably be moved into the test clause of setup.py's extras_require=. That would let non-testing downstream packages omit the dependency.

Somewhere in the 1.12 development cycle, `_auto_deps.py` acquired an unconditional dependency upon a package named `shutilwhich`. This impacts downstream packagers (i.e. it isn't in Debian yet). Looking at the code, it seems that `shutilwhich` is only used by the integration tests, and thus should probably be moved into the `test` clause of setup.py's `extras_require=`. That would let non-testing downstream packages omit the dependency.

warner added the

labels 2016-12-25 18:55:27 +00:00

warner added this to the undecided milestone 2016-12-25 18:55:27 +00:00

warner modified the milestone from undecided to 1.12.1

2016-12-25 18:56:20 +00:00

crwood commented

2016-12-27 16:34:31 +00:00

Twisted has a which() in twisted.python.procutils that could be used in place of shutilwhich (though it returns a list of filepaths):

https://twistedmatrix.com/documents/current/api/twisted.python.procutils.html

For simplicity's sake, it might be better to just use that instead.

Twisted has a `which()` in `twisted.python.procutils` that could be used in place of `shutilwhich` (though it returns a list of filepaths): <https://twistedmatrix.com/documents/current/api/twisted.python.procutils.html> For simplicity's sake, it might be better to just use that instead.

Brian Warner <warner@lothar.com> commented

2017-01-08 23:22:38 +00:00

In 79ff7ae/trunk:

move 'shutilwhich' dependency out to the [test] extra

This is only used by integration/conftest.py, so we don't need an
unconditional dependency on it.

closes ticket:2856

In [79ff7ae/trunk](/tahoe-lafs/trac-2024-07-25/commit/79ff7ae5cb3b9cd1489c5e514ce7f1650028424e): ``` move 'shutilwhich' dependency out to the [test] extra This is only used by integration/conftest.py, so we don't need an unconditional dependency on it. closes ticket:2856 ```

tahoe-lafs added the

fixed

label 2017-01-08 23:22:38 +00:00

tahoe-lafs closed this issue

2017-01-08 23:22:38 +00:00

warner commented

2017-01-08 23:25:29 +00:00

oh, let's leave this open (but pushed out of the 1.12.1 milestone), to get that shutilwhich replaced by a normal twisted procutils.which (which we're already using in allmydata.util.iputil to find ifconfig-like programs).

oh, let's leave this open (but pushed out of the 1.12.1 milestone), to get that `shutilwhich` replaced by a normal twisted `procutils.which` (which we're already using in `allmydata.util.iputil` to find `ifconfig`-like programs).

warner removed the

fixed

label 2017-01-08 23:25:29 +00:00

warner modified the milestone from 1.12.1 to 1.13.0

2017-01-08 23:25:29 +00:00

warner reopened this issue

2017-01-08 23:25:29 +00:00

warner commented

2017-01-08 23:26:19 +00:00

I'll point this ticket at meejah, as he wrote integration/conftest.py that uses it

I'll point this ticket at meejah, as he wrote `integration/conftest.py` that uses it

dawuud commented