magic-folder: watched sub-dir watched after being removed from magic-folder #2836

New Issue

tahoe-lafs · 2016-10-06T13:14:12Z

dawuud commented

2016-10-06 13:14:12 +00:00

inotify is used in non-recursive mode on the magic-folder however additional directories which are added are done so in recursive mode. why this inconsistency? i think we should always use recursive mode!

however even after applying recursive inotify everywhere we still must remove directories from our watch when they are moved out of the magic-folder.

inotify is used in non-recursive mode on the magic-folder however additional directories which are added are done so in recursive mode. why this inconsistency? i think we should always use recursive mode! however even after applying recursive inotify everywhere we still must remove directories from our watch when they are moved out of the magic-folder.

tahoe-lafs added the

labels 2016-10-06 13:14:12 +00:00

tahoe-lafs added this to the undecided milestone 2016-10-06 13:14:12 +00:00

dawuud commented

2016-10-06 14:40:42 +00:00

if we added another field in our magic-folder database schema... file object type... then we could use it to distinguish files versus directories... and thereby detect removed directories and perform a subsequent inotify.ignore to remove our watch of that directory.

what do you think?

if we added another field in our magic-folder database schema... file object type... then we could use it to distinguish files versus directories... and thereby detect removed directories and perform a subsequent inotify.ignore to remove our watch of that directory. what do you think?

tahoe-lafs changed title from ~~magic-folder: watched sub-dir stilled watched after being removed from magic-folder~~ to magic-folder: watched sub-dir watched after being removed from magic-folder

2016-10-13 14:54:56 +00:00

dawuud commented

2016-10-13 15:05:01 +00:00

my attempt to inotify.ignore sub-dirs that are moved out of the magic-folder:
https://github.com/david415/tahoe-lafs/tree/2836.not_watch_moved_dir.1

my attempt to inotify.ignore sub-dirs that are moved out of the magic-folder: <https://github.com/david415/tahoe-lafs/tree/2836.not_watch_moved_dir.1>

tahoe-lafs added

code-frontend-magic-folder

and removed

unknown

labels 2016-10-13 15:11:05 +00:00

dawuud commented

2016-10-14 10:10:47 +00:00

another dev branch:
https://github.com/david415/tahoe-lafs/tree/2836.not_watch_moved_dir.2

added a test_move_tree_out... however this test passes even without the additional call to self._notifier.ignore; perhaps inotify is ignoring directories moved out of the watched directory? already?

another dev branch: <https://github.com/david415/tahoe-lafs/tree/2836.not_watch_moved_dir.2> added a test_move_tree_out... however this test passes even without the additional call to self._notifier.ignore; perhaps inotify is ignoring directories moved out of the watched directory? already?

exarkun commented

2020-06-30 13:47:37 +00:00

magic-folder has been split out into a separate project - https://github.com/leastauthority/magic-folder

magic-folder has been split out into a separate project - <https://github.com/leastauthority/magic-folder>

exarkun added the

somebody else's problem

label 2020-06-30 13:47:37 +00:00

exarkun closed this issue

2020-06-30 13:47:37 +00:00

Sign in to join this conversation.