--hide-ip should turn on connections tcp=tor #2820

New Issue

warner · 2016-09-03T19:00:01Z

warner commented

2016-09-03 19:00:01 +00:00

While manually testing tor-based client setup, I hit an extra step that I thought could be removed. While we've defined the node reveal-IP-address = false setting to be purely a safety flag (the only thing it can do is hit the brakes on node startup), I think it might be ok to have the --hide-ip CLI argument be more active.

In particular, I think I'd like --hide-ip to cause two things to happen:

set node reveal-IP-address = false
add connections tcp = tor

The reasoning is that:

with reveal=false, the default tcp = tcp will be rejected
the only other legitimate value is tcp = tor (we might add tcp = none at some point, but that'll be strictly less functional than tor)

While manually testing tor-based client setup, I hit an extra step that I thought could be removed. While we've defined the `node reveal-IP-address = false` setting to be purely a safety flag (the only thing it can do is hit the brakes on node startup), I think it might be ok to have the `--hide-ip` CLI argument be more active. In particular, I think I'd like `--hide-ip` to cause *two* things to happen: * set `node reveal-IP-address = false` * add `connections tcp = tor` The reasoning is that: * with reveal=false, the default `tcp = tcp` will be rejected * the only other legitimate value is `tcp = tor` (we might add `tcp = none` at some point, but that'll be strictly less functional than tor)

warner added the

labels 2016-09-03 19:00:01 +00:00

warner added this to the 1.12.0 milestone 2016-09-03 19:00:01 +00:00

warner self-assigned this 2016-09-03 19:00:01 +00:00

dawuud commented

2016-09-13 11:40:03 +00:00

made this change and added a test case;
pull-request for your review here:
https://github.com/tahoe-lafs/tahoe-lafs/pull/343

made this change and added a test case; pull-request for your review here: <https://github.com/tahoe-lafs/tahoe-lafs/pull/343>

Brian Warner <warner@lothar.com> commented

2016-09-14 05:06:57 +00:00

In 3282f2a/trunk:

Merge PR 343 from david415/2820.hide_ip_set_tcp_tor.0

Closes ticket:2820

In [3282f2a/trunk](/tahoe-lafs/trac-2024-07-25/commit/3282f2aa8a0ae55918cfca40c86c8a561370cb37): ``` Merge PR 343 from david415/2820.hide_ip_set_tcp_tor.0 Closes ticket:2820 ```

tahoe-lafs added the

fixed

label 2016-09-14 05:06:57 +00:00

tahoe-lafs closed this issue

2016-09-14 05:06:57 +00:00

Sign in to join this conversation.