tahoe-lafs/trac-2024-07-25
2
0
Issues 1.1k Wiki

Magic Folder: Unicode-related test failures #2807

New Issue
Closed
opened 2016-08-16 16:34:03 +00:00 by daira · 5 comments
daira commented 2016-08-16 16:34:03 +00:00
Owner
Copy Link

(https://tahoe-lafs.org/buildbot-tahoe-lafs/builders/Markus%20slackware64%20stable/builds/225/steps/tox/logs/stdio)

[ERROR]
Traceback (most recent call last):
  File "/src/buildslave/tahoe-lafs/Markus_slackware64_stable/build/src/allmydata/test/test_magic_folder.py", line 1273, in setUp
    d = super(MockTest, self).setUp()
  File "/src/buildslave/tahoe-lafs/Markus_slackware64_stable/build/src/allmydata/test/test_magic_folder.py", line 966, in setUp
    d = self.create_invite_join_magic_folder(u"Alice\u0101", self.local_dir)
  File "/src/buildslave/tahoe-lafs/Markus_slackware64_stable/build/src/allmydata/test/cli/test_magic_folder.py", line 99, in create_invite_join_magic_folder
    nickname_arg = unicode_to_argv(nickname)
  File "/src/buildslave/tahoe-lafs/Markus_slackware64_stable/build/src/allmydata/util/encodingutil.py", line 123, in unicode_to_argv
    return s.encode(io_encoding)
exceptions.UnicodeEncodeError: 'ascii' codec can't encode character u'\u0101' in position 5: ordinal not in range(128)

allmydata.test.test_magic_folder.MockTest.test_db_basic
allmydata.test.test_magic_folder.MockTest.test_db_persistence
allmydata.test.test_magic_folder.MockTest.test_delete
allmydata.test.test_magic_folder.MockTest.test_delete_and_restore
allmydata.test.test_magic_folder.MockTest.test_errors
allmydata.test.test_magic_folder.MockTest.test_magic_folder
allmydata.test.test_magic_folder.MockTest.test_move_tree
allmydata.test.test_magic_folder.MockTest.test_periodic_full_scan
allmydata.test.test_magic_folder.MockTest.test_persistence
allmydata.test.test_magic_folder.MockTest.test_scan_once_on_startup
allmydata.test.test_magic_folder.MockTest.test_statistics
allmydata.test.test_magic_folder.MockTest.test_write_downloaded_file
===============================================================================
[...]

[ERROR]
Traceback (most recent call last):
  File "/src/buildslave/tahoe-lafs/Markus_slackware64_stable/build/src/allmydata/test/test_magic_folder.py", line 249, in <lambda>
    d.addCallback(lambda ign: self.do_invite(0, u"Alice\u00F8"))
  File "/src/buildslave/tahoe-lafs/Markus_slackware64_stable/build/src/allmydata/test/cli/test_magic_folder.py", line 35, in do_invite
    nickname_arg = unicode_to_argv(nickname)
  File "/src/buildslave/tahoe-lafs/Markus_slackware64_stable/build/src/allmydata/util/encodingutil.py", line 123, in unicode_to_argv
    return s.encode(io_encoding)
exceptions.UnicodeEncodeError: 'ascii' codec can't encode character u'\xf8' in position 5: ordinal not in range(128)

allmydata.test.test_magic_folder.MockTestAliceBob.test_alice_bob
allmydata.test.test_magic_folder.MockTestAliceBob.test_alice_create_bob_update
allmydata.test.test_magic_folder.MockTestAliceBob.test_alice_delete_and_restore
allmydata.test.test_magic_folder.MockTestAliceBob.test_alice_delete_bob_restore
allmydata.test.test_magic_folder.MockTestAliceBob.test_alice_sees_bobs_delete_with_error
allmydata.test.test_magic_folder.MockTestAliceBob.test_download_retry
allmydata.test.test_magic_folder.RealTestAliceBob.test_alice_bob
allmydata.test.test_magic_folder.RealTestAliceBob.test_alice_create_bob_update
allmydata.test.test_magic_folder.RealTestAliceBob.test_alice_delete_and_restore
allmydata.test.test_magic_folder.RealTestAliceBob.test_alice_delete_bob_restore
allmydata.test.test_magic_folder.RealTestAliceBob.test_alice_sees_bobs_delete_with_error
allmydata.test.test_magic_folder.RealTestAliceBob.test_download_retry
===============================================================================

[ERROR]
Traceback (most recent call last):
  File "/src/buildslave/tahoe-lafs/Markus_slackware64_stable/build/src/allmydata/test/test_magic_folder.py", line 1430, in setUp
    d = super(RealTest, self).setUp()
  File "/src/buildslave/tahoe-lafs/Markus_slackware64_stable/build/src/allmydata/test/test_magic_folder.py", line 966, in setUp
    d = self.create_invite_join_magic_folder(u"Alice\u0101", self.local_dir)
  File "/src/buildslave/tahoe-lafs/Markus_slackware64_stable/build/src/allmydata/test/cli/test_magic_folder.py", line 99, in create_invite_join_magic_folder
    nickname_arg = unicode_to_argv(nickname)
  File "/src/buildslave/tahoe-lafs/Markus_slackware64_stable/build/src/allmydata/util/encodingutil.py", line 123, in unicode_to_argv
    return s.encode(io_encoding)
exceptions.UnicodeEncodeError: 'ascii' codec can't encode character u'\u0101' in position 5: ordinal not in range(128)

allmydata.test.test_magic_folder.RealTest.test_db_basic
allmydata.test.test_magic_folder.RealTest.test_db_persistence
allmydata.test.test_magic_folder.RealTest.test_delete
allmydata.test.test_magic_folder.RealTest.test_delete_and_restore
allmydata.test.test_magic_folder.RealTest.test_magic_folder
allmydata.test.test_magic_folder.RealTest.test_move_tree
allmydata.test.test_magic_folder.RealTest.test_persistence
allmydata.test.test_magic_folder.RealTest.test_scan_once_on_startup
===============================================================================
(https://tahoe-lafs.org/buildbot-tahoe-lafs/builders/Markus%20slackware64%20stable/builds/225/steps/tox/logs/stdio) ``` [ERROR] Traceback (most recent call last): File "/src/buildslave/tahoe-lafs/Markus_slackware64_stable/build/src/allmydata/test/test_magic_folder.py", line 1273, in setUp d = super(MockTest, self).setUp() File "/src/buildslave/tahoe-lafs/Markus_slackware64_stable/build/src/allmydata/test/test_magic_folder.py", line 966, in setUp d = self.create_invite_join_magic_folder(u"Alice\u0101", self.local_dir) File "/src/buildslave/tahoe-lafs/Markus_slackware64_stable/build/src/allmydata/test/cli/test_magic_folder.py", line 99, in create_invite_join_magic_folder nickname_arg = unicode_to_argv(nickname) File "/src/buildslave/tahoe-lafs/Markus_slackware64_stable/build/src/allmydata/util/encodingutil.py", line 123, in unicode_to_argv return s.encode(io_encoding) exceptions.UnicodeEncodeError: 'ascii' codec can't encode character u'\u0101' in position 5: ordinal not in range(128) allmydata.test.test_magic_folder.MockTest.test_db_basic allmydata.test.test_magic_folder.MockTest.test_db_persistence allmydata.test.test_magic_folder.MockTest.test_delete allmydata.test.test_magic_folder.MockTest.test_delete_and_restore allmydata.test.test_magic_folder.MockTest.test_errors allmydata.test.test_magic_folder.MockTest.test_magic_folder allmydata.test.test_magic_folder.MockTest.test_move_tree allmydata.test.test_magic_folder.MockTest.test_periodic_full_scan allmydata.test.test_magic_folder.MockTest.test_persistence allmydata.test.test_magic_folder.MockTest.test_scan_once_on_startup allmydata.test.test_magic_folder.MockTest.test_statistics allmydata.test.test_magic_folder.MockTest.test_write_downloaded_file =============================================================================== [...] [ERROR] Traceback (most recent call last): File "/src/buildslave/tahoe-lafs/Markus_slackware64_stable/build/src/allmydata/test/test_magic_folder.py", line 249, in <lambda> d.addCallback(lambda ign: self.do_invite(0, u"Alice\u00F8")) File "/src/buildslave/tahoe-lafs/Markus_slackware64_stable/build/src/allmydata/test/cli/test_magic_folder.py", line 35, in do_invite nickname_arg = unicode_to_argv(nickname) File "/src/buildslave/tahoe-lafs/Markus_slackware64_stable/build/src/allmydata/util/encodingutil.py", line 123, in unicode_to_argv return s.encode(io_encoding) exceptions.UnicodeEncodeError: 'ascii' codec can't encode character u'\xf8' in position 5: ordinal not in range(128) allmydata.test.test_magic_folder.MockTestAliceBob.test_alice_bob allmydata.test.test_magic_folder.MockTestAliceBob.test_alice_create_bob_update allmydata.test.test_magic_folder.MockTestAliceBob.test_alice_delete_and_restore allmydata.test.test_magic_folder.MockTestAliceBob.test_alice_delete_bob_restore allmydata.test.test_magic_folder.MockTestAliceBob.test_alice_sees_bobs_delete_with_error allmydata.test.test_magic_folder.MockTestAliceBob.test_download_retry allmydata.test.test_magic_folder.RealTestAliceBob.test_alice_bob allmydata.test.test_magic_folder.RealTestAliceBob.test_alice_create_bob_update allmydata.test.test_magic_folder.RealTestAliceBob.test_alice_delete_and_restore allmydata.test.test_magic_folder.RealTestAliceBob.test_alice_delete_bob_restore allmydata.test.test_magic_folder.RealTestAliceBob.test_alice_sees_bobs_delete_with_error allmydata.test.test_magic_folder.RealTestAliceBob.test_download_retry =============================================================================== [ERROR] Traceback (most recent call last): File "/src/buildslave/tahoe-lafs/Markus_slackware64_stable/build/src/allmydata/test/test_magic_folder.py", line 1430, in setUp d = super(RealTest, self).setUp() File "/src/buildslave/tahoe-lafs/Markus_slackware64_stable/build/src/allmydata/test/test_magic_folder.py", line 966, in setUp d = self.create_invite_join_magic_folder(u"Alice\u0101", self.local_dir) File "/src/buildslave/tahoe-lafs/Markus_slackware64_stable/build/src/allmydata/test/cli/test_magic_folder.py", line 99, in create_invite_join_magic_folder nickname_arg = unicode_to_argv(nickname) File "/src/buildslave/tahoe-lafs/Markus_slackware64_stable/build/src/allmydata/util/encodingutil.py", line 123, in unicode_to_argv return s.encode(io_encoding) exceptions.UnicodeEncodeError: 'ascii' codec can't encode character u'\u0101' in position 5: ordinal not in range(128) allmydata.test.test_magic_folder.RealTest.test_db_basic allmydata.test.test_magic_folder.RealTest.test_db_persistence allmydata.test.test_magic_folder.RealTest.test_delete allmydata.test.test_magic_folder.RealTest.test_delete_and_restore allmydata.test.test_magic_folder.RealTest.test_magic_folder allmydata.test.test_magic_folder.RealTest.test_move_tree allmydata.test.test_magic_folder.RealTest.test_persistence allmydata.test.test_magic_folder.RealTest.test_scan_once_on_startup =============================================================================== ```
tahoe-lafs added the
code-frontend-magic-folder
normal
defect
1.11.0
 labels 2016-08-16 16:34:03 +00:00
tahoe-lafs added this to the 1.12.0 milestone 2016-08-16 16:34:03 +00:00
daira commented 2016-09-06 17:08:34 +00:00
Author
Owner
Copy Link

The relevant line in cli/test_magic_folder.py is:

    nickname_arg = unicode_to_argv(nickname)

It (and the similar line after it) just needs a fallback if the character isn't representable in the argv encoding.

The relevant line in cli/test_magic_folder.py is: ``` nickname_arg = unicode_to_argv(nickname) ``` It (and the similar line after it) just needs a fallback if the character isn't representable in the argv encoding.
warner commented 2016-09-13 17:16:52 +00:00
Copy Link

I'll try making that change and see if the buildbot is happy.. if not, I'll reassign it back to daira for further investigation.

I'll try making that change and see if the buildbot is happy.. if not, I'll reassign it back to daira for further investigation.
daira commented 2016-09-27 15:13:00 +00:00
Author
Owner
Copy Link

(https://github.com/tahoe-lafs/tahoe-lafs/pull/356)

(https://github.com/tahoe-lafs/tahoe-lafs/pull/356)
Daira Hopwood <daira@jacaranda.org> commented 2016-09-27 16:30:16 +00:00
Author
Owner
Copy Link

In c9d73a9/trunk:

Fix Unicode-related Magic Folder test failures. fixes #2807

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
In [c9d73a9/trunk](/tahoe-lafs/trac-2024-07-25/commit/c9d73a936aac2ab6eb97f49e06e68774e5300ddc): ``` Fix Unicode-related Magic Folder test failures. fixes #2807 Signed-off-by: Daira Hopwood <daira@jacaranda.org> ```
tahoe-lafs added the
fixed
 label 2016-09-27 16:30:16 +00:00
Daira Hopwood <daira@jacaranda.org> closed this issue 2016-09-27 16:30:16 +00:00
Brian Warner <warner@lothar.com> commented 2016-09-27 17:32:37 +00:00
Author
Owner
Copy Link

In e8c246f/trunk:

Merge daira/2807.magic-folder-unicode-test-fail.1

refs ticket:2807

This allows tests to pass under an odd environment: our OS-X buildslave.
That process is started as a LaunchDaemon that doesn't provide any
Environment dictionary in the .plist file, so it runs with an empty
environment. On OS-X, this causes filesystem.encoding to default to
"utf-8", but locale.getpreferredencoding() returns "US-ASCII". The tests
previously assumed that any platform which used unicode for the
filesystem pathnames would also use it for sys.argv .

To simulate this without involving launchd, use "unset LANG", and
double-check that locale.getpreferredencoding() has changed.

This fix tolerates such platforms.
In [e8c246f/trunk](/tahoe-lafs/trac-2024-07-25/commit/e8c246f3465a97642d04fe74ec62dc706c99ec97): ``` Merge daira/2807.magic-folder-unicode-test-fail.1 refs ticket:2807 This allows tests to pass under an odd environment: our OS-X buildslave. That process is started as a LaunchDaemon that doesn't provide any Environment dictionary in the .plist file, so it runs with an empty environment. On OS-X, this causes filesystem.encoding to default to "utf-8", but locale.getpreferredencoding() returns "US-ASCII". The tests previously assumed that any platform which used unicode for the filesystem pathnames would also use it for sys.argv . To simulate this without involving launchd, use "unset LANG", and double-check that locale.getpreferredencoding() has changed. This fix tolerates such platforms. ```
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
0.2.0

   
0.3.0

   
0.4.0

   
0.5.0

   
0.5.1

   
0.6.0

   
0.6.1

   
0.7.0

   
0.8.0

   
0.9.0

   
1.0.0

   
1.1.0

   
1.10.0

   
1.10.1

   
1.10.2

   
1.10a2

   
1.11.0

   
1.12.0

   
1.12.1

   
1.13.0

   
1.14.0

   
1.15.0

   
1.15.1

   
1.2.0

   
1.3.0

   
1.4.1

   
1.5.0

   
1.6.0

   
1.6.1

   
1.7.0

   
1.7.1

   
1.7β

   
1.8.0

   
1.8.1

   
1.8.2

   
1.8.3

   
1.8β

   
1.9.0

   
1.9.0-s3branch

   
1.9.0a1

   
1.9.0a2

   
1.9.0b1

   
1.9.1

   
1.9.2

   
1.9.2a1

   
LeastAuthority.com automation

   
blocker

   
cannot reproduce

   
cloud-branch

   
code

catch-all for anything that can be fixed by writing code but isn't classified better

  
code-dirnodes

anything involving tahoe directories

  
code-encoding

immutable-file encoding format/layout, cap format, encoding/decoding algorithms

  
code-frontend

general frontend things: new user-facing interfaces, FTP/SFTP servers, FUSE-like interfaces

  
code-frontend-cli

CLI tools

  
code-frontend-ftp-sftp

   
code-frontend-magic-folder

   
code-frontend-web

webapi interfaces, user-facing "WUI" interfaces

  
code-mutable

anything involving mutable files: encoding/decoding, share format

  
code-network

Introducer, locating storage servers, establishing/maintaining connections to them

  
code-nodeadmin

node startup/shutdown, tools to create nodes, logging tools, management/monitoring tools, manhole, disk-space-limiting tools

  
code-peerselection

server selection/sorting algorithm, rebalancing code, allocation policy, swarming-download

  
code-storage

storage-server implementation, share-storage directory layout, client-to-server share transfer protocol

  
contrib

problems with non-core things that live in the source:contrib/ directory

  
critical

   
defect

   
dev-infrastructure

things that help us build Tahoe: buildbot, automated speed/memory/code-coverage tests and results-displayers, IRC channels, mailing lists, this Trac instance

  
documentation

docs items. Also use 'docs' keyword on tickets in more specific components.

  
duplicate

   
enhancement

   
fixed

   
invalid

   
major

   
minor

   
n/a

   
normal

   
operational

things involved in running a tahoe grid, external tools to monitor/maintain a grid (like "nodeadmin" but larger-scale). Was also used for issues with the allmydata.com grid.

  
packaging

setup.py script, library dependencies, binary packages, licensing, installation instructions

  
somebody else's problem

   
supercritical

   
task

   
trivial

   
unknown

Uncategorized. All tickets default to this component until someone updates it.

  
was already fixed

   
website

things about the tahoe-lafs.org website (and sometimes this Trac instance, shared with 'dev-infrastructure')

  
wontfix

   
worksforme
No Label
0.2.0
0.3.0
0.4.0
0.5.0
0.5.1
0.6.0
0.6.1
0.7.0
0.8.0
0.9.0
1.0.0
1.1.0
1.10.0
1.10.1
1.10.2
1.10a2
1.11.0
1.12.0
1.12.1
1.13.0
1.14.0
1.15.0
1.15.1
1.2.0
1.3.0
1.4.1
1.5.0
1.6.0
1.6.1
1.7.0
1.7.1
1.7β
1.8.0
1.8.1
1.8.2
1.8.3
1.8β
1.9.0
1.9.0-s3branch
1.9.0a1
1.9.0a2
1.9.0b1
1.9.1
1.9.2
1.9.2a1
LeastAuthority.com automation
blocker
cannot reproduce
cloud-branch
code
code-dirnodes
code-encoding
code-frontend
code-frontend-cli
code-frontend-ftp-sftp
code-frontend-magic-folder
code-frontend-web
code-mutable
code-network
code-nodeadmin
code-peerselection
code-storage
contrib
critical
defect
dev-infrastructure
documentation
duplicate
enhancement
fixed
invalid
major
minor
n/a
normal
operational
packaging
somebody else's problem
supercritical
task
trivial
unknown
was already fixed
website
wontfix
worksforme
Milestone
Clear milestone
No items
No Milestone
1.12.0
Assignees
Clear assignees
No Assignees
warner
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Reference: tahoe-lafs/trac-2024-07-25#2807
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?