add tests to catch things like tox.ini not being in MANIFEST.in #2779

New Issue

warner · 2016-04-13T07:00:01Z

warner commented

2016-04-13 07:00:01 +00:00

I got an IRC report today that you can't run tox from an unpacked 1.11.0 source tarball, because I forgot to include tox.ini in the MANIFEST.in file (so it doesn't get copied into sdist tarballs). Oops.

The task is to make a buildbot test that (via a checked-in helper script) makes an sdist tarball, unpacks it into a new directory, then steps into that directory and runs 'tox' successfully.

It's probably ok if we don't run a full test suite, just enough to make sure the test files got copied in.

It might also be good to have a script that builds+unpacks an sdist, then compares the files in the original (git checkout) source tree against the unpacked ones, and fails if there are any unexpected differences.

I got an IRC report today that you can't run `tox` from an unpacked 1.11.0 source tarball, because I forgot to include `tox.ini` in the `MANIFEST.in` file (so it doesn't get copied into sdist tarballs). Oops. The task is to make a buildbot test that (via a checked-in helper script) makes an sdist tarball, unpacks it into a new directory, then steps into that directory and runs 'tox' successfully. It's probably ok if we don't run a full test suite, just enough to make sure the test files got copied in. It might also be good to have a script that builds+unpacks an sdist, then compares the files in the original (git checkout) source tree against the unpacked ones, and fails if there are any unexpected differences.

warner added the

labels 2016-04-13 07:00:01 +00:00

warner added this to the 1.12.0 milestone 2016-04-13 07:00:01 +00:00

Brian Warner <warner@lothar.com> commented

2016-04-13 07:03:27 +00:00

In 04f1a3c/trunk:

Merge branch 'pr259' from meejah:add-tox

refs ticket:2779

In [04f1a3c/trunk](/tahoe-lafs/trac-2024-07-25/commit/04f1a3c38de577a63ce24bf6737ec98d02be4a7d): ``` Merge branch 'pr259' from meejah:add-tox refs ticket:2779 ```