remove unnecessary dependencies #2766

New Issue

warner · 2016-04-01T18:22:31Z

warner commented

2016-04-01 18:22:31 +00:00

Let's remove characteristic right now, it's a throwback to some old pyopenssl thing, and the only place it exists at all in our depenency graph is in tahoe's _auto_deps.py.

Let's remove the transitive dependencies: things we claim to depend upon but never import:

pyopenssl
service-identity
pyasn1-modules
pyasn1

Let's do a global s/simplejson/json/ and stop depending on the simplejson module. The json in stdlib should be enough. (This is a leftover from the days of python2.5(?) that didn't have stdlib json, but now we require py2.7).

We need to retain twistedtls instead of just twisted because pip lacks a resolver.

Not a part of this ticket:

#2098 : get zfec to remove dependency on pyutil/zbase32

Let's remove `characteristic` right now, it's a throwback to some old pyopenssl thing, and the only place it exists at all in our depenency graph is in tahoe's `_auto_deps.py`. Let's remove the transitive dependencies: things we claim to depend upon but never import: * pyopenssl * service-identity * pyasn1-modules * pyasn1 Let's do a global `s/simplejson/json/` and stop depending on the `simplejson` module. The `json` in stdlib should be enough. (This is a leftover from the days of python2.5(?) that didn't have stdlib `json`, but now we require py2.7). We need to retain `twistedtls` instead of just `twisted` because pip lacks a resolver. Not a part of this ticket: * #2098 : get zfec to remove dependency on pyutil/zbase32

warner added the

labels 2016-04-01 18:22:31 +00:00

warner added this to the eventually milestone 2016-04-01 18:22:31 +00:00

warner commented

2016-04-04 05:29:27 +00:00

I'm working on this. The simplejson change is a bit involved (a couple of dozen files, and some use the json symbol as method or variable names already), but I'm almost done.

I'm working on this. The `simplejson` change is a bit involved (a couple of dozen files, and some use the `json` symbol as method or variable names already), but I'm almost done.

Brian Warner <warner@lothar.com> commented

2017-03-24 02:22:36 +00:00

In c1ed556/trunk:

Merge PR405: use stdlib "json" instead of simplejson

refs ticket:2766

In [c1ed556/trunk](/tahoe-lafs/trac-2024-07-25/commit/c1ed556d40b9002ae0540e300741d0091edd336b): ``` Merge PR405: use stdlib "json" instead of simplejson refs ticket:2766 ```

exarkun commented

2019-08-13 17:56:55 +00:00

(https://github.com/tahoe-lafs/tahoe-lafs/pull/642)

warner was unassigned by exarkun

2019-08-13 17:56:55 +00:00

GitHub <noreply@github.com> commented

2019-08-13 19:19:46 +00:00

In 6d14a2d/trunk:

Merge pull request #642 from tahoe-lafs/2766.remove-unnecessary-dependencies

Remove declaration of some unnecessary dependencies.

Fixes: ticket:2766

In [6d14a2d/trunk](/tahoe-lafs/trac-2024-07-25/commit/6d14a2d7192b37a90f90fb26c9576b4204b6f228): ``` Merge pull request #642 from tahoe-lafs/2766.remove-unnecessary-dependencies Remove declaration of some unnecessary dependencies. Fixes: ticket:2766 ```

tahoe-lafs added the

fixed

label 2019-08-13 19:19:46 +00:00

GitHub <noreply@github.com> closed this issue

2019-08-13 19:19:46 +00:00

Sign in to join this conversation.