stop using setup_requires on Windows #2473

Closed
opened 2015-07-21 19:04:20 +00:00 by zooko · 3 comments

If we removed the remaining use of [setup_requires]source:trunk/src/allmydata/_auto_deps.py?annotate=blame&rev=c830419e04eac49dc53bac4f7f37c755d685a772#L147, which applies only to Windows, I think it would fix at least the following tickets:

  • #2286 (the version of a library chosen for a setup requirement can conflict with a build requirement)
  • #2066 (setup.py performs work without a command being specified)

and it would be the next-step on improving these ones:

  • #2055 (Building tahoe safely is non-trivial)
  • #1220 (build/install should be able to refrain from getting dependencies)
  • #2077 (pip packaging plan)
If we removed the remaining use of [setup_requires]source:trunk/src/allmydata/_auto_deps.py?annotate=blame&rev=c830419e04eac49dc53bac4f7f37c755d685a772#L147, which applies only to Windows, I think it would fix at least the following tickets: * #2286 (the version of a library chosen for a setup requirement can conflict with a build requirement) * #2066 (setup.py performs work without a command being specified) and it would be the next-step on improving these ones: * #2055 (Building tahoe safely is non-trivial) * #1220 (build/install should be able to refrain from getting dependencies) * #2077 (pip packaging plan)
zooko added the
packaging
normal
enhancement
1.10.1
labels 2015-07-21 19:04:20 +00:00
zooko added this to the undecided milestone 2015-07-21 19:04:20 +00:00
daira commented 2015-07-21 20:07:52 +00:00
Owner

I think that we should press ahead with #2077 for non-Windows platforms and worry about removing the use of setup_requires on Windows later. This would avoid some thorny problems, including the fact that zetuptoolz does strange things on Windows to support running scripts.

I think that we should press ahead with #2077 for non-Windows platforms and worry about removing the use of `setup_requires` on Windows later. This would avoid some thorny problems, including the fact that zetuptoolz does strange things on Windows to support running scripts.
tahoe-lafs changed title from stop using `setup_requires` to stop using `setup_requires` on Windows 2015-07-21 20:07:52 +00:00
daira commented 2015-10-27 22:13:16 +00:00
Owner

The Magic Folder branch, https://github.com/tahoe-lafs/tahoe-lafs/commits/1431.magic-folder-windows.2, does not use setup_requires.

The Magic Folder branch, <https://github.com/tahoe-lafs/tahoe-lafs/commits/1431.magic-folder-windows.2>, does not use `setup_requires`.

We've stopped using setup_requires= everywhere, so this can be closed out.

We've stopped using `setup_requires=` everywhere, so this can be closed out.
warner added the
fixed
label 2016-03-26 23:17:12 +00:00
warner modified the milestone from undecided to 1.11.0 2016-03-26 23:17:12 +00:00
Sign in to join this conversation.
No Milestone
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Reference: tahoe-lafs/trac-2024-07-25#2473
No description provided.