name OS-X .pkg after the tahoe version #2393

New Issue

warner · 2015-03-20T19:36:06Z

warner commented

2015-03-20 19:36:06 +00:00

At present, the make build-osx-pkg always creates the same file: tahoe-lafs-osx.pkg. This is being uploaded to org, but because it always uses the same filename, it will overwrite the previous file each time.

We should change the build step to ask Tahoe for a version string, and incorporate that into the package name. Maybe tahoe-lafs-VERSION.osx.pkg ?

At present, the `make build-osx-pkg` always creates the same file: `tahoe-lafs-osx.pkg`. This is being uploaded to org, but because it always uses the same filename, it will overwrite the previous file each time. We should change the build step to ask Tahoe for a version string, and incorporate that into the package name. Maybe `tahoe-lafs-VERSION.osx.pkg` ?

warner added the

labels 2015-03-20 19:36:06 +00:00

warner added this to the soon milestone 2015-03-20 19:36:06 +00:00

daira commented

2015-03-21 17:34:46 +00:00

Let's use tahoe-lafs-VERSION-osx.pkg. The Makefile entry already computes the version number (using sh -c "cat src/allmydata/_version.py | grep verstr | head -n 1 | cut -d' ' -f 3"), so this should be easy.

Let's use `tahoe-lafs-VERSION-osx.pkg`. The `Makefile` entry already computes the version number (using `sh -c "cat src/allmydata/_version.py | grep verstr | head -n 1 | cut -d' ' -f 3"`), so this should be easy.

tahoe-lafs modified the milestone from soon to 1.10.1

2015-03-21 17:34:46 +00:00

warner commented

2015-03-21 21:21:26 +00:00

(https://github.com/tahoe-lafs/tahoe-lafs/pull/146) is ready for review

daira commented

2015-03-24 16:14:19 +00:00

Reviewed and merged in [610ba0e69ba430002680829b43f2c098c94d6b9c/trunk]. See this comment for a minor remaining issue.

Reviewed and merged in [610ba0e69ba430002680829b43f2c098c94d6b9c/trunk]. See [this comment](https://github.com/warner/tahoe-lafs/commit/05c69668018802a770c813f2a6d7d26a8d1790e2#commitcomment-10370992) for a minor remaining issue.

warner commented

2015-03-24 17:05:28 +00:00

I see you moved the version-computation down into build-osx-pkg.py, sounds fine to me. In the long run (after 1.10.1, when we add Versioneer, for which I can't seem to find a ticket), the version will be computed with python setup.py version, instead of slicing+dicing the pre-generated _version.py. But that command can be run equally well from the Makefile or from build-osx-pkg.py.

I see you moved the version-computation down into build-osx-pkg.py, sounds fine to me. In the long run (after 1.10.1, when we add Versioneer, for which I can't seem to find a ticket), the version will be computed with `python setup.py version`, instead of slicing+dicing the pre-generated `_version.py`. But that command can be run equally well from the Makefile or from build-osx-pkg.py.

warner added the

fixed

label 2015-03-24 17:05:28 +00:00

warner closed this issue

2015-03-24 17:05:28 +00:00

daira commented

2015-03-24 17:27:16 +00:00

Yes, I addressed that comment in [61f3d5ae1343836e76901a36db1c93541cd66251/trunk].

Sign in to join this conversation.