add integration tests for SFTP public key auth #2359

Open
opened 2015-01-07 00:32:00 +00:00 by daira · 5 comments
daira commented 2015-01-07 00:32:00 +00:00
Owner

#1411 added support for SFTP public key authentication. This included sufficient test coverage to be merged in time for v1.11, but as exarkun said on the pull request,

  • I didn't see an easy, useful way to unit test the addition of ISSHPrivateKey to credentialInterfaces
  • These unit tests don't prove the new functionality actually integrates properly with the rest of the system. I didn't see any existing convention for integration or functional testing to cover this sort of thing.
#1411 added support for SFTP public key authentication. This included sufficient test coverage to be merged in time for v1.11, but as exarkun said on the [pull request](https://github.com/tahoe-lafs/tahoe-lafs/pull/134), > * I didn't see an easy, useful way to unit test the addition of `ISSHPrivateKey` to `credentialInterfaces` > * These unit tests don't prove the new functionality actually integrates properly with the rest of the system. I didn't see any existing convention for integration or functional testing to cover this sort of thing.
tahoe-lafs added the
code-frontend-ftp-sftp
normal
defect
1.10.0
labels 2015-01-07 00:32:00 +00:00
tahoe-lafs added this to the 1.12.0 milestone 2015-01-07 00:32:00 +00:00
daira commented 2015-01-07 00:39:40 +00:00
Author
Owner

See also #1697 (there is no test covering password-checking for SFTP or FTP).

See also #1697 (there is no test covering password-checking for SFTP or FTP).

Milestone renamed

Milestone renamed
warner modified the milestone from 1.12.0 to 1.13.0 2016-03-22 05:02:25 +00:00

renaming milestone

renaming milestone
warner modified the milestone from 1.13.0 to 1.14.0 2016-06-28 18:17:14 +00:00

Moving open issues out of closed milestones.

Moving open issues out of closed milestones.
exarkun modified the milestone from 1.14.0 to 1.15.0 2020-06-30 14:45:13 +00:00
Owner

Ticket retargeted after milestone closed

Ticket retargeted after milestone closed
meejah modified the milestone from 1.15.0 to soon 2021-03-30 18:40:19 +00:00
Sign in to join this conversation.
No Milestone
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Reference: tahoe-lafs/trac-2024-07-25#2359
No description provided.