tahoe-lafs/trac-2024-07-25
2
0
Issues 1.1k Wiki

replace non-Eliot logging with Eliot logging #2343

New Issue
Open
opened 2014-11-28 22:54:54 +00:00 by daira · 1 comment
daira commented 2014-11-28 22:54:54 +00:00
Owner
Copy Link

We should never be logging directly to the Foolscap or Twisted logs, because that is confusing and misleading, especially when log.err is used (e.g. see #812). We should be logging via Eliot instead.

$ grep -Rn --include='*.py' 'from twisted.python import .*log' src
src/allmydata/node.py:4:from twisted.python import log as twlog
src/allmydata/windows/tahoesvc.py:152:            from twisted.python import log, logfile
src/allmydata/util/iputil.py:10:from twisted.python import log
src/allmydata/util/fileutil.py:7:from twisted.python import log
src/allmydata/util/pipeline.py:4:from twisted.python import log
src/allmydata/util/log.py:4:from twisted.python import log as tw_log
src/allmydata/manhole.py:6:from twisted.python import log
src/allmydata/blacklist.py:6:from twisted.python import log as twisted_log
src/allmydata/web/common.py:4:from twisted.python import log
src/allmydata/storage/expirer.py:6:from twisted.python import log as twlog
src/allmydata/test/test_util.py:9:from twisted.python import log
src/allmydata/test/test_web.py:10:from twisted.python import failure, log
src/allmydata/test/test_introducer.py:8:from twisted.python import log
src/allmydata/test/check_memory.py:13:from twisted.python import log
src/allmydata/test/test_codec.py:4:from twisted.python import log
src/allmydata/test/check_speed.py:3:from twisted.python import log
src/allmydata/test/test_node.py:5:from twisted.python import log
src/allmydata/control.py:12:from twisted.python import log
$ grep -Rn --include='*.py' 'twisted.python.log' src
src/allmydata/test/test_client.py:56:    @mock.patch('twisted.python.log.msg')
We should never be logging directly to the Foolscap or Twisted logs, because that is confusing and misleading, especially when `log.err` is used (e.g. see #812). We should be logging via Eliot instead. ``` $ grep -Rn --include='*.py' 'from twisted.python import .*log' src src/allmydata/node.py:4:from twisted.python import log as twlog src/allmydata/windows/tahoesvc.py:152: from twisted.python import log, logfile src/allmydata/util/iputil.py:10:from twisted.python import log src/allmydata/util/fileutil.py:7:from twisted.python import log src/allmydata/util/pipeline.py:4:from twisted.python import log src/allmydata/util/log.py:4:from twisted.python import log as tw_log src/allmydata/manhole.py:6:from twisted.python import log src/allmydata/blacklist.py:6:from twisted.python import log as twisted_log src/allmydata/web/common.py:4:from twisted.python import log src/allmydata/storage/expirer.py:6:from twisted.python import log as twlog src/allmydata/test/test_util.py:9:from twisted.python import log src/allmydata/test/test_web.py:10:from twisted.python import failure, log src/allmydata/test/test_introducer.py:8:from twisted.python import log src/allmydata/test/check_memory.py:13:from twisted.python import log src/allmydata/test/test_codec.py:4:from twisted.python import log src/allmydata/test/check_speed.py:3:from twisted.python import log src/allmydata/test/test_node.py:5:from twisted.python import log src/allmydata/control.py:12:from twisted.python import log $ grep -Rn --include='*.py' 'twisted.python.log' src src/allmydata/test/test_client.py:56: @mock.patch('twisted.python.log.msg') ```
tahoe-lafs added the
code
normal
defect
1.10.0
 labels 2014-11-28 22:54:54 +00:00
tahoe-lafs added this to the undecided milestone 2014-11-28 22:54:54 +00:00
exarkun commented 2020-01-17 15:45:06 +00:00
Copy Link

I think the first half of this is true but the second half should refer to Eliot, instead. Adjusting ticket accordingly.

I think the first half of this is true but the second half should refer to Eliot, instead. Adjusting ticket accordingly.
exarkun changed title from remove all direct logging to twisted.python.log/err to replace non-Eliot logging with Eliot logging 2020-01-17 15:45:06 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
0.2.0

   
0.3.0

   
0.4.0

   
0.5.0

   
0.5.1

   
0.6.0

   
0.6.1

   
0.7.0

   
0.8.0

   
0.9.0

   
1.0.0

   
1.1.0

   
1.10.0

   
1.10.1

   
1.10.2

   
1.10a2

   
1.11.0

   
1.12.0

   
1.12.1

   
1.13.0

   
1.14.0

   
1.15.0

   
1.15.1

   
1.2.0

   
1.3.0

   
1.4.1

   
1.5.0

   
1.6.0

   
1.6.1

   
1.7.0

   
1.7.1

   
1.7β

   
1.8.0

   
1.8.1

   
1.8.2

   
1.8.3

   
1.8β

   
1.9.0

   
1.9.0-s3branch

   
1.9.0a1

   
1.9.0a2

   
1.9.0b1

   
1.9.1

   
1.9.2

   
1.9.2a1

   
LeastAuthority.com automation

   
blocker

   
cannot reproduce

   
cloud-branch

   
code

catch-all for anything that can be fixed by writing code but isn't classified better

  
code-dirnodes

anything involving tahoe directories

  
code-encoding

immutable-file encoding format/layout, cap format, encoding/decoding algorithms

  
code-frontend

general frontend things: new user-facing interfaces, FTP/SFTP servers, FUSE-like interfaces

  
code-frontend-cli

CLI tools

  
code-frontend-ftp-sftp

   
code-frontend-magic-folder

   
code-frontend-web

webapi interfaces, user-facing "WUI" interfaces

  
code-mutable

anything involving mutable files: encoding/decoding, share format

  
code-network

Introducer, locating storage servers, establishing/maintaining connections to them

  
code-nodeadmin

node startup/shutdown, tools to create nodes, logging tools, management/monitoring tools, manhole, disk-space-limiting tools

  
code-peerselection

server selection/sorting algorithm, rebalancing code, allocation policy, swarming-download

  
code-storage

storage-server implementation, share-storage directory layout, client-to-server share transfer protocol

  
contrib

problems with non-core things that live in the source:contrib/ directory

  
critical

   
defect

   
dev-infrastructure

things that help us build Tahoe: buildbot, automated speed/memory/code-coverage tests and results-displayers, IRC channels, mailing lists, this Trac instance

  
documentation

docs items. Also use 'docs' keyword on tickets in more specific components.

  
duplicate

   
enhancement

   
fixed

   
invalid

   
major

   
minor

   
n/a

   
normal

   
operational

things involved in running a tahoe grid, external tools to monitor/maintain a grid (like "nodeadmin" but larger-scale). Was also used for issues with the allmydata.com grid.

  
packaging

setup.py script, library dependencies, binary packages, licensing, installation instructions

  
somebody else's problem

   
supercritical

   
task

   
trivial

   
unknown

Uncategorized. All tickets default to this component until someone updates it.

  
was already fixed

   
website

things about the tahoe-lafs.org website (and sometimes this Trac instance, shared with 'dev-infrastructure')

  
wontfix

   
worksforme
No Label
0.2.0
0.3.0
0.4.0
0.5.0
0.5.1
0.6.0
0.6.1
0.7.0
0.8.0
0.9.0
1.0.0
1.1.0
1.10.0
1.10.1
1.10.2
1.10a2
1.11.0
1.12.0
1.12.1
1.13.0
1.14.0
1.15.0
1.15.1
1.2.0
1.3.0
1.4.1
1.5.0
1.6.0
1.6.1
1.7.0
1.7.1
1.7β
1.8.0
1.8.1
1.8.2
1.8.3
1.8β
1.9.0
1.9.0-s3branch
1.9.0a1
1.9.0a2
1.9.0b1
1.9.1
1.9.2
1.9.2a1
LeastAuthority.com automation
blocker
cannot reproduce
cloud-branch
code
code-dirnodes
code-encoding
code-frontend
code-frontend-cli
code-frontend-ftp-sftp
code-frontend-magic-folder
code-frontend-web
code-mutable
code-network
code-nodeadmin
code-peerselection
code-storage
contrib
critical
defect
dev-infrastructure
documentation
duplicate
enhancement
fixed
invalid
major
minor
n/a
normal
operational
packaging
somebody else's problem
supercritical
task
trivial
unknown
was already fixed
website
wontfix
worksforme
Milestone
Clear milestone
No items
No Milestone
undecided
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Reference: tahoe-lafs/trac-2024-07-25#2343
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?