poor error reporting when "git describe" fails during setup.py update_version #2340

New Issue

tahoe-lafs · 2014-11-21T00:33:11Z

cipherpunks commented

2014-11-21 00:33:11 +00:00

Suppose we are building from a copy of a git repo. If git describe fails (for example because git is not actually installed), the resulting tahoe will not know its version, but there will be no errors or warnings during the build. If tahoe does not know its version then some tests will fail when trying to import allmydata._version.

Suppose we are building from a copy of a git repo. If `git describe` fails (for example because `git` is not actually installed), the resulting `tahoe` will not know its version, but there will be no errors or warnings during the build. If `tahoe` does not know its version then some tests will fail when trying to import `allmydata._version`.

tahoe-lafs added the

labels 2014-11-21 00:33:11 +00:00

tahoe-lafs added this to the undecided milestone 2014-11-21 00:33:11 +00:00

daira commented

2014-11-22 00:06:27 +00:00

Fixed in [4421e8a84b1fe81ee7ed32ee2d07eae00b629aa2/trunk]. The update_version step now prints a warning when it cannot find the version. Specifically, if there is a .git directory then it tries to update the version; if that fails or there was neither a .git directory nor a _version.py file, then it prints:

********************************************************************
Warning: no version information found. This may cause tests to fail. 
********************************************************************

Fixed in [4421e8a84b1fe81ee7ed32ee2d07eae00b629aa2/trunk]. The update_version step now prints a warning when it cannot find the version. Specifically, if there is a `.git` directory then it tries to update the version; if that fails *or* there was neither a `.git` directory nor a `_version.py` file, then it prints: ``` ******************************************************************** Warning: no version information found. This may cause tests to fail. ******************************************************************** ```