allmydata.test.test_cli.Cp.test_copy_using_filecap is really slow due to a test bug #2048

New Issue

tahoe-lafs · 2013-08-07T16:16:56Z

daira commented

2013-08-07 16:16:56 +00:00

The fix for #1805 (changeset:595d611c9b4b29c8/trunk) added the following code in allmydata.test.test_cli.Cp.test_copy_using_filecap:

        #  cp --verbose filename3 dircap:test_file
        d.addCallback(lambda ign:
                      self.do_cli("cp", "--verbose", '--recursive', self.basedir, self.dircap))
        def _test_for_wrong_indices((rc, out, err)):
            self.failUnless('examining 1 of 1\n' in err)
        d.addCallback(_test_for_wrong_indices)

The tahoe cp command is copying the whole basedir of the test recursively into the self.dircap directory, which is definitely not what we want, and is really slow.

The fix for #1805 (changeset:595d611c9b4b29c8/trunk) added the following code in allmydata.test.test_cli.Cp.test_copy_using_filecap: ``` # cp --verbose filename3 dircap:test_file d.addCallback(lambda ign: self.do_cli("cp", "--verbose", '--recursive', self.basedir, self.dircap)) def _test_for_wrong_indices((rc, out, err)): self.failUnless('examining 1 of 1\n' in err) d.addCallback(_test_for_wrong_indices) ``` The `tahoe cp` command is copying the whole basedir of the test recursively into the `self.dircap` directory, which is definitely not what we want, and is really slow.

tahoe-lafs added the

labels 2013-08-07 16:16:56 +00:00

tahoe-lafs added this to the soon milestone 2013-08-07 16:16:56 +00:00

daira commented

2013-08-11 13:13:31 +00:00

See branch https://github.com/tahoe-lafs/tahoe-lafs/commits/2048-test-copy-using-filecap.

See branch <https://github.com/tahoe-lafs/tahoe-lafs/commits/2048-test-copy-using-filecap>.

markberger was assigned by tahoe-lafs

2013-08-11 13:13:31 +00:00

daira commented

2014-03-27 22:17:07 +00:00

I just pushed a rebase to current trunk on that branch.

tahoe-lafs modified the milestone from soon to 1.11.0

2014-03-27 22:19:05 +00:00

remyroy commented

2014-05-05 14:06:45 +00:00

I just completed the review of https://github.com/tahoe-lafs/tahoe-lafs/commits/2048-test-copy-using-filecap .

Everything is fine. Good job.

Transferring this ticket back to daira for merge in trunk.

I just completed the review of <https://github.com/tahoe-lafs/tahoe-lafs/commits/2048-test-copy-using-filecap> . Everything is fine. Good job. Transferring this ticket back to daira for merge in trunk.

daira commented

2014-05-05 14:30:31 +00:00

Thanks, will commit now.

Daira Hopwood <daira@jacaranda.org> commented

2014-05-05 14:46:41 +00:00

In /tahoe-lafs/trac-2024-07-25/commit/20b26f773b6c910a8da4122730f58b86509d611b:

Fix #2048 (test_copy_using_filecap was doing much more work than necessary).

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

In [/tahoe-lafs/trac-2024-07-25/commit/20b26f773b6c910a8da4122730f58b86509d611b](/tahoe-lafs/trac-2024-07-25/commit/20b26f773b6c910a8da4122730f58b86509d611b): ``` Fix #2048 (test_copy_using_filecap was doing much more work than necessary). Signed-off-by: Daira Hopwood <daira@jacaranda.org> ```

tahoe-lafs added the

fixed

label 2014-05-05 14:46:41 +00:00

Daira Hopwood <daira@jacaranda.org> closed this issue

2014-05-05 14:46:41 +00:00

Daira Hopwood <daira@jacaranda.org> commented

2014-05-05 14:47:18 +00:00

In /tahoe-lafs/trac-2024-07-25/commit/20b26f773b6c910a8da4122730f58b86509d611b:

Fix #2048 (test_copy_using_filecap was doing much more work than necessary).

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

In [/tahoe-lafs/trac-2024-07-25/commit/20b26f773b6c910a8da4122730f58b86509d611b](/tahoe-lafs/trac-2024-07-25/commit/20b26f773b6c910a8da4122730f58b86509d611b): ``` Fix #2048 (test_copy_using_filecap was doing much more work than necessary). Signed-off-by: Daira Hopwood <daira@jacaranda.org> ```

Daira Hopwood <daira@jacaranda.org> commented

2014-05-05 18:32:37 +00:00

In /tahoe-lafs/trac-2024-07-25/commit/20b26f773b6c910a8da4122730f58b86509d611b:

Fix #2048 (test_copy_using_filecap was doing much more work than necessary).

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

In [/tahoe-lafs/trac-2024-07-25/commit/20b26f773b6c910a8da4122730f58b86509d611b](/tahoe-lafs/trac-2024-07-25/commit/20b26f773b6c910a8da4122730f58b86509d611b): ``` Fix #2048 (test_copy_using_filecap was doing much more work than necessary). Signed-off-by: Daira Hopwood <daira@jacaranda.org> ```

Daira Hopwood <daira@jacaranda.org> commented

2014-05-05 18:33:37 +00:00

In /tahoe-lafs/trac-2024-07-25/commit/20b26f773b6c910a8da4122730f58b86509d611b:

Fix #2048 (test_copy_using_filecap was doing much more work than necessary).

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

In [/tahoe-lafs/trac-2024-07-25/commit/20b26f773b6c910a8da4122730f58b86509d611b](/tahoe-lafs/trac-2024-07-25/commit/20b26f773b6c910a8da4122730f58b86509d611b): ``` Fix #2048 (test_copy_using_filecap was doing much more work than necessary). Signed-off-by: Daira Hopwood <daira@jacaranda.org> ```

Daira Hopwood <daira@jacaranda.org> commented

2014-05-05 18:43:32 +00:00

In /tahoe-lafs/trac-2024-07-25/commit/20b26f773b6c910a8da4122730f58b86509d611b:

Fix #2048 (test_copy_using_filecap was doing much more work than necessary).

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

In [/tahoe-lafs/trac-2024-07-25/commit/20b26f773b6c910a8da4122730f58b86509d611b](/tahoe-lafs/trac-2024-07-25/commit/20b26f773b6c910a8da4122730f58b86509d611b): ``` Fix #2048 (test_copy_using_filecap was doing much more work than necessary). Signed-off-by: Daira Hopwood <daira@jacaranda.org> ```

Daira Hopwood <daira@jacaranda.org> commented

2014-05-05 18:45:25 +00:00

In /tahoe-lafs/trac-2024-07-25/commit/20b26f773b6c910a8da4122730f58b86509d611b:

Fix #2048 (test_copy_using_filecap was doing much more work than necessary).

Signed-off-by: Daira Hopwood <daira@jacaranda.org>

In [/tahoe-lafs/trac-2024-07-25/commit/20b26f773b6c910a8da4122730f58b86509d611b](/tahoe-lafs/trac-2024-07-25/commit/20b26f773b6c910a8da4122730f58b86509d611b): ``` Fix #2048 (test_copy_using_filecap was doing much more work than necessary). Signed-off-by: Daira Hopwood <daira@jacaranda.org> ```

Sign in to join this conversation.