pycrypto gives bad output from SHA-256 for certain input lengths #199

New Issue

zooko · 2007-11-01T17:08:23Z

zooko commented

2007-11-01 17:08:23 +00:00

The implementation of SHA-256 in pycrypto (which we use in Tahoe <= v0.6.1) gives the wrong output if the input length % 64 is 55.

The plan is to fix this by either applying another patch to our version of pycrypto or switching to a different crypto library. Investigating the latter is why I am working on pycryptopp.

The implementation of SHA-256 in pycrypto (which we use in Tahoe <= v0.6.1) gives the wrong output if the input length % 64 is 55. The plan is to fix this by either applying another patch to our version of pycrypto or switching to a different crypto library. Investigating the latter is why I am working on [pycryptopp](http://allmydata.org/pipermail/tahoe-dev/2007-October/000215.html).

zooko added the

labels 2007-11-01 17:08:23 +00:00

zooko added this to the 0.7.0 milestone 2007-11-01 17:08:23 +00:00

zooko self-assigned this 2007-11-01 17:08:23 +00:00

zooko added

code

and removed

unknown

labels 2007-11-07 05:32:59 +00:00

zooko commented

2007-11-07 05:56:11 +00:00

(http://allmydata.org/pipermail/tahoe-dev/2007-November/000231.html)

Next step: update tahoe README to state that the user has to manually install Crypto++, and update the tahoe automatic dependencies to depend on pycryptopp, and change our calls to pycryto's sha256 to pycryptopp's sha256.

(http://allmydata.org/pipermail/tahoe-dev/2007-November/000231.html) Next step: update tahoe README to state that the user has to manually install Crypto++, and update the tahoe automatic dependencies to depend on pycryptopp, and change our calls to pycryto's sha256 to pycryptopp's sha256.

zooko commented

2007-11-07 20:31:14 +00:00

Next step -- figure out why it doesn't compile on Brian's Mac OS X.

Next step after that -- change uses of pycrypto's SHA-256 to pycryptopp's SHA-256.

Next step -- figure out why it doesn't compile on Brian's Mac OS X. Next step after that -- change uses of pycrypto's SHA-256 to pycryptopp's SHA-256.

zooko commented

2007-11-08 00:04:47 +00:00

Fixed by changeset:11412da436be9e37.

(Except possibly for build/porting/packaging errors on some systems -- see the loyal BuildBot for details.)

Fixed by changeset:11412da436be9e37. (Except possibly for build/porting/packaging errors on some systems -- see the loyal [BuildBot](wiki/BuildBot) for details.)

zooko added the

fixed

label 2007-11-08 00:04:47 +00:00

zooko closed this issue

2007-11-08 00:04:47 +00:00

zooko commented

2007-11-09 19:32:21 +00:00

The version of pycryptopp that I used had a bug in the SHA-256 wrapper code. This bug is now fixed, so I'm now running tests and will re-apply this patch.

zooko removed the

fixed

label 2007-11-09 19:32:21 +00:00

zooko reopened this issue

2007-11-09 19:32:21 +00:00

zooko commented

2007-11-10 00:48:33 +00:00

closed again by changeset:5807e83f7ba926af

zooko added the

fixed

label 2007-11-10 00:48:33 +00:00

zooko closed this issue