WUI regression: Welcome page doesn't display on client-only nodes due to _node_key not being present. #1945

New Issue

tahoe-lafs · 2013-04-17T00:59:45Z

daira commented

2013-04-17 00:59:45 +00:00

See https://github.com/tahoe-lafs/tahoe-lafs/pull/40. However that seems like the wrong fix to me. Perhaps Client in source:src/allmydata/client.py should be calling self._maybe_create_node_key() unconditionally rather than only in init_storage(), so that all nodes have node keys?

See <https://github.com/tahoe-lafs/tahoe-lafs/pull/40>. However that seems like the wrong fix to me. Perhaps Client in source:src/allmydata/client.py should be calling self._maybe_create_node_key() unconditionally rather than only in init_storage(), so that all nodes have node keys?

tahoe-lafs added the

labels 2013-04-17 00:59:45 +00:00

tahoe-lafs added this to the 1.10.0 milestone 2013-04-17 00:59:45 +00:00

warner was assigned by tahoe-lafs

2013-04-17 01:00:25 +00:00

tahoe-lafs added

1.10a2

and removed

1.9.2

labels 2013-04-17 01:07:36 +00:00

warner commented

2013-04-17 01:17:22 +00:00

Yeah, all sorts of client-ish nodes (client-only and client-plus-server) should have these "node keys". I'll create a new method init_nodekey() and have it called (before init_storage()) unconditionally.

Good catch Leif!

Yeah, all sorts of client-ish nodes (client-only and client-plus-server) should have these "node keys". I'll create a new method `init_nodekey()` and have it called (before `init_storage()`) unconditionally. Good catch Leif!

daira commented

2013-04-17 01:47:25 +00:00

Also, we must not have had any test that depended on a node key being generated for a client-only node.

Brian Warner <warner@lothar.com> commented

2013-04-18 07:07:27 +00:00

In changeset:b989555d96e96b6f:

client.py: create node key even when storage is disabled. Closes #1945.

Thanks to Leif for the catch!

In changeset:b989555d96e96b6f: ``` client.py: create node key even when storage is disabled. Closes #1945. Thanks to Leif for the catch! ```

tahoe-lafs added the

fixed

label 2013-04-18 07:07:27 +00:00

tahoe-lafs closed this issue

2013-04-18 07:07:27 +00:00

daira commented

2013-04-18 15:21:43 +00:00

Reviewed, +1.

Sign in to join this conversation.

No Label

LeastAuthority.com automation

code-frontend-ftp-sftp

code-frontend-magic-folder

somebody else's problem

No Milestone

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Reference: tahoe-lafs/trac-2024-07-25#1945