drop the darcsver egg #1908

New Issue

tahoe-lafs · 2013-01-27T00:16:37Z

davidsarah commented

2013-01-27 00:16:37 +00:00

source:darcsver-1.7.2.egg is probably no longer needed now that we're doing the 1.10 release completely in git.

tahoe-lafs added the

labels 2013-01-27 00:16:37 +00:00

tahoe-lafs added this to the undecided milestone 2013-01-27 00:16:37 +00:00

zooko was assigned by tahoe-lafs

2013-01-27 00:16:37 +00:00

davidsarah commented

2013-02-16 19:25:31 +00:00

I thought this was an easy ticket, but it turns out that removing darcsver-1.7.2.egg results in setup.py update_version breaking (even in a git checkout), with this error:

$ python setup.py build
/usr/lib/python2.7/distutils/dist.py:267: UserWarning: Unknown distribution option: 'versionfiles'
  warnings.warn(msg)
running update_version
Traceback (most recent call last):
  File "setup.py", line 468, in <module>
    **setup_args
  File "/usr/lib/python2.7/distutils/core.py", line 152, in setup
    dist.run_commands()
  File "/usr/lib/python2.7/distutils/dist.py", line 953, in run_commands
    self.run_command(cmd)
  File "/usr/lib/python2.7/distutils/dist.py", line 972, in run_command
    cmd_obj.run()
  File "setup.py", line 341, in run
    target = self.distribution.versionfiles[0]
AttributeError: Distribution instance has no attribute 'versionfiles'

It's easy enough to tolerate lack of the 'versionfiles' attribute in setup.py, but I think that's the wrong fix.

I thought this was an easy ticket, but it turns out that removing darcsver-1.7.2.egg results in `setup.py update_version` breaking (even in a git checkout), with this error: ``` $ python setup.py build /usr/lib/python2.7/distutils/dist.py:267: UserWarning: Unknown distribution option: 'versionfiles' warnings.warn(msg) running update_version Traceback (most recent call last): File "setup.py", line 468, in <module> **setup_args File "/usr/lib/python2.7/distutils/core.py", line 152, in setup dist.run_commands() File "/usr/lib/python2.7/distutils/dist.py", line 953, in run_commands self.run_command(cmd) File "/usr/lib/python2.7/distutils/dist.py", line 972, in run_command cmd_obj.run() File "setup.py", line 341, in run target = self.distribution.versionfiles[0] AttributeError: Distribution instance has no attribute 'versionfiles' ``` It's easy enough to tolerate lack of the 'versionfiles' attribute in setup.py, but I think that's the wrong fix.

davidsarah commented

2013-02-16 19:29:53 +00:00

Use this branch to reproduce the above error: https://github.com/davidsarah/tahoe-lafs/commits/1908-drop-darcsver-egg

Use this branch to reproduce the above error: <https://github.com/davidsarah/tahoe-lafs/commits/1908-drop-darcsver-egg>

zooko commented

2013-02-18 19:16:51 +00:00

We should replace the functionality that darcsver used to provide. The best way to do this would probably be to use Brian's "versioneer" (https://blog.mozilla.org/warner/2012/01/31/version-string-management-in-python-introducing-python-versioneer/), like pycryptopp does (https://tahoe-lafs.org/trac/pycryptopp/browser/git/setup.py?annotate=blame&rev=f789ed951b49b33e7cc49d16fdc8b398f7ec7223).

We should replace the functionality that darcsver used to provide. The best way to do this would probably be to use Brian's "versioneer" (<https://blog.mozilla.org/warner/2012/01/31/version-string-management-in-python-introducing-python-versioneer/>), like pycryptopp does (<https://tahoe-lafs.org/trac/pycryptopp/browser/git/setup.py?annotate=blame&rev=f789ed951b49b33e7cc49d16fdc8b398f7ec7223>).

Brian Warner <warner@lothar.com> commented

2013-03-19 23:18:46 +00:00

In changeset:19b2ef9764bdb201:

Remove darcs from setup.py, remove darcsver egg. Closes #1908.

Also remove lingering traces of darcs from MANIFEST.in,
.darcs-boringfile, setup.cfg, and unit tests.

In changeset:19b2ef9764bdb201: ``` Remove darcs from setup.py, remove darcsver egg. Closes #1908. Also remove lingering traces of darcs from MANIFEST.in, .darcs-boringfile, setup.cfg, and unit tests. ```

tahoe-lafs added the

fixed

label 2013-03-19 23:18:46 +00:00

tahoe-lafs closed this issue

2013-03-19 23:18:46 +00:00

warner modified the milestone from undecided to 1.10.0

2013-03-19 23:20:24 +00:00

davidsarah commented

2013-03-20 21:33:58 +00:00

Nice to see the automated ticket-close messages working again!

Sign in to join this conversation.