storage indices are sometimes logged as binary #1800

Closed
opened 2012-09-04 23:32:44 +00:00 by davidsarah · 2 comments
davidsarah commented 2012-09-04 23:32:44 +00:00
Owner

In /tahoe-lafs/trac-2024-07-25/issues/6702#comment:19, there's an incident log that contains binary storage indices in the (human-readable) log message. They should be zbase32.

The offending code starts at source:src/allmydata/mutable/publish.py@5585#L1129, but the bug is on line 1138 (it should be base32.b2a(other_roothash)).

In [/tahoe-lafs/trac-2024-07-25/issues/6702](/tahoe-lafs/trac-2024-07-25/issues/6702)#comment:19, there's an incident log that contains binary storage indices in the (human-readable) log message. They should be zbase32. The offending code starts at source:src/allmydata/mutable/publish.py@5585#L1129, but the bug is on line 1138 (it should be `base32.b2a(other_roothash)`).
tahoe-lafs added the
code-mutable
normal
defect
1.9.2
labels 2012-09-04 23:32:44 +00:00
tahoe-lafs added this to the soon milestone 2012-09-04 23:32:44 +00:00
zooko was assigned by tahoe-lafs 2012-09-04 23:32:44 +00:00
daira commented 2013-10-31 16:02:46 +00:00
Author
Owner

Zooko already had a patch for this (see #1670).

Zooko already had a patch for this (see #1670).
tahoe-lafs modified the milestone from soon to 1.11.0 2013-10-31 16:02:46 +00:00
zooko was unassigned by warner 2014-09-02 17:59:56 +00:00
warner self-assigned this 2014-09-02 17:59:56 +00:00
Brian Warner <warner@lothar.com> commented 2014-09-02 20:36:17 +00:00
Author
Owner

In /tahoe-lafs/trac-2024-07-25/commit/45adde71808bc27d41b5bc77a963184957e9b247:

publish.py: log roothash in base32, not binary

Closes ticket:1800
In [/tahoe-lafs/trac-2024-07-25/commit/45adde71808bc27d41b5bc77a963184957e9b247](/tahoe-lafs/trac-2024-07-25/commit/45adde71808bc27d41b5bc77a963184957e9b247): ``` publish.py: log roothash in base32, not binary Closes ticket:1800 ```
tahoe-lafs added the
fixed
label 2014-09-02 20:36:17 +00:00
Brian Warner <warner@lothar.com> closed this issue 2014-09-02 20:36:17 +00:00
Sign in to join this conversation.
No Milestone
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Reference: tahoe-lafs/trac-2024-07-25#1800
No description provided.