make test-clean gives false alarms #180

New Issue

zooko · 2007-10-15T18:32:10Z

zooko commented

2007-10-15 18:32:10 +00:00

This seems like a trivial problem to fix, but I can't figure out which trivial fix is the right one, so I'm opening this ticket. The problem is that make test-clean turns the buildbot red if new Python files have been added, e.g. http://allmydata.org/buildbot/builders/clean/builds/414

One trivial fix would be to make && make clean before beginning the test, but that would allow uncleaned messes to pass the test. Another would be to exclude *.pyc files from consideration, which raises the question of whether we should exclude all of the .darcs-boringfile regexes from consideration, which raises the question of whether we shouldn't make test-clean be a Python script like test-darcs-boringfile is instead of a GNUmake script, which raises issue #179. ;-)

This seems like a trivial problem to fix, but I can't figure out which trivial fix is the right one, so I'm opening this ticket. The problem is that `make test-clean` turns the buildbot red if new Python files have been added, e.g. <http://allmydata.org/buildbot/builders/clean/builds/414> One trivial fix would be to `make && make clean` before beginning the test, but that would allow uncleaned messes to pass the test. Another would be to exclude *.pyc files from consideration, which raises the question of whether we should exclude all of the .darcs-boringfile regexes from consideration, which raises the question of whether we shouldn't make `test-clean` be a Python script like `test-darcs-boringfile` is instead of a GNUmake script, which raises issue #179. ;-)

zooko added the

labels 2007-10-15 18:32:10 +00:00

zooko added this to the 0.7.0 milestone 2007-10-15 18:32:10 +00:00

zooko commented

2007-10-15 20:50:25 +00:00

Brian helped me realize that the reason this cruft is appearing is that the new find_trial.py script gets executed whenever the Makefile gets evaluated. After he gets back from lunch he'll probably refactor it to execute find_trial.py only in a make command and thus fix this ticket...