type error in ServerMap.copy? #1785

New Issue

tahoe-lafs · 2012-07-02T19:19:36Z

davidsarah commented

2012-07-02 19:19:36 +00:00

[ServerMap]source:src/allmydata/mutable/servermap.py@5478#L122 has an update_data attribute that is not set on the copy returned by ServerMap.copy. I don't know whether this case is ever exercised.

[ServerMap]source:src/allmydata/mutable/servermap.py@5478#L122 has an `update_data` attribute that is not set on the copy returned by `ServerMap.copy`. I don't know whether this case is ever exercised.

tahoe-lafs added the

labels 2012-07-02 19:19:36 +00:00

tahoe-lafs added this to the 1.10.0 milestone 2012-07-02 19:19:36 +00:00

warner commented

2013-04-04 16:37:21 +00:00

Our plan is to add:

        s.update_data = copy.deepcopy(self.update_data)

to line 136 in mutable/servermap.py.

It's probably unused, and the update_data contains only inert data (e.g. no IServer references), so it should be safe, and should protect us from future confusion.

Our plan is to add: ``` s.update_data = copy.deepcopy(self.update_data) ``` to line 136 in `mutable/servermap.py`. It's probably unused, and the `update_data` contains only inert data (e.g. no `IServer` references), so it should be safe, and should protect us from future confusion.

Brian Warner <warner@lothar.com> commented

2013-04-09 11:27:32 +00:00

In changeset:4751a468408d8cc8:

ServerMap.copy(): deepcopy .update_data too. Closes #1785.

This was apparently unused, but good to copy for completeness. Tests
pass with and without the change.

In changeset:4751a468408d8cc8: ``` ServerMap.copy(): deepcopy .update_data too. Closes #1785. This was apparently unused, but good to copy for completeness. Tests pass with and without the change. ```

tahoe-lafs added the

fixed

label 2013-04-09 11:27:32 +00:00

tahoe-lafs closed this issue

2013-04-09 11:27:32 +00:00

daira commented

2013-04-10 01:58:54 +00:00

Reviewed, +1.

Sign in to join this conversation.