tahoe-lafs/trac-2024-07-25
2
0
Issues 1.1k Wiki

add happiness count to check and repair reports #1784

New Issue
Closed
opened 2012-07-01 17:16:38 +00:00 by davidsarah · 14 comments
davidsarah commented 2012-07-01 17:16:38 +00:00
Owner
Copy Link

I have a patch for this to go in 1.10 1.11. Note that the description of #1115 said "add servers-of-happiness to reports", and we agreed to do that, but the patch applied for #1115 only fixed a bug in computing count-good-share-hosts.

I have a patch for this to go in ~~1.10~~ 1.11. Note that the description of #1115 said "add servers-of-happiness to reports", and we agreed to do that, but the patch applied for #1115 only fixed a bug in computing `count-good-share-hosts`.
tahoe-lafs added the
code-frontend-web
normal
defect
1.9.1
 labels 2012-07-01 17:16:38 +00:00
tahoe-lafs added this to the 1.10.0 milestone 2012-07-01 17:16:38 +00:00
tahoe-lafs changed title from add servers-of-happiness to check reports to add happiness count to check reports 2012-07-01 17:18:16 +00:00
david-sarah@jacaranda.org commented 2012-07-01 23:10:16 +00:00
Author
Owner
Copy Link

In changeset:5532/1.9.2:

[1.9.2 branch] Add comments and a caveat in webapi.rst indicating that the needs-rebalancing field may be computed incorrectly. refs #1115 refs #1784
In changeset:5532/1.9.2: ``` [1.9.2 branch] Add comments and a caveat in webapi.rst indicating that the needs-rebalancing field may be computed incorrectly. refs #1115 refs #1784 ```
david-sarah@jacaranda.org commented 2012-07-16 16:33:55 +00:00
Author
Owner
Copy Link

In changeset:5886/cloud-backend:

[1.9.2 branch] Add comments and a caveat in webapi.rst indicating that the needs-rebalancing field may be computed incorrectly. refs #1115 refs #1784
In changeset:5886/cloud-backend: ``` [1.9.2 branch] Add comments and a caveat in webapi.rst indicating that the needs-rebalancing field may be computed incorrectly. refs #1115 refs #1784 ```
tahoe-lafs modified the milestone from 1.10.0 to 1.11.0 2013-03-26 05:43:41 +00:00
Daira Hopwood <david-sarah@jacaranda.org> commented 2013-04-18 22:50:13 +00:00
Author
Owner
Copy Link

In changeset:b06f8cd8d03a6239:

Add comments and a caveat in webapi.rst indicating that
the needs-rebalancing field may be computed incorrectly. refs #1115, #1784, #1477

Signed-off-by: Daira Hopwood <david-sarah@jacaranda.org>
In changeset:b06f8cd8d03a6239: ``` Add comments and a caveat in webapi.rst indicating that the needs-rebalancing field may be computed incorrectly. refs #1115, #1784, #1477 Signed-off-by: Daira Hopwood <david-sarah@jacaranda.org> ```
daira commented 2013-04-18 23:02:49 +00:00
Author
Owner
Copy Link

Copying this from /tahoe-lafs/trac-2024-07-25/issues/6177#comment:27, with minor updates:

... the value of needs-rebalancing is computed inconsistently between checker.py and filenode.py. In checker.py it is computed as:

# The file needs rebalancing if the set of servers that have at least
# one share is less than the number of uniquely-numbered shares
# available.
# TODO: this may be wrong, see ticket #1115 comment:27 and ticket #1784.
needs_rebalancing = bool(good_share_hosts < len(verifiedshares))

In filenode.py it is computed as

# TODO: this may be wrong, see ticket #1115 comment:27 and ticket #1784.
needs_rebalancing = bool(len(sm) >= verifycap.total_shares)

where len(sm) is equal to count-shares-good. I don't understand this latter definition at all, it looks completely wrong. The definition in checker.py is more subtly wrong because it credits servers that only have duplicated shares as contributing to existing balance. The correct definition should be something like 'iff the happiness count is less than the number of uniquely-numbered good shares available'.

I propose to change filenode.py and checker.py to be consistent, and to both use the happiness-based definition above.

Copying this from [/tahoe-lafs/trac-2024-07-25/issues/6177](/tahoe-lafs/trac-2024-07-25/issues/6177)#comment:27, with minor updates: ... the value of `needs-rebalancing` is computed inconsistently between `checker.py` and `filenode.py`. In `checker.py` it is computed as: ``` # The file needs rebalancing if the set of servers that have at least # one share is less than the number of uniquely-numbered shares # available. # TODO: this may be wrong, see ticket #1115 comment:27 and ticket #1784. needs_rebalancing = bool(good_share_hosts < len(verifiedshares)) ``` In `filenode.py` it is computed as ``` # TODO: this may be wrong, see ticket #1115 comment:27 and ticket #1784. needs_rebalancing = bool(len(sm) >= verifycap.total_shares) ``` where `len(sm)` is equal to `count-shares-good`. I don't understand this latter definition at all, it looks completely wrong. The definition in `checker.py` is more subtly wrong because it credits servers that only have duplicated shares as contributing to existing balance. The correct definition should be something like 'iff the happiness count is less than the number of uniquely-numbered good shares available'. I propose to change `filenode.py` and `checker.py` to be consistent, and to both use the happiness-based definition above.
tahoe-lafs changed title from add happiness count to check reports to add happiness count to check reports and fix the definition of needs-rebalancing 2013-04-18 23:04:32 +00:00
zooko commented 2013-04-20 14:59:33 +00:00
Copy Link

See also #614

See also #614
daira commented 2013-11-14 17:37:36 +00:00
Author
Owner
Copy Link

This should probably be split into two tickets: one for adding the happiness outcome to reports and one for fixing needs-rebalancing.

This should probably be split into two tickets: one for adding the happiness outcome to reports and one for fixing `needs-rebalancing`.
tahoe-lafs changed title from add happiness count to check reports and fix the definition of needs-rebalancing to add happiness count to check and repair reports, and fix the definition of needs-rebalancing 2013-11-14 17:37:36 +00:00
daira commented 2013-11-14 17:44:57 +00:00
Author
Owner
Copy Link

The needs-rebalancing issue has been split to #2105.

The `needs-rebalancing` issue has been split to #2105.
tahoe-lafs changed title from add happiness count to check and repair reports, and fix the definition of needs-rebalancing to add happiness count to check and repair reports 2013-11-14 17:44:57 +00:00
daira commented 2013-12-05 18:30:10 +00:00
Author
Owner
Copy Link

(https://github.com/tahoe-lafs/tahoe-lafs/pull/74) implements this ticket and #2105.

(https://github.com/tahoe-lafs/tahoe-lafs/pull/74) implements this ticket and #2105.
remyroy commented 2014-03-20 15:35:32 +00:00
Author
Owner
Copy Link

Review included in #2105 since they both are in the same pull request/patch.

Review included in #2105 since they both are in the same pull request/patch.
Daira Hopwood <daira@jacaranda.org> commented 2014-03-20 16:21:14 +00:00
Author
Owner
Copy Link

In /tahoe-lafs/trac-2024-07-25/commit/0ef593947755a8b81edc73d033219724268faf80:

Remove 'needs-rebalancing' and add 'count-happiness' to checker reports; repair tests. fixes #1784, #2105

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
In [/tahoe-lafs/trac-2024-07-25/commit/0ef593947755a8b81edc73d033219724268faf80](/tahoe-lafs/trac-2024-07-25/commit/0ef593947755a8b81edc73d033219724268faf80): ``` Remove 'needs-rebalancing' and add 'count-happiness' to checker reports; repair tests. fixes #1784, #2105 Signed-off-by: Daira Hopwood <daira@jacaranda.org> ```
tahoe-lafs added the
fixed
 label 2014-03-20 16:21:14 +00:00
Daira Hopwood <daira@jacaranda.org> closed this issue 2014-03-20 16:21:14 +00:00
Daira Hopwood <daira@jacaranda.org> commented 2014-03-27 22:15:02 +00:00
Author
Owner
Copy Link

In /tahoe-lafs/trac-2024-07-25/commit/0ef593947755a8b81edc73d033219724268faf80:

Remove 'needs-rebalancing' and add 'count-happiness' to checker reports; repair tests. fixes #1784, #2105

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
In [/tahoe-lafs/trac-2024-07-25/commit/0ef593947755a8b81edc73d033219724268faf80](/tahoe-lafs/trac-2024-07-25/commit/0ef593947755a8b81edc73d033219724268faf80): ``` Remove 'needs-rebalancing' and add 'count-happiness' to checker reports; repair tests. fixes #1784, #2105 Signed-off-by: Daira Hopwood <daira@jacaranda.org> ```
Daira Hopwood <daira@jacaranda.org> commented 2014-03-29 00:19:00 +00:00
Author
Owner
Copy Link

In /tahoe-lafs/trac-2024-07-25/commit/0ef593947755a8b81edc73d033219724268faf80:

Remove 'needs-rebalancing' and add 'count-happiness' to checker reports; repair tests. fixes #1784, #2105

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
In [/tahoe-lafs/trac-2024-07-25/commit/0ef593947755a8b81edc73d033219724268faf80](/tahoe-lafs/trac-2024-07-25/commit/0ef593947755a8b81edc73d033219724268faf80): ``` Remove 'needs-rebalancing' and add 'count-happiness' to checker reports; repair tests. fixes #1784, #2105 Signed-off-by: Daira Hopwood <daira@jacaranda.org> ```
Daira Hopwood <daira@jacaranda.org> commented 2014-03-29 00:43:09 +00:00
Author
Owner
Copy Link

In /tahoe-lafs/trac-2024-07-25/commit/0ef593947755a8b81edc73d033219724268faf80:

Remove 'needs-rebalancing' and add 'count-happiness' to checker reports; repair tests. fixes #1784, #2105

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
In [/tahoe-lafs/trac-2024-07-25/commit/0ef593947755a8b81edc73d033219724268faf80](/tahoe-lafs/trac-2024-07-25/commit/0ef593947755a8b81edc73d033219724268faf80): ``` Remove 'needs-rebalancing' and add 'count-happiness' to checker reports; repair tests. fixes #1784, #2105 Signed-off-by: Daira Hopwood <daira@jacaranda.org> ```
Daira Hopwood <daira@jacaranda.org> commented 2014-03-29 00:56:06 +00:00
Author
Owner
Copy Link

In /tahoe-lafs/trac-2024-07-25/commit/0ef593947755a8b81edc73d033219724268faf80:

Remove 'needs-rebalancing' and add 'count-happiness' to checker reports; repair tests. fixes #1784, #2105

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
In [/tahoe-lafs/trac-2024-07-25/commit/0ef593947755a8b81edc73d033219724268faf80](/tahoe-lafs/trac-2024-07-25/commit/0ef593947755a8b81edc73d033219724268faf80): ``` Remove 'needs-rebalancing' and add 'count-happiness' to checker reports; repair tests. fixes #1784, #2105 Signed-off-by: Daira Hopwood <daira@jacaranda.org> ```
zooko modified the milestone from soon to 1.11.0 2014-04-14 23:06:42 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
0.2.0

   
0.3.0

   
0.4.0

   
0.5.0

   
0.5.1

   
0.6.0

   
0.6.1

   
0.7.0

   
0.8.0

   
0.9.0

   
1.0.0

   
1.1.0

   
1.10.0

   
1.10.1

   
1.10.2

   
1.10a2

   
1.11.0

   
1.12.0

   
1.12.1

   
1.13.0

   
1.14.0

   
1.15.0

   
1.15.1

   
1.2.0

   
1.3.0

   
1.4.1

   
1.5.0

   
1.6.0

   
1.6.1

   
1.7.0

   
1.7.1

   
1.7β

   
1.8.0

   
1.8.1

   
1.8.2

   
1.8.3

   
1.8β

   
1.9.0

   
1.9.0-s3branch

   
1.9.0a1

   
1.9.0a2

   
1.9.0b1

   
1.9.1

   
1.9.2

   
1.9.2a1

   
LeastAuthority.com automation

   
blocker

   
cannot reproduce

   
cloud-branch

   
code

catch-all for anything that can be fixed by writing code but isn't classified better

  
code-dirnodes

anything involving tahoe directories

  
code-encoding

immutable-file encoding format/layout, cap format, encoding/decoding algorithms

  
code-frontend

general frontend things: new user-facing interfaces, FTP/SFTP servers, FUSE-like interfaces

  
code-frontend-cli

CLI tools

  
code-frontend-ftp-sftp

   
code-frontend-magic-folder

   
code-frontend-web

webapi interfaces, user-facing "WUI" interfaces

  
code-mutable

anything involving mutable files: encoding/decoding, share format

  
code-network

Introducer, locating storage servers, establishing/maintaining connections to them

  
code-nodeadmin

node startup/shutdown, tools to create nodes, logging tools, management/monitoring tools, manhole, disk-space-limiting tools

  
code-peerselection

server selection/sorting algorithm, rebalancing code, allocation policy, swarming-download

  
code-storage

storage-server implementation, share-storage directory layout, client-to-server share transfer protocol

  
contrib

problems with non-core things that live in the source:contrib/ directory

  
critical

   
defect

   
dev-infrastructure

things that help us build Tahoe: buildbot, automated speed/memory/code-coverage tests and results-displayers, IRC channels, mailing lists, this Trac instance

  
documentation

docs items. Also use 'docs' keyword on tickets in more specific components.

  
duplicate

   
enhancement

   
fixed

   
invalid

   
major

   
minor

   
n/a

   
normal

   
operational

things involved in running a tahoe grid, external tools to monitor/maintain a grid (like "nodeadmin" but larger-scale). Was also used for issues with the allmydata.com grid.

  
packaging

setup.py script, library dependencies, binary packages, licensing, installation instructions

  
somebody else's problem

   
supercritical

   
task

   
trivial

   
unknown

Uncategorized. All tickets default to this component until someone updates it.

  
was already fixed

   
website

things about the tahoe-lafs.org website (and sometimes this Trac instance, shared with 'dev-infrastructure')

  
wontfix

   
worksforme
No Label
0.2.0
0.3.0
0.4.0
0.5.0
0.5.1
0.6.0
0.6.1
0.7.0
0.8.0
0.9.0
1.0.0
1.1.0
1.10.0
1.10.1
1.10.2
1.10a2
1.11.0
1.12.0
1.12.1
1.13.0
1.14.0
1.15.0
1.15.1
1.2.0
1.3.0
1.4.1
1.5.0
1.6.0
1.6.1
1.7.0
1.7.1
1.7β
1.8.0
1.8.1
1.8.2
1.8.3
1.8β
1.9.0
1.9.0-s3branch
1.9.0a1
1.9.0a2
1.9.0b1
1.9.1
1.9.2
1.9.2a1
LeastAuthority.com automation
blocker
cannot reproduce
cloud-branch
code
code-dirnodes
code-encoding
code-frontend
code-frontend-cli
code-frontend-ftp-sftp
code-frontend-magic-folder
code-frontend-web
code-mutable
code-network
code-nodeadmin
code-peerselection
code-storage
contrib
critical
defect
dev-infrastructure
documentation
duplicate
enhancement
fixed
invalid
major
minor
n/a
normal
operational
packaging
somebody else's problem
supercritical
task
trivial
unknown
was already fixed
website
wontfix
worksforme
Milestone
Clear milestone
No items
No Milestone
1.10.1
Assignees
Clear assignees
No Assignees
zooko
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Reference: tahoe-lafs/trac-2024-07-25#1784
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?