default maximum-immutable-share-size is probably off-by-one #1781

New Issue

tahoe-lafs · 2012-06-23T23:39:18Z

davidsarah commented

2012-06-23 23:39:18 +00:00

At source:src/allmydata/storage_client.py#L181:

"maximum-immutable-share-size": 2**32,

I think this is the default used for old servers that didn't explicitly declare a maximum immutable share size, and that it should really be 2^32^ - 1.

At source:src/allmydata/storage_client.py#L181: ``` "maximum-immutable-share-size": 2**32, ``` I think this is the default used for old servers that didn't explicitly declare a maximum immutable share size, and that it should really be 2^32^ - 1.

tahoe-lafs added the

labels 2012-06-23 23:39:18 +00:00

tahoe-lafs added this to the 1.10.0 milestone 2012-06-23 23:39:18 +00:00

warner commented

2013-03-21 00:12:53 +00:00

I agree. I'm going to change it after we release 1.10.

warner modified the milestone from 1.10.0 to 1.11.0

2013-03-21 00:12:53 +00:00

davidsarah commented

2013-03-23 02:41:28 +00:00

If we agree this change is correct, it can't hurt to change it now, right? It seems to have very low regression risk.

davidsarah commented

2013-03-23 03:12:46 +00:00

https://github.com/davidsarah/tahoe-lafs/commit/1781-maximum-immutable-share-size

Does this need a test?

<https://github.com/davidsarah/tahoe-lafs/commit/1781-maximum-immutable-share-size> Does this need a test?

warner was assigned by tahoe-lafs

2013-03-23 03:13:50 +00:00

David-Sarah Hopwood <david-sarah@jacaranda.org> commented

2013-03-23 18:07:20 +00:00

In changeset:68b7f9e979158dcb:

Correct off-by-one in maximum-immutable-share-size for old servers. fixes #1781

Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org>

In changeset:68b7f9e979158dcb: ``` Correct off-by-one in maximum-immutable-share-size for old servers. fixes #1781 Signed-off-by: David-Sarah Hopwood <david-sarah@jacaranda.org> ```

tahoe-lafs added the

fixed

label 2013-03-23 18:07:20 +00:00

tahoe-lafs closed this issue

2013-03-23 18:07:20 +00:00

warner commented

2013-03-23 18:07:59 +00:00

nope, no test needed. I've landed it for 1.10. Thanks!

warner modified the milestone from 1.11.0 to 1.10.0

2013-03-23 18:07:59 +00:00

Sign in to join this conversation.