cleanups to backupdb tests #1777

New Issue

zooko · 2012-06-22T02:57:20Z

zooko commented

2012-06-22 02:57:20 +00:00

This cleanup patch removes complexity in the backupdb tests that was caused by needing to handle the case where pysqlite is not available. We now depend on Python 2.5 which includes pysqlite in the standard lib.

zooko added the

labels 2012-06-22 02:57:20 +00:00

zooko added this to the 1.10.0 milestone 2012-06-22 02:57:20 +00:00

zooko commented

2012-06-22 02:58:48 +00:00

Attachment no-tests-of-backup-without-sqlite.darcs.patch (110496 bytes) added

**Attachment** no-tests-of-backup-without-sqlite.darcs.patch (110496 bytes) added

no-tests-of-backup-without-sqlite.darcs.patch

108 KiB

zooko commented

2012-06-22 02:59:11 +00:00

I intend to attach more patches as I generate them.

davidsarah commented

2012-09-04 23:20:21 +00:00

Reviewed. Please check it applies/tests cleanly and land it for 1.10.

The description of this ticket was really vague and not specific to the attached patch. One ticket per batch of closely related cleanups, please!

Reviewed. Please check it applies/tests cleanly and land it for 1.10. The description of this ticket was really vague and not specific to the attached patch. One ticket per batch of closely related cleanups, please!

tahoe-lafs added

code-frontend

and removed

unknown

labels 2012-09-04 23:20:21 +00:00

tahoe-lafs changed title from ~~cleanups to tests and mutables for 1.10~~ to cleanups to backupdb tests

2012-09-04 23:20:21 +00:00

davidsarah commented

2012-10-26 01:27:09 +00:00

Needs rerecording in git.

tahoe-lafs added

normal

and removed

minor

labels 2012-12-13 17:25:31 +00:00

warner commented

2012-12-20 17:59:36 +00:00

I'll land this.

zooko was unassigned by warner

2012-12-20 17:59:36 +00:00

warner self-assigned this 2012-12-20 17:59:36 +00:00

davidsarah commented

2013-01-02 02:28:21 +00:00

An equivalent change was already made in changeset:a1a1b5bf8a6e1a09.

That commit, although made before 1.9.2 was released, was not in the 1.9.2 branch (which is unsurprising since it is a cleanup and 1.9.2 was a point release), so 1.10 will be the first release to have it.

An equivalent change was already made in changeset:a1a1b5bf8a6e1a09. That commit, although made before 1.9.2 was released, was [not in the 1.9.2 branch](https://tahoe-lafs.org/trac/tahoe-lafs/browser/1.9.2/src/allmydata/test/test_cli.py#L2397) (which is unsurprising since it is a cleanup and 1.9.2 was a point release), so 1.10 will be the first release to have it.

tahoe-lafs added the

fixed

label 2013-01-02 02:28:21 +00:00

tahoe-lafs closed this issue

2013-01-02 02:28:21 +00:00

Sign in to join this conversation.