classes in different modules shouldn't have the same name, it's confusing #1705

New Issue

tahoe-lafs · 2012-04-03T02:41:25Z

davidsarah commented

2012-04-03 02:41:25 +00:00

E.g.

$ grep -Rn 'class CheckAndRepairResults' src
src/allmydata/web/check_results.py:272:class CheckAndRepairResults(CheckerBase, rend.Page, ResultsBase):
src/allmydata/check_results.py:74:class CheckAndRepairResults:

E.g. ``` $ grep -Rn 'class CheckAndRepairResults' src src/allmydata/web/check_results.py:272:class CheckAndRepairResults(CheckerBase, rend.Page, ResultsBase): src/allmydata/check_results.py:74:class CheckAndRepairResults: ```

tahoe-lafs added the

labels 2012-04-03 02:41:25 +00:00

tahoe-lafs added this to the undecided milestone 2012-04-03 02:41:25 +00:00

warner commented

2012-04-03 02:50:02 +00:00

Attachment rename.diff (7973 bytes) added

rename the web side to -Renderer

**Attachment** rename.diff (7973 bytes) added rename the web side to -Renderer

rename.diff

7.8 KiB

davidsarah commented

2012-04-03 03:03:44 +00:00

Looks good, thanks! (I didn't check that all uses were renamed, but pyflakes will do that.)

tahoe-lafs modified the milestone from undecided to 1.9.2

2012-04-03 03:03:44 +00:00

Brian Warner <warner@lothar.com> commented

2012-04-03 03:06:04 +00:00

In changeset:bf390cca4b51cfef:

Rename web CheckResults to -Renderer, to avoid confusion. Closes #1705.

This avoids the name collision between the actual results
objects (defined in allmydata.check_results) and the code that renders
these objects into HTML (defined in allmydata.web.check_results). Only
the web-side objects were renamed.

In changeset:bf390cca4b51cfef: ``` Rename web CheckResults to -Renderer, to avoid confusion. Closes #1705. This avoids the name collision between the actual results objects (defined in allmydata.check_results) and the code that renders these objects into HTML (defined in allmydata.web.check_results). Only the web-side objects were renamed. ```

tahoe-lafs added the

fixed

label 2012-04-03 03:06:04 +00:00

tahoe-lafs closed this issue

2012-04-03 03:06:04 +00:00

Brian Warner <warner@lothar.com> commented

2012-04-03 03:06:31 +00:00

In changeset:bf390cca4b51cfef:

Rename web CheckResults to -Renderer, to avoid confusion. Closes #1705.

This avoids the name collision between the actual results
objects (defined in allmydata.check_results) and the code that renders
these objects into HTML (defined in allmydata.web.check_results). Only
the web-side objects were renamed.

In changeset:bf390cca4b51cfef: ``` Rename web CheckResults to -Renderer, to avoid confusion. Closes #1705. This avoids the name collision between the actual results objects (defined in allmydata.check_results) and the code that renders these objects into HTML (defined in allmydata.web.check_results). Only the web-side objects were renamed. ```

Sign in to join this conversation.