fix bugs found by 'check-miscaptures' script #1556

New Issue

Note that this is wanted for 1.9beta; the changes in source:src/allmydata/mutable/servermap.py are to fix bugs introduced by MDMF in changeset changeset:bb10d685ed86eb08, so potential regressions.

david-sarah@jacaranda.org commented

2011-10-07 19:39:47 +00:00

In [5396/ticket999-S3-backend]:

misc/simulators/hashbasedsig.py: simplify by removing unnecessary local function that captured a variable declared in a for loop (this was not a bug, but the code was unclear). Also fix a pyflakes warning about an import. refs #1556

In [5396/ticket999-S3-backend]: ``` misc/simulators/hashbasedsig.py: simplify by removing unnecessary local function that captured a variable declared in a for loop (this was not a bug, but the code was unclear). Also fix a pyflakes warning about an import. refs #1556 ```

david-sarah@jacaranda.org commented

2011-10-07 19:39:48 +00:00

In [5397/ticket999-S3-backend]:

Fix some potential bugs in test code exposed by check-miscaptures.py. refs #1556

In [5397/ticket999-S3-backend]: ``` Fix some potential bugs in test code exposed by check-miscaptures.py. refs #1556 ```

david-sarah@jacaranda.org commented

2011-10-07 19:39:48 +00:00

In [5398/ticket999-S3-backend]:

Fix some potential bugs (in non-test code) exposed by check-miscaptures.py. refs #1556

In [5398/ticket999-S3-backend]: ``` Fix some potential bugs (in non-test code) exposed by check-miscaptures.py. refs #1556 ```

david-sarah@jacaranda.org commented

2011-10-07 19:39:48 +00:00

In [5399/ticket999-S3-backend]:

Fix some more potential bugs in test code exposed by check-miscaptures.py. refs #1556

In [5399/ticket999-S3-backend]: ``` Fix some more potential bugs in test code exposed by check-miscaptures.py. refs #1556 ```

davidsarah commented

2011-10-09 19:26:02 +00:00

Attachment 1556-suppress-warnings.darcs.patch (25065 bytes) added

Fix false positives.

**Attachment** 1556-suppress-warnings.darcs.patch (25065 bytes) added Fix false positives.

1556-suppress-warnings.darcs.patch

24 KiB

david-sarah@jacaranda.org commented

2011-10-10 19:53:52 +00:00

In changeset:bc0d9b682e97c26d:

misc/simulators/hashbasedsig.py: simplify by removing unnecessary local function that captured a variable declared in a for loop (this was not a bug, but the code was unclear). Also fix a pyflakes warning about an import. refs #1556

In changeset:bc0d9b682e97c26d: ``` misc/simulators/hashbasedsig.py: simplify by removing unnecessary local function that captured a variable declared in a for loop (this was not a bug, but the code was unclear). Also fix a pyflakes warning about an import. refs #1556 ```

david-sarah@jacaranda.org commented

2011-10-12 21:47:36 +00:00

In [5435/ticket999-S3-backend]:

misc/coding_tools/make-canary-files.py: fix a suspicious capture reported by check-miscaptures (although it happens not to be a bug because the callback will be processed synchronously). refs #1556

In [5435/ticket999-S3-backend]: ``` misc/coding_tools/make-canary-files.py: fix a suspicious capture reported by check-miscaptures (although it happens not to be a bug because the callback will be processed synchronously). refs #1556 ```

david-sarah@jacaranda.org commented

2011-10-12 21:47:39 +00:00

In [5436/ticket999-S3-backend]:

util/happinessutil.py: suppress a warning from check-miscaptures. (It is not a bug because the capturing function is only used by a 'map' in the same iteration.) refs #1556

In [5436/ticket999-S3-backend]: ``` util/happinessutil.py: suppress a warning from check-miscaptures. (It is not a bug because the capturing function is only used by a 'map' in the same iteration.) refs #1556 ```

david-sarah@jacaranda.org commented

2011-10-13 16:55:38 +00:00

In changeset:11ce612589cefd1f:

Fix some potential bugs in test code exposed by check-miscaptures.py. refs #1556

In changeset:11ce612589cefd1f: ``` Fix some potential bugs in test code exposed by check-miscaptures.py. refs #1556 ```

david-sarah@jacaranda.org commented

2011-10-13 16:55:38 +00:00

In changeset:bdfa7b377226ffb5:

Fix some potential bugs (in non-test code) exposed by check-miscaptures.py. refs #1556

In changeset:bdfa7b377226ffb5: ``` Fix some potential bugs (in non-test code) exposed by check-miscaptures.py. refs #1556 ```

david-sarah@jacaranda.org commented

2011-10-13 16:55:38 +00:00

In changeset:a31a701e42d46083:

Fix some more potential bugs in test code exposed by check-miscaptures.py. refs #1556

In changeset:a31a701e42d46083: ``` Fix some more potential bugs in test code exposed by check-miscaptures.py. refs #1556 ```

david-sarah@jacaranda.org commented

2011-10-13 16:55:39 +00:00

In changeset:22da015dd1f63e24:

misc/coding_tools/make-canary-files.py: fix a suspicious capture reported by check-miscaptures (although it happens not to be a bug because the callback will be processed synchronously). refs #1556

In changeset:22da015dd1f63e24: ``` misc/coding_tools/make-canary-files.py: fix a suspicious capture reported by check-miscaptures (although it happens not to be a bug because the callback will be processed synchronously). refs #1556 ```

david-sarah@jacaranda.org commented

2011-10-13 16:55:39 +00:00

In changeset:3142538b0d4dd354:

util/happinessutil.py: suppress a warning from check-miscaptures. (It is not a bug because the capturing function is only used by a 'map' in the same iteration.) refs #1556

In changeset:3142538b0d4dd354: ``` util/happinessutil.py: suppress a warning from check-miscaptures. (It is not a bug because the capturing function is only used by a 'map' in the same iteration.) refs #1556 ```

warner commented

2011-10-13 16:56:42 +00:00

those look safe.. landed to trunk for 1.9. Are there others remaining, or can we close this ticket?

tahoe-lafs added the

fixed

label 2011-10-13 19:41:00 +00:00

tahoe-lafs closed this issue

2011-10-13 19:41:00 +00:00

Sign in to join this conversation.