iputil returns 0.0.0.0 #153

Closed
opened 2007-09-29 04:44:28 +00:00 by zooko · 5 comments

I thought I was supposed to fix this, but I just saw it on cygwin.

Leaving this ticket here for myself to come back to it after I demo Tahoe to Seb.

I thought I was supposed to fix this, but I just saw it on cygwin. Leaving this ticket here for myself to come back to it after I demo Tahoe to Seb.
zooko added the
code-network
minor
defect
0.6.0
labels 2007-09-29 04:44:28 +00:00
zooko added this to the 0.6.1 milestone 2007-09-29 04:44:28 +00:00
zooko self-assigned this 2007-09-29 04:44:28 +00:00
Author

Correction: it is the Solaris version of iputil that returns 0.0.0.0. The cygwin version doesn't.

Correction: it is the Solaris version of iputil that returns 0.0.0.0. The cygwin version doesn't.
Author

So, if I just make iputil filter out all IP addresses that end in ".0", this will solve this issue, right? Is there any other filtering or munging that I should do?

So, if I just make iputil filter out all IP addresses that end in ".0", this will solve this issue, right? Is there any other filtering or munging that I should do?
Author

(Note that iputil is intended to return non-routeable, private IP addresses, because foolscap can use those if both ends are on the same network and foolscap isn't harmed by them.)

(Note that iputil is intended to return non-routeable, private IP addresses, because foolscap can use those if both ends are on the same network and foolscap isn't harmed by them.)

actually, just filter out 0.0.0.0 . There are valid addresses that end in .0 (any subnet larger than /24 will have some host addresses that have 0 as a last octet).

0.0.0.0 is well-defined as a special "INADDR_ANY" address, and is never valid as a host address. So just filter out that one case.

actually, just filter out 0.0.0.0 . There are valid addresses that end in .0 (any subnet larger than /24 will have some host addresses that have 0 as a last octet). 0.0.0.0 is well-defined as a special "INADDR_ANY" address, and is never valid as a host address. So just filter out that one case.
Author

Fixed by changeset:af0edec753033339.

Fixed by changeset:af0edec753033339.
zooko added the
fixed
label 2007-10-13 06:38:50 +00:00
zooko closed this issue 2007-10-13 06:38:50 +00:00
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Reference: tahoe-lafs/trac-2024-07-25#153
No description provided.