more precise progress indication for MDMF retrieve #1515

New Issue

tahoe-lafs · 2011-08-29T14:47:44Z

davidsarah commented

2011-08-29 14:47:44 +00:00

From the commit message for changeset:9756146d61673552:

More improvements to consider:

progress is currently 0% or 100%: should calculate how many segments are involved (remembering retrieve can be less than the whole file) and set it to a fraction
"fetch" time is fuzzy: what we want is to know how much of the delay is not our own fault, but since we do decode/decrypt work while waiting for more shares, it's not straightforward

From the commit message for changeset:9756146d61673552: More improvements to consider: * progress is currently 0% or 100%: should calculate how many segments are involved (remembering retrieve can be less than the whole file) and set it to a fraction * "fetch" time is fuzzy: what we want is to know how much of the delay is not our own fault, but since we do decode/decrypt work while waiting for more shares, it's not straightforward

tahoe-lafs added the

labels 2011-08-29 14:47:44 +00:00

tahoe-lafs added this to the undecided milestone 2011-08-29 14:47:44 +00:00

tahoe-lafs added

code-mutable

and removed

code-frontend-web

labels 2011-08-29 14:48:29 +00:00

tahoe-lafs added

and removed

labels 2012-04-01 04:42:20 +00:00

warner commented

2015-08-18 17:01:03 +00:00

Yeah, mutable/retrieve.py currently only calls set_progress() twice: once with 0.0 at the start, and once with 1.0 at the end. This was correct for SDMF, but with MDMF we can make an update after each segment is finished downloading. The place to do this will be inside _decode_blocks(), in the _process() function, where it logs "now decoding segment X of Y". Basically add a set_progress(X/Y) there.

Yeah, mutable/retrieve.py currently only calls `set_progress()` twice: once with 0.0 at the start, and once with 1.0 at the end. This was correct for SDMF, but with MDMF we can make an update after each segment is finished downloading. The place to do this will be inside `_decode_blocks()`, in the `_process()` function, where it logs "now decoding segment X of Y". Basically add a `set_progress(X/Y)` there.

Sign in to join this conversation.