zero-length reads break new mutable downloader #1512

New Issue

warner · 2011-08-27T23:55:46Z

warner commented

2011-08-27 23:55:46 +00:00

The new mutable downloader, landed as part of MDMF in #393, has problems when asked to download zero bytes: it returns more than zero bytes.

We have tests in test_mutable.Version to catch this, currently disabled.

This is a blocker for 1.9beta

The new mutable downloader, landed as part of MDMF in #393, has problems when asked to download zero bytes: it returns more than zero bytes. We have tests in `test_mutable.Version` to catch this, currently disabled. This is a blocker for 1.9beta

warner added the

labels 2011-08-27 23:55:46 +00:00

warner added this to the 1.9.0 milestone 2011-08-27 23:55:46 +00:00

kevan commented

2011-08-30 21:09:41 +00:00

Attachment fix-zero-length-reads.darcspatch (10049 bytes) added

fix zero-length reads; enable tests of zero-length reads

**Attachment** fix-zero-length-reads.darcspatch (10049 bytes) added fix zero-length reads; enable tests of zero-length reads

fix-zero-length-reads.darcspatch

9.8 KiB

Kevan Carstensen <kevan@isnotajoke.com> commented

2011-08-31 05:10:23 +00:00

In changeset:32e30c9023479e3c:

mutable/retrieve: handle the case where self._read_length is 0.

Note that the downloader will still fetch a segment for a zero-length
read, which is wasteful. Fixing that isn't specifically required to fix
#1512, but it should probably be fixed before 1.9.

In changeset:32e30c9023479e3c: ``` mutable/retrieve: handle the case where self._read_length is 0. Note that the downloader will still fetch a segment for a zero-length read, which is wasteful. Fixing that isn't specifically required to fix #1512, but it should probably be fixed before 1.9. ```

tahoe-lafs added the

fixed

label 2011-08-31 05:10:23 +00:00

tahoe-lafs closed this issue

2011-08-31 05:10:23 +00:00

warner commented

2011-08-31 05:40:33 +00:00

I agree with the comment that it'd be nice to improve efficiency of zero-byte reads by not actually downloading any segments (I've opened #1518 to track that), but I'm not going to hold up 1.9 for that.. correctness is sufficient.

Sign in to join this conversation.