MDMF filecaps should tolerate extra parameters #1509

New Issue

warner · 2011-08-27T18:01:28Z

warner commented

2011-08-27 18:01:28 +00:00

The MDMF filecap format is currently defined as:

  URI:MDMF:$writekey:$fingerprint[(:$extension)*]

and all existing caps are created with two extension fields: the first is 'k' (as an integer), the second is segsize (also as an integer). The intention is to allow additional extension fields to be added in the future, perhaps hints that could speed up a download.

But I think I saw places in the code that fail if the number of extension fields is not either 0 or 2. These places should be fixed to tolerate 1, or 3, etc.

I'd like to have this in 1.9 because then 1.9 will be tolerant of caps generated by future versions that have a different number of extension fields.

The MDMF filecap format is currently defined as: ``` URI:MDMF:$writekey:$fingerprint[(:$extension)*] ``` and all existing caps are created with two extension fields: the first is 'k' (as an integer), the second is segsize (also as an integer). The intention is to allow additional extension fields to be added in the future, perhaps hints that could speed up a download. But I think I saw places in the code that fail if the number of extension fields is not either 0 or 2. These places should be fixed to tolerate 1, or 3, etc. I'd like to have this in 1.9 because then 1.9 will be tolerant of caps generated by future versions that have a different number of extension fields.