mutable-type should imply mutable in tahoe put #1506

Closed
opened 2011-08-26 20:01:56 +00:00 by kevan · 4 comments
kevan commented 2011-08-26 20:01:56 +00:00
Owner

Currently, if you do tahoe put --mutable-type=mdmf some_file, an immutable (CHK or LIT) file is created, since tahoe put only pays attention to the --mutable-type option if the --mutable option is also given. This is surprising; we should treat --mutable-type as implying --mutable. Then --mutable can be understood to mean "upload a mutable file using whatever the default mutable type is", and --mutable-type can be understood as a way to override that default.

(This improvement was suggested by davidsarah in #393, comment 141.)

Currently, if you do `tahoe put --mutable-type=mdmf some_file`, an immutable (CHK or LIT) file is created, since `tahoe put` only pays attention to the `--mutable-type` option if the `--mutable` option is also given. This is surprising; we should treat `--mutable-type` as implying `--mutable`. Then `--mutable` can be understood to mean "upload a mutable file using whatever the default mutable type is", and `--mutable-type` can be understood as a way to override that default. (This improvement was suggested by davidsarah in [#393, comment 141](http://tahoe-lafs.org/trac/tahoe-lafs/ticket/393#comment:141).)
tahoe-lafs added the
unknown
major
defect
1.9.0a1
labels 2011-08-26 20:01:56 +00:00
tahoe-lafs added this to the 1.9.0 milestone 2011-08-26 20:01:56 +00:00
tahoe-lafs added
code-frontend-cli
and removed
unknown
labels 2011-08-26 20:14:15 +00:00
kevan commented 2011-09-03 19:10:31 +00:00
Author
Owner

Attachment fix-mutable-type.darcspatch (9622 bytes) added

**Attachment** fix-mutable-type.darcspatch (9622 bytes) added
kevan commented 2011-09-03 19:15:51 +00:00
Author
Owner

fix-mutable-type.darcspatch includes a test for this issue and a fix that makes the test pass.

[fix-mutable-type.darcspatch](/tahoe-lafs/trac-2024-07-25/attachments/000078ac-9e0a-9162-15d9-379ad6c2833d) includes a test for this issue and a fix that makes the test pass.
davidsarah commented 2011-09-04 22:50:16 +00:00
Author
Owner

Reviewed and manually smoke-tested, +1.

Reviewed and manually smoke-tested, +1.
davidsarah commented 2011-09-05 02:05:40 +00:00
Author
Owner

Applied in changeset:64996a913d014b5f.

Applied in changeset:64996a913d014b5f.
tahoe-lafs added the
fixed
label 2011-09-05 02:05:40 +00:00
Sign in to join this conversation.
No Milestone
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Reference: tahoe-lafs/trac-2024-07-25#1506
No description provided.