Move ImmutableShare to backend specific module, add "backend" interface to Storage Server, use twisted's FilePath #1465
Labels
No Label
0.2.0
0.3.0
0.4.0
0.5.0
0.5.1
0.6.0
0.6.1
0.7.0
0.8.0
0.9.0
1.0.0
1.1.0
1.10.0
1.10.1
1.10.2
1.10a2
1.11.0
1.12.0
1.12.1
1.13.0
1.14.0
1.15.0
1.15.1
1.2.0
1.3.0
1.4.1
1.5.0
1.6.0
1.6.1
1.7.0
1.7.1
1.7β
1.8.0
1.8.1
1.8.2
1.8.3
1.8β
1.9.0
1.9.0-s3branch
1.9.0a1
1.9.0a2
1.9.0b1
1.9.1
1.9.2
1.9.2a1
LeastAuthority.com automation
blocker
cannot reproduce
cloud-branch
code
code-dirnodes
code-encoding
code-frontend
code-frontend-cli
code-frontend-ftp-sftp
code-frontend-magic-folder
code-frontend-web
code-mutable
code-network
code-nodeadmin
code-peerselection
code-storage
contrib
critical
defect
dev-infrastructure
documentation
duplicate
enhancement
fixed
invalid
major
minor
n/a
normal
operational
packaging
somebody else's problem
supercritical
task
trivial
unknown
was already fixed
website
wontfix
worksforme
No Milestone
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Reference: tahoe-lafs/trac-2024-07-25#1465
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Attachment nullpass_Zancas20110803.darcs.patch (88583 bytes) added
Patch bundle. TestServerWithNullBackend passes, and nothing else does
Attachment ALLpass_Zancas20110803.darcs.patch (132631 bytes) added
Hmmppphh... all tests pass
Attachment stillALLpass_Zancas20110803.darcs.patch (137808 bytes) added
additional changes unnecessary for passing, but don't cause failures
Regarding the first patch, the file test_backends has been added., here are a few comments.
M-x whitespace-cleanup
that removes trailing whitespace from lines. Brian and I use it (or its equivalent) traditionally, so if you do too then there will be fewer lines unnecessarily touched. (I don't think David-Sarah uses emacs, but they do somehow always have whitespace-clean line endings...)FS
" is supposed to be changed to say "Disk
", if I understand correctly.Otherwise this looks like a good patch! I look forward to reviewing the rest of them...
I like the use of a mock/fake filesystem instead of the real local filesystem (disclaimer: I worked with Zancas on doing that for these patches).
Attachment addresseszookocomment01_20110809.darcs.patch (140448 bytes) added
changes the name of a patch to something more descriptive per zookos comment
Attachment addresseszookocomment02_whitespace_20110810.darcs.patch (147777 bytes) added
whitespace-cleanup run on most files touched by patches
Attachment addresseszookocomment03_whitespace_pyflakes_20110810.darcs.patch (155358 bytes) added
ugghh... more cleaning to do
Attachment newseries01_20110810.darcs.patch (50278 bytes) added
Initial file in a new iteration of rational patch-set structuring.
Attachment newseries_backendtouched_20110810.darcs.patch (34451 bytes) added
This patch bundle depends on newseries01
Attachment newseries_peripherals_20110810.darcs.patch (61826 bytes) added
makes changes in storage/common.py, backends/base.py, and allmydata/interfaces.py changes are minimal for passage of "null" test_write_share
Attachment 20110829dastodisk.darcs.patch (134085 bytes) added
This patch changes the older "das" term to the current "disk" as a backend type.
I added a dastodisk patch that corrects the backend-type name from "das" to "disk". This patch includes all the changes to the code I've made in the course of implementing a pluggable backend. You should apply it, in preference to any previous patch.
Attachment 20110829passespyflakes.darcs.patch (137412 bytes) added
pyflaked patch
This patch has all the pyflake-caught cruft cleaned up.
The three things mentioned in this ticket are done in [20110829passespyflakes.darcs.patch](/tahoe-lafs/trac-2024-07-25/attachments/000078ac-4240-b033-f5f2-0a1cec1ec9cc). The patch breaks a bunch of unit tests, but its own
allmydata.test.test_backends
unit tests pass. The sequence of darcs patches in [20110829passespyflakes.darcs.patch](/tahoe-lafs/trac-2024-07-25/attachments/000078ac-4240-b033-f5f2-0a1cec1ec9cc) are not nicely rebased to be a few coherent patches with nice descriptions, but the code that they contain is the most current code for #999. The patch doesn't change all code in Tahoe-LAFS to use twisted.python.filepath.FilePath (#1437), but it does consistently useFilePath
within the code that it touches.I'm going to close this ticket as "fixed" and move discussion and new patches back to the over-arching #999.