tahoe-lafs/trac-2024-07-25
2
0
Issues 1.1k Wiki

poor error message for wrong path syntax, e.g. "tahoe cp $CAP:$PATH ." #1379

New Issue
Closed
opened 2011-03-17 21:49:22 +00:00 by zooko · 2 comments
zooko commented 2011-03-17 21:49:22 +00:00
Copy Link

The error messages are unhelpful, but also it looks like there is a bug so that tahoe cp misparses the $CAP/path syntax in its source argument.

$ tahoe cp -v -r --node-url=http://localhost:3458 URI:DIR2-RO:o7mbbpxsznwfwiih5yzxmuqopq:cl72f3dnb6q7z4ajfjw24me5qwk7q7hfqrp5ho3dntuvoovspska:Latest .
error: you must specify a destination filename
$ tahoe cp -v -r --node-url=http://localhost:3458 URI:DIR2-RO:o7mbbpxsznwfwiih5yzxmuqopq:cl72f3dnb6q7z4ajfjw24me5qwk7q7hfqrp5ho3dntuvoovspska:Latest ./Latest
attaching sources to targets, 1 files / 0 dirs in root
targets assigned, 1 dirs, 2 files
starting copy, 2 files, 1 directories
Traceback (most recent call last):
  File "/Users/zooko/playground/tahoe-lafs/dw/support/bin/tahoe", line 9, in <module>
    load_entry_point('allmydata-tahoe==1.8.2-r5006', 'console_scripts', 'tahoe')()
  File "/Users/zooko/playground/tahoe-lafs/dw/src/allmydata/scripts/runner.py", line 113, in run
    rc = runner(sys.argv[1:], install_node_control=install_node_control)
  File "/Users/zooko/playground/tahoe-lafs/dw/src/allmydata/scripts/runner.py", line 99, in runner
    rc = cli.dispatch[command](so)
  File "/Users/zooko/playground/tahoe-lafs/dw/src/allmydata/scripts/cli.py", line 520, in cp
    rc = tahoe_cp.copy(options)
  File "/Users/zooko/playground/tahoe-lafs/dw/src/allmydata/scripts/tahoe_cp.py", line 762, in copy
    return Copier().do_copy(options)
  File "/Users/zooko/playground/tahoe-lafs/dw/src/allmydata/scripts/tahoe_cp.py", line 442, in do_copy
    status = self.try_copy()
  File "/Users/zooko/playground/tahoe-lafs/dw/src/allmydata/scripts/tahoe_cp.py", line 485, in try_copy
    return self.copy_to_directory(sources, target)
  File "/Users/zooko/playground/tahoe-lafs/dw/src/allmydata/scripts/tahoe_cp.py", line 664, in copy_to_directory
    self.copy_files_to_target(self.targetmap[target], target)
  File "/Users/zooko/playground/tahoe-lafs/dw/src/allmydata/scripts/tahoe_cp.py", line 695, in copy_files_to_target
    self.copy_file_into(source, name, target)
  File "/Users/zooko/playground/tahoe-lafs/dw/src/allmydata/scripts/tahoe_cp.py", line 739, in copy_file_into
    f = source.open(self.caps_only)
  File "/Users/zooko/playground/tahoe-lafs/dw/src/allmydata/scripts/tahoe_cp.py", line 178, in open
    url = self.nodeurl + "uri/" + urllib.quote(self.readcap)
  File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/urllib.py", line 1216, in quote
    res = map(safe_map.__getitem__, s)
TypeError: argument 2 to map() must support iteration
$ tahoe cp -v -r --node-url=http://localhost:3458 URI:DIR2-RO:o7mbbpxsznwfwiih5yzxmuqopq:cl72f3dnb6q7z4ajfjw24me5qwk7q7hfqrp5ho3dntuvoovspska:Latest/ .
examining 0 of 1
attaching sources to targets, 1 files / 0 dirs in root
targets assigned, 1 dirs, 2 files
starting copy, 2 files, 1 directories
Traceback (most recent call last):
  File "/Users/zooko/playground/tahoe-lafs/dw/support/bin/tahoe", line 9, in <module>
    load_entry_point('allmydata-tahoe==1.8.2-r5006', 'console_scripts', 'tahoe')()
  File "/Users/zooko/playground/tahoe-lafs/dw/src/allmydata/scripts/runner.py", line 113, in run
    rc = runner(sys.argv[1:], install_node_control=install_node_control)
  File "/Users/zooko/playground/tahoe-lafs/dw/src/allmydata/scripts/runner.py", line 99, in runner
    rc = cli.dispatch[command](so)
  File "/Users/zooko/playground/tahoe-lafs/dw/src/allmydata/scripts/cli.py", line 520, in cp
    rc = tahoe_cp.copy(options)
  File "/Users/zooko/playground/tahoe-lafs/dw/src/allmydata/scripts/tahoe_cp.py", line 762, in copy
    return Copier().do_copy(options)
  File "/Users/zooko/playground/tahoe-lafs/dw/src/allmydata/scripts/tahoe_cp.py", line 442, in do_copy
    status = self.try_copy()
  File "/Users/zooko/playground/tahoe-lafs/dw/src/allmydata/scripts/tahoe_cp.py", line 503, in try_copy
    return self.copy_to_directory(sources, target)
  File "/Users/zooko/playground/tahoe-lafs/dw/src/allmydata/scripts/tahoe_cp.py", line 664, in copy_to_directory
    self.copy_files_to_target(self.targetmap[target], target)
  File "/Users/zooko/playground/tahoe-lafs/dw/src/allmydata/scripts/tahoe_cp.py", line 695, in copy_files_to_target
    self.copy_file_into(source, name, target)
  File "/Users/zooko/playground/tahoe-lafs/dw/src/allmydata/scripts/tahoe_cp.py", line 739, in copy_file_into
    f = source.open(self.caps_only)
  File "/Users/zooko/playground/tahoe-lafs/dw/src/allmydata/scripts/tahoe_cp.py", line 178, in open
    url = self.nodeurl + "uri/" + urllib.quote(self.readcap)
  File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/urllib.py", line 1216, in quote
    res = map(safe_map.__getitem__, s)
TypeError: argument 2 to map() must support iteration
$ tahoe cp -v -r --node-url=http://localhost:3458 URI:DIR2-RO:o7mbbpxsznwfwiih5yzxmuqopq:cl72f3dnb6q7z4ajfjw24me5qwk7q7hfqrp5ho3dntuvoovspska:Latest/ ./Latest
attaching sources to targets, 1 files / 0 dirs in root
targets assigned, 1 dirs, 2 files
starting copy, 2 files, 1 directories
Traceback (most recent call last):
  File "/Users/zooko/playground/tahoe-lafs/dw/support/bin/tahoe", line 9, in <module>
    load_entry_point('allmydata-tahoe==1.8.2-r5006', 'console_scripts', 'tahoe')()
  File "/Users/zooko/playground/tahoe-lafs/dw/src/allmydata/scripts/runner.py", line 113, in run
    rc = runner(sys.argv[1:], install_node_control=install_node_control)
  File "/Users/zooko/playground/tahoe-lafs/dw/src/allmydata/scripts/runner.py", line 99, in runner
    rc = cli.dispatch[command](so)
  File "/Users/zooko/playground/tahoe-lafs/dw/src/allmydata/scripts/cli.py", line 520, in cp
    rc = tahoe_cp.copy(options)
  File "/Users/zooko/playground/tahoe-lafs/dw/src/allmydata/scripts/tahoe_cp.py", line 762, in copy
    return Copier().do_copy(options)
  File "/Users/zooko/playground/tahoe-lafs/dw/src/allmydata/scripts/tahoe_cp.py", line 442, in do_copy
    status = self.try_copy()
  File "/Users/zooko/playground/tahoe-lafs/dw/src/allmydata/scripts/tahoe_cp.py", line 503, in try_copy
    return self.copy_to_directory(sources, target)
  File "/Users/zooko/playground/tahoe-lafs/dw/src/allmydata/scripts/tahoe_cp.py", line 664, in copy_to_directory
    self.copy_files_to_target(self.targetmap[target], target)
  File "/Users/zooko/playground/tahoe-lafs/dw/src/allmydata/scripts/tahoe_cp.py", line 695, in copy_files_to_target
    self.copy_file_into(source, name, target)
  File "/Users/zooko/playground/tahoe-lafs/dw/src/allmydata/scripts/tahoe_cp.py", line 739, in copy_file_into
    f = source.open(self.caps_only)
  File "/Users/zooko/playground/tahoe-lafs/dw/src/allmydata/scripts/tahoe_cp.py", line 178, in open
    url = self.nodeurl + "uri/" + urllib.quote(self.readcap)
  File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/urllib.py", line 1216, in quote
    res = map(safe_map.__getitem__, s)
TypeError: argument 2 to map() must support iteration
The error messages are unhelpful, but also it looks like there is a bug so that `tahoe cp` misparses the `$CAP/path` syntax in its source argument. ``` $ tahoe cp -v -r --node-url=http://localhost:3458 URI:DIR2-RO:o7mbbpxsznwfwiih5yzxmuqopq:cl72f3dnb6q7z4ajfjw24me5qwk7q7hfqrp5ho3dntuvoovspska:Latest . error: you must specify a destination filename $ tahoe cp -v -r --node-url=http://localhost:3458 URI:DIR2-RO:o7mbbpxsznwfwiih5yzxmuqopq:cl72f3dnb6q7z4ajfjw24me5qwk7q7hfqrp5ho3dntuvoovspska:Latest ./Latest attaching sources to targets, 1 files / 0 dirs in root targets assigned, 1 dirs, 2 files starting copy, 2 files, 1 directories Traceback (most recent call last): File "/Users/zooko/playground/tahoe-lafs/dw/support/bin/tahoe", line 9, in <module> load_entry_point('allmydata-tahoe==1.8.2-r5006', 'console_scripts', 'tahoe')() File "/Users/zooko/playground/tahoe-lafs/dw/src/allmydata/scripts/runner.py", line 113, in run rc = runner(sys.argv[1:], install_node_control=install_node_control) File "/Users/zooko/playground/tahoe-lafs/dw/src/allmydata/scripts/runner.py", line 99, in runner rc = cli.dispatch[command](so) File "/Users/zooko/playground/tahoe-lafs/dw/src/allmydata/scripts/cli.py", line 520, in cp rc = tahoe_cp.copy(options) File "/Users/zooko/playground/tahoe-lafs/dw/src/allmydata/scripts/tahoe_cp.py", line 762, in copy return Copier().do_copy(options) File "/Users/zooko/playground/tahoe-lafs/dw/src/allmydata/scripts/tahoe_cp.py", line 442, in do_copy status = self.try_copy() File "/Users/zooko/playground/tahoe-lafs/dw/src/allmydata/scripts/tahoe_cp.py", line 485, in try_copy return self.copy_to_directory(sources, target) File "/Users/zooko/playground/tahoe-lafs/dw/src/allmydata/scripts/tahoe_cp.py", line 664, in copy_to_directory self.copy_files_to_target(self.targetmap[target], target) File "/Users/zooko/playground/tahoe-lafs/dw/src/allmydata/scripts/tahoe_cp.py", line 695, in copy_files_to_target self.copy_file_into(source, name, target) File "/Users/zooko/playground/tahoe-lafs/dw/src/allmydata/scripts/tahoe_cp.py", line 739, in copy_file_into f = source.open(self.caps_only) File "/Users/zooko/playground/tahoe-lafs/dw/src/allmydata/scripts/tahoe_cp.py", line 178, in open url = self.nodeurl + "uri/" + urllib.quote(self.readcap) File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/urllib.py", line 1216, in quote res = map(safe_map.__getitem__, s) TypeError: argument 2 to map() must support iteration $ tahoe cp -v -r --node-url=http://localhost:3458 URI:DIR2-RO:o7mbbpxsznwfwiih5yzxmuqopq:cl72f3dnb6q7z4ajfjw24me5qwk7q7hfqrp5ho3dntuvoovspska:Latest/ . examining 0 of 1 attaching sources to targets, 1 files / 0 dirs in root targets assigned, 1 dirs, 2 files starting copy, 2 files, 1 directories Traceback (most recent call last): File "/Users/zooko/playground/tahoe-lafs/dw/support/bin/tahoe", line 9, in <module> load_entry_point('allmydata-tahoe==1.8.2-r5006', 'console_scripts', 'tahoe')() File "/Users/zooko/playground/tahoe-lafs/dw/src/allmydata/scripts/runner.py", line 113, in run rc = runner(sys.argv[1:], install_node_control=install_node_control) File "/Users/zooko/playground/tahoe-lafs/dw/src/allmydata/scripts/runner.py", line 99, in runner rc = cli.dispatch[command](so) File "/Users/zooko/playground/tahoe-lafs/dw/src/allmydata/scripts/cli.py", line 520, in cp rc = tahoe_cp.copy(options) File "/Users/zooko/playground/tahoe-lafs/dw/src/allmydata/scripts/tahoe_cp.py", line 762, in copy return Copier().do_copy(options) File "/Users/zooko/playground/tahoe-lafs/dw/src/allmydata/scripts/tahoe_cp.py", line 442, in do_copy status = self.try_copy() File "/Users/zooko/playground/tahoe-lafs/dw/src/allmydata/scripts/tahoe_cp.py", line 503, in try_copy return self.copy_to_directory(sources, target) File "/Users/zooko/playground/tahoe-lafs/dw/src/allmydata/scripts/tahoe_cp.py", line 664, in copy_to_directory self.copy_files_to_target(self.targetmap[target], target) File "/Users/zooko/playground/tahoe-lafs/dw/src/allmydata/scripts/tahoe_cp.py", line 695, in copy_files_to_target self.copy_file_into(source, name, target) File "/Users/zooko/playground/tahoe-lafs/dw/src/allmydata/scripts/tahoe_cp.py", line 739, in copy_file_into f = source.open(self.caps_only) File "/Users/zooko/playground/tahoe-lafs/dw/src/allmydata/scripts/tahoe_cp.py", line 178, in open url = self.nodeurl + "uri/" + urllib.quote(self.readcap) File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/urllib.py", line 1216, in quote res = map(safe_map.__getitem__, s) TypeError: argument 2 to map() must support iteration $ tahoe cp -v -r --node-url=http://localhost:3458 URI:DIR2-RO:o7mbbpxsznwfwiih5yzxmuqopq:cl72f3dnb6q7z4ajfjw24me5qwk7q7hfqrp5ho3dntuvoovspska:Latest/ ./Latest attaching sources to targets, 1 files / 0 dirs in root targets assigned, 1 dirs, 2 files starting copy, 2 files, 1 directories Traceback (most recent call last): File "/Users/zooko/playground/tahoe-lafs/dw/support/bin/tahoe", line 9, in <module> load_entry_point('allmydata-tahoe==1.8.2-r5006', 'console_scripts', 'tahoe')() File "/Users/zooko/playground/tahoe-lafs/dw/src/allmydata/scripts/runner.py", line 113, in run rc = runner(sys.argv[1:], install_node_control=install_node_control) File "/Users/zooko/playground/tahoe-lafs/dw/src/allmydata/scripts/runner.py", line 99, in runner rc = cli.dispatch[command](so) File "/Users/zooko/playground/tahoe-lafs/dw/src/allmydata/scripts/cli.py", line 520, in cp rc = tahoe_cp.copy(options) File "/Users/zooko/playground/tahoe-lafs/dw/src/allmydata/scripts/tahoe_cp.py", line 762, in copy return Copier().do_copy(options) File "/Users/zooko/playground/tahoe-lafs/dw/src/allmydata/scripts/tahoe_cp.py", line 442, in do_copy status = self.try_copy() File "/Users/zooko/playground/tahoe-lafs/dw/src/allmydata/scripts/tahoe_cp.py", line 503, in try_copy return self.copy_to_directory(sources, target) File "/Users/zooko/playground/tahoe-lafs/dw/src/allmydata/scripts/tahoe_cp.py", line 664, in copy_to_directory self.copy_files_to_target(self.targetmap[target], target) File "/Users/zooko/playground/tahoe-lafs/dw/src/allmydata/scripts/tahoe_cp.py", line 695, in copy_files_to_target self.copy_file_into(source, name, target) File "/Users/zooko/playground/tahoe-lafs/dw/src/allmydata/scripts/tahoe_cp.py", line 739, in copy_file_into f = source.open(self.caps_only) File "/Users/zooko/playground/tahoe-lafs/dw/src/allmydata/scripts/tahoe_cp.py", line 178, in open url = self.nodeurl + "uri/" + urllib.quote(self.readcap) File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/urllib.py", line 1216, in quote res = map(safe_map.__getitem__, s) TypeError: argument 2 to map() must support iteration ```
zooko added the
code-frontend-cli
major
defect
1.8.2
 labels 2011-03-17 21:49:22 +00:00
zooko added this to the undecided milestone 2011-03-17 21:49:22 +00:00
davidsarah commented 2011-05-15 00:21:08 +00:00
Owner
Copy Link

If Latest is a subdirectory of the given dircap, shouldn't it be:

tahoe cp -v -r --node-url=http://localhost:3458 URI:DIR2-RO:blah/Latest ./Latest

?

(I.e. you have "tahoe cp $CAP:$PATH .", not "tahoe cp $CAP/$PATH ." in the examples.)

Having said that, "TypeError: argument 2 to map() must support iteration" is a horrible way to report the error.

If Latest is a subdirectory of the given dircap, shouldn't it be: ``` tahoe cp -v -r --node-url=http://localhost:3458 URI:DIR2-RO:blah/Latest ./Latest ``` ? (I.e. you have "`tahoe cp $CAP:$PATH .`", not "`tahoe cp $CAP/$PATH .`" in the examples.) Having said that, "TypeError: argument 2 to map() must support iteration" is a horrible way to report the error.
tahoe-lafs modified the milestone from undecided to 1.10.0 2011-07-27 16:18:14 +00:00
davidsarah commented 2011-08-03 21:57:21 +00:00
Owner
Copy Link

I'm merging this with #1217, since the incorrect path syntax is the same ($CAP:$PATH). I don't know why the error message is different; perhaps it's because this ticket has an incorrect source argument whereas #1217 has an incorrect destination argument.

I'm merging this with #1217, since the incorrect path syntax is the same ($CAP:$PATH). I don't know why the error message is different; perhaps it's because this ticket has an incorrect source argument whereas #1217 has an incorrect destination argument.
tahoe-lafs added the
duplicate
 label 2011-08-03 21:57:21 +00:00
davidsarah closed this issue 2011-08-03 21:57:21 +00:00
tahoe-lafs changed title from misparse of "tahoe cp $CAP/$PATH ." to poor error message for wrong path syntax, e.g. "tahoe cp $CAP:$PATH ." 2011-08-03 21:57:21 +00:00
tahoe-lafs modified the milestone from 1.11.0 to eventually 2012-04-01 00:00:48 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
0.2.0

   
0.3.0

   
0.4.0

   
0.5.0

   
0.5.1

   
0.6.0

   
0.6.1

   
0.7.0

   
0.8.0

   
0.9.0

   
1.0.0

   
1.1.0

   
1.10.0

   
1.10.1

   
1.10.2

   
1.10a2

   
1.11.0

   
1.12.0

   
1.12.1

   
1.13.0

   
1.14.0

   
1.15.0

   
1.15.1

   
1.2.0

   
1.3.0

   
1.4.1

   
1.5.0

   
1.6.0

   
1.6.1

   
1.7.0

   
1.7.1

   
1.7β

   
1.8.0

   
1.8.1

   
1.8.2

   
1.8.3

   
1.8β

   
1.9.0

   
1.9.0-s3branch

   
1.9.0a1

   
1.9.0a2

   
1.9.0b1

   
1.9.1

   
1.9.2

   
1.9.2a1

   
LeastAuthority.com automation

   
blocker

   
cannot reproduce

   
cloud-branch

   
code

catch-all for anything that can be fixed by writing code but isn't classified better

  
code-dirnodes

anything involving tahoe directories

  
code-encoding

immutable-file encoding format/layout, cap format, encoding/decoding algorithms

  
code-frontend

general frontend things: new user-facing interfaces, FTP/SFTP servers, FUSE-like interfaces

  
code-frontend-cli

CLI tools

  
code-frontend-ftp-sftp

   
code-frontend-magic-folder

   
code-frontend-web

webapi interfaces, user-facing "WUI" interfaces

  
code-mutable

anything involving mutable files: encoding/decoding, share format

  
code-network

Introducer, locating storage servers, establishing/maintaining connections to them

  
code-nodeadmin

node startup/shutdown, tools to create nodes, logging tools, management/monitoring tools, manhole, disk-space-limiting tools

  
code-peerselection

server selection/sorting algorithm, rebalancing code, allocation policy, swarming-download

  
code-storage

storage-server implementation, share-storage directory layout, client-to-server share transfer protocol

  
contrib

problems with non-core things that live in the source:contrib/ directory

  
critical

   
defect

   
dev-infrastructure

things that help us build Tahoe: buildbot, automated speed/memory/code-coverage tests and results-displayers, IRC channels, mailing lists, this Trac instance

  
documentation

docs items. Also use 'docs' keyword on tickets in more specific components.

  
duplicate

   
enhancement

   
fixed

   
invalid

   
major

   
minor

   
n/a

   
normal

   
operational

things involved in running a tahoe grid, external tools to monitor/maintain a grid (like "nodeadmin" but larger-scale). Was also used for issues with the allmydata.com grid.

  
packaging

setup.py script, library dependencies, binary packages, licensing, installation instructions

  
somebody else's problem

   
supercritical

   
task

   
trivial

   
unknown

Uncategorized. All tickets default to this component until someone updates it.

  
was already fixed

   
website

things about the tahoe-lafs.org website (and sometimes this Trac instance, shared with 'dev-infrastructure')

  
wontfix

   
worksforme
No Label
0.2.0
0.3.0
0.4.0
0.5.0
0.5.1
0.6.0
0.6.1
0.7.0
0.8.0
0.9.0
1.0.0
1.1.0
1.10.0
1.10.1
1.10.2
1.10a2
1.11.0
1.12.0
1.12.1
1.13.0
1.14.0
1.15.0
1.15.1
1.2.0
1.3.0
1.4.1
1.5.0
1.6.0
1.6.1
1.7.0
1.7.1
1.7β
1.8.0
1.8.1
1.8.2
1.8.3
1.8β
1.9.0
1.9.0-s3branch
1.9.0a1
1.9.0a2
1.9.0b1
1.9.1
1.9.2
1.9.2a1
LeastAuthority.com automation
blocker
cannot reproduce
cloud-branch
code
code-dirnodes
code-encoding
code-frontend
code-frontend-cli
code-frontend-ftp-sftp
code-frontend-magic-folder
code-frontend-web
code-mutable
code-network
code-nodeadmin
code-peerselection
code-storage
contrib
critical
defect
dev-infrastructure
documentation
duplicate
enhancement
fixed
invalid
major
minor
n/a
normal
operational
packaging
somebody else's problem
supercritical
task
trivial
unknown
was already fixed
website
wontfix
worksforme
Milestone
Clear milestone
No items
No Milestone
eventually
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Reference: tahoe-lafs/trac-2024-07-25#1379
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?