'private/' subdir of BASEDIR should be created during 'tahoe create-alias' and friends #1333

New Issue

warner · 2011-01-20T03:32:33Z

warner commented

2011-01-20 03:32:33 +00:00

user 'munderwo' on the IRC channel noticed an exception when they manually deleted their ~/.tahoe directory, then re-created it, then ran tahoe create-alias. It complained that the ~/.tahoe/private directory did not exist, which trying to write aliases.tmp.

I suspect that we create this directory during tahoe create-client, but then assume that it exists later. Instead, if tahoe create-alias notices that it is missing, it should just re-mkdir it.

user 'munderwo' on the IRC channel noticed an exception when they manually deleted their `~/.tahoe` directory, then re-created it, then ran `tahoe create-alias`. It complained that the `~/.tahoe/private` directory did not exist, which trying to write `aliases.tmp`. I suspect that we create this directory during `tahoe create-client`, but then assume that it exists later. Instead, if `tahoe create-alias` notices that it is missing, it should just re-mkdir it.

warner added the

labels 2011-01-20 03:32:33 +00:00

warner added this to the undecided milestone 2011-01-20 03:32:33 +00:00

warner commented

2012-01-04 21:48:08 +00:00

discussing this on IRC just now, we agreed that both create-alias and add-alias are allowed to require the pre-existence of NODEDIR and NODEDIR/node.url, but both should os.mkdir(NODEDIR/private) when necessary.

It'd be polite if both commands, when faced with a missing NODEDIR or NODEDIR/node.url, were to tell the user (in the error message) that they should create them, rather than throwing a weird exception that's hard to understand. But that's not strictly necessary to resolve this ticket.

The main code changes will go into src/allmydata/scripts/tahoe_add_alias.py. The unit test should probably be added to the end of CreateAlias.test_create in source:src/allmydata/test/test_cli.py , and should clobber private/ and then re-run tahoe create-alias and verify the results (by reading the alias file). It might be a good idea to test add-alias too, which is a bit easier (it doesn't need to talk to an actual node).

discussing this on IRC just now, we agreed that both `create-alias` and `add-alias` are allowed to require the pre-existence of `NODEDIR` and `NODEDIR/node.url`, but both should `os.mkdir(NODEDIR/private)` when necessary. It'd be polite if both commands, when faced with a missing NODEDIR or NODEDIR/node.url, were to tell the user (in the error message) that they should create them, rather than throwing a weird exception that's hard to understand. But that's not strictly necessary to resolve this ticket. The main code changes will go into `src/allmydata/scripts/tahoe_add_alias.py`. The unit test should probably be added to the end of `CreateAlias.test_create` in source:src/allmydata/test/test_cli.py , and should clobber `private/` and then re-run `tahoe create-alias` and verify the results (by reading the alias file). It might be a good idea to test `add-alias` too, which is a bit easier (it doesn't need to talk to an actual node).