eliminate use of urllib.urlopen in check_load #1254

New Issue

tahoe-lafs · 2010-11-10T01:06:59Z

davidsarah commented

2010-11-10 01:06:59 +00:00

As noted in /tahoe-lafs/trac-2024-07-25/issues/6315#comment:9, we should not be using urllib.urlopen (or urllib2.urlopen) anywhere, because its use of proxy servers is in violation of our security model.

As noted in [/tahoe-lafs/trac-2024-07-25/issues/6315](/tahoe-lafs/trac-2024-07-25/issues/6315)#comment:9, we should not be using `urllib.urlopen` (or `urllib2.urlopen`) anywhere, because its use of proxy servers is in violation of our security model.

tahoe-lafs added the

labels 2010-11-10 01:06:59 +00:00

tahoe-lafs added this to the soon milestone 2010-11-10 01:06:59 +00:00

warner commented

2010-12-25 00:09:39 +00:00

The only uses I find are in some load-testing test utilities and in the
ancient probably-doesn't-even-work-anymore "config wizard":

% find src -name '*.py' |xargs grep urlopen
src/allmydata/gui/confwiz.py:    conn = urllib2.urlopen(url, argstr)
src/allmydata/test/check_load.py:    data = urllib.urlopen(url).read()
src/allmydata/test/check_load.py:    f = urllib.urlopen(url)

All our CLI tools use httplib.HTTPConnection (or
HTTPSConnection).

Does this seem safe to close?

The only uses I find are in some load-testing test utilities and in the ancient probably-doesn't-even-work-anymore "config wizard": ``` % find src -name '*.py' |xargs grep urlopen src/allmydata/gui/confwiz.py: conn = urllib2.urlopen(url, argstr) src/allmydata/test/check_load.py: data = urllib.urlopen(url).read() src/allmydata/test/check_load.py: f = urllib.urlopen(url) ``` All our CLI tools use `httplib.HTTPConnection` (or `HTTPSConnection`). Does this seem safe to close?

davidsarah commented

2010-12-26 03:20:41 +00:00

#1282 would remove the config wizard.

The check_load test, although it is currently bitrotten IIRC, is still useful and should be fixed. Using a proxy might cause it to fail for the wrong reason.

#1282 would remove the config wizard. The `check_load` test, although it is currently bitrotten IIRC, is still useful and should be fixed. Using a proxy might cause it to fail for the wrong reason.

tahoe-lafs changed title from ~~eliminate all uses of urllib.urlopen~~ to eliminate use of urllib.urlopen in check_load

2011-01-02 18:55:49 +00:00

Sign in to join this conversation.