refactor get_disk_stats() and get_available_space() #1195

New Issue

zooko · 2010-09-10T18:54:30Z

zooko commented

2010-09-10 18:54:30 +00:00

Move get_disk_stats() and get_available() space into fileutil.

zooko added the

labels 2010-09-10 18:54:30 +00:00

zooko added this to the soon milestone 2010-09-10 18:54:30 +00:00

zooko commented

2010-09-10 18:58:09 +00:00

Attachment storage-refactor.dpatch (20174 bytes) added

**Attachment** storage-refactor.dpatch (20174 bytes) added

storage-refactor.dpatch

20 KiB

davidsarah commented

2010-09-11 00:25:12 +00:00

Looks good.

tahoe-lafs modified the milestone from soon to 1.9.0

2010-10-14 04:37:23 +00:00

zooko commented

2010-10-18 02:41:04 +00:00

See also #47

david-sarah@jacaranda.org commented

2010-12-31 21:02:18 +00:00

In changeset:0da10d4c373eae19:

test_storage.py: leave at least 512 MiB free when running test_large_share. refs #1195

In changeset:0da10d4c373eae19: ``` test_storage.py: leave at least 512 MiB free when running test_large_share. refs #1195 ```

davidsarah commented

2010-12-31 21:05:08 +00:00

Applied in changeset:d5e71c29408bab67 and changeset:123a1a3f04e046fa, and adjusted to leave 512 MiB free in changeset:0da10d4c373eae19. (The latter will only cause additional test-skips on filesystems that have between 4 and 4.5 GiB free.)

tahoe-lafs added the

fixed

label 2010-12-31 21:05:08 +00:00

davidsarah closed this issue

2010-12-31 21:05:08 +00:00

davidsarah commented

2010-12-31 21:28:33 +00:00

Note that these patches change where the call to

win32api.SetErrorMode(win32con.SEM_FAILCRITICALERRORS |
                      win32con.SEM_NOOPENFILEERRORBOX)

occurs. Previously that was called when source:src/allmydata/storage/server.py was imported; now it is called when source:src/allmydata/util/fileutil.py is imported. It is a good idea to make this call early in the execution of all Windows server or non-GUI software, so #1274 is going to move it to source:src/allmydata/windows/fixups.py (which is also a more predictable and debuggable place in case there are any problems with it).

Note that these patches change where the call to ``` win32api.SetErrorMode(win32con.SEM_FAILCRITICALERRORS | win32con.SEM_NOOPENFILEERRORBOX) ``` occurs. Previously that was called when source:src/allmydata/storage/server.py was imported; now it is called when source:src/allmydata/util/fileutil.py is imported. It is a good idea to make this call early in the execution of all Windows server or non-GUI software, so #1274 is going to move it to source:src/allmydata/windows/fixups.py (which is also a more predictable and debuggable place in case there are any problems with it).

Sign in to join this conversation.