tahoe-lafs
/
trac-2024-07-25
2
0
Issues 1.1k Wiki

Garbage Collector need to remove subdirs of storage/shares when deleting shares #1194

New Issue
Open
opened 2010-09-06 22:22:09 +00:00 by freestorm · 1 comment
freestorm commented 2010-09-06 22:22:09 +00:00
Owner
Copy Link

As discussed with Warner on IRC,

When GC deletes shares on the grid, it doesn't remove prefixdir and storageindex-dir.

The munin plugin tahoe_files counts storageindex-dir to know how many files are on the Grid.

The count is not correct because empty subdirs are present on storage/shares/.

As discussed with Warner on IRC, When GC deletes shares on the grid, it doesn't remove *prefixdir* and *storageindex-dir*. The munin plugin [tahoe_files](http://tahoe-lafs.org/trac/tahoe-lafs/browser/trunk/misc/operations_helpers/munin/tahoe_files) counts *storageindex-dir* to know how many files are on the Grid. The count is not correct because empty subdirs are present on `storage/shares/`.
tahoe-lafs added the
unknown
minor
defect
1.8β
 labels 2010-09-06 22:22:09 +00:00
tahoe-lafs added this to the undecided milestone 2010-09-06 22:22:09 +00:00
warner commented 2010-09-06 22:41:40 +00:00
Copy Link

In particular, when a share lives in BASEDIR/storage/shares/PREFIXDIR/SIDIR/SHNUM (e.g. node-1/storage/shares/d5/d5j2wyxwvrwiftiwvujhozu67i/3), if we delete the last share in the SIDIR, then we should also delete the SIDIR (but leave the PREFIXDIR), e.g. leave node-1/storage/shares/d5 but delete everything below that.

This requires code in allmydata.storage.immutable.ShareFile.unlink and allmydata.storage.mutable.MutableShareFile.unlink to look in the parent directory, see if it's empty, and if so unlink the parent.

In particular, when a share lives in `BASEDIR/storage/shares/PREFIXDIR/SIDIR/SHNUM` (e.g. `node-1/storage/shares/d5/d5j2wyxwvrwiftiwvujhozu67i/3`), if we delete the last share in the SIDIR, then we should also delete the SIDIR (but leave the PREFIXDIR), e.g. leave `node-1/storage/shares/d5` but delete everything below that. This requires code in `allmydata.storage.immutable.ShareFile.unlink` and `allmydata.storage.mutable.MutableShareFile.unlink` to look in the parent directory, see if it's empty, and if so unlink the parent.
warner added
code-storage
 and removed
unknown
 labels 2010-09-06 22:41:40 +00:00
tahoe-lafs added
normal
 and removed
minor
 labels 2012-04-01 05:09:29 +00:00
tahoe-lafs modified the milestone from undecided to eventually 2012-04-01 05:09:29 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
0.2.0

   
0.3.0

   
0.4.0

   
0.5.0

   
0.5.1

   
0.6.0

   
0.6.1

   
0.7.0

   
0.8.0

   
0.9.0

   
1.0.0

   
1.1.0

   
1.10.0

   
1.10.1

   
1.10.2

   
1.10a2

   
1.11.0

   
1.12.0

   
1.12.1

   
1.13.0

   
1.14.0

   
1.15.0

   
1.15.1

   
1.2.0

   
1.3.0

   
1.4.1

   
1.5.0

   
1.6.0

   
1.6.1

   
1.7.0

   
1.7.1

   
1.7β

   
1.8.0

   
1.8.1

   
1.8.2

   
1.8.3

   
1.8β

   
1.9.0

   
1.9.0-s3branch

   
1.9.0a1

   
1.9.0a2

   
1.9.0b1

   
1.9.1

   
1.9.2

   
1.9.2a1

   
LeastAuthority.com automation

   
blocker

   
cannot reproduce

   
cloud-branch

   
code

catch-all for anything that can be fixed by writing code but isn't classified better

  
code-dirnodes

anything involving tahoe directories

  
code-encoding

immutable-file encoding format/layout, cap format, encoding/decoding algorithms

  
code-frontend

general frontend things: new user-facing interfaces, FTP/SFTP servers, FUSE-like interfaces

  
code-frontend-cli

CLI tools

  
code-frontend-ftp-sftp

   
code-frontend-magic-folder

   
code-frontend-web

webapi interfaces, user-facing "WUI" interfaces

  
code-mutable

anything involving mutable files: encoding/decoding, share format

  
code-network

Introducer, locating storage servers, establishing/maintaining connections to them

  
code-nodeadmin

node startup/shutdown, tools to create nodes, logging tools, management/monitoring tools, manhole, disk-space-limiting tools

  
code-peerselection

server selection/sorting algorithm, rebalancing code, allocation policy, swarming-download

  
code-storage

storage-server implementation, share-storage directory layout, client-to-server share transfer protocol

  
contrib

problems with non-core things that live in the source:contrib/ directory

  
critical

   
defect

   
dev-infrastructure

things that help us build Tahoe: buildbot, automated speed/memory/code-coverage tests and results-displayers, IRC channels, mailing lists, this Trac instance

  
documentation

docs items. Also use 'docs' keyword on tickets in more specific components.

  
duplicate

   
enhancement

   
fixed

   
invalid

   
major

   
minor

   
n/a

   
normal

   
operational

things involved in running a tahoe grid, external tools to monitor/maintain a grid (like "nodeadmin" but larger-scale). Was also used for issues with the allmydata.com grid.

  
packaging

setup.py script, library dependencies, binary packages, licensing, installation instructions

  
somebody else's problem

   
supercritical

   
task

   
trivial

   
unknown

Uncategorized. All tickets default to this component until someone updates it.

  
was already fixed

   
website

things about the tahoe-lafs.org website (and sometimes this Trac instance, shared with 'dev-infrastructure')

  
wontfix

   
worksforme
No Label
0.2.0
0.3.0
0.4.0
0.5.0
0.5.1
0.6.0
0.6.1
0.7.0
0.8.0
0.9.0
1.0.0
1.1.0
1.10.0
1.10.1
1.10.2
1.10a2
1.11.0
1.12.0
1.12.1
1.13.0
1.14.0
1.15.0
1.15.1
1.2.0
1.3.0
1.4.1
1.5.0
1.6.0
1.6.1
1.7.0
1.7.1
1.7β
1.8.0
1.8.1
1.8.2
1.8.3
1.8β
1.9.0
1.9.0-s3branch
1.9.0a1
1.9.0a2
1.9.0b1
1.9.1
1.9.2
1.9.2a1
LeastAuthority.com automation
blocker
cannot reproduce
cloud-branch
code
code-dirnodes
code-encoding
code-frontend
code-frontend-cli
code-frontend-ftp-sftp
code-frontend-magic-folder
code-frontend-web
code-mutable
code-network
code-nodeadmin
code-peerselection
code-storage
contrib
critical
defect
dev-infrastructure
documentation
duplicate
enhancement
fixed
invalid
major
minor
n/a
normal
operational
packaging
somebody else's problem
supercritical
task
trivial
unknown
was already fixed
website
wontfix
worksforme
Milestone
Clear milestone
No items
No Milestone
eventually
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Reference: tahoe-lafs/trac-2024-07-25#1194
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?