need tests for create-{client, node} with default nodedir #1153

New Issue

tahoe-lafs · 2010-08-03T04:05:04Z

davidsarah commented

2010-08-03 04:05:04 +00:00

We shouldn't create a node at the actual default basedir (which might already exist), which is why there are no existing tests for this.

However, we could:

check that the result of [get_default_nodedir]source:src/allmydata/scripts/common.py@4615#L10 is sensible;
mock get_default_nodedir to return a default nodedir under the _trial_temp directory.

To test the logic for getting the default nodedir from the registry entry on Windows, we can mock sys.platform and allmydata.windows.registry.get_registry_value.

We shouldn't create a node at the actual default basedir (which might already exist), which is why there are no existing tests for this. However, we could: * check that the result of [get_default_nodedir]source:src/allmydata/scripts/common.py@4615#L10 is sensible; * mock `get_default_nodedir` to return a default nodedir under the `_trial_temp` directory. To test the logic for getting the default nodedir from the registry entry on Windows, we can mock `sys.platform` and `allmydata.windows.registry.get_registry_value`.