tahoe-lafs/tahoe-lafs
tahoe-lafs
/
tahoe-lafs
2
0
Fork 0
Code Issues Pull Requests 23 Packages Projects Releases 1 Wiki Activity

Replace eliot_logged_test with something ... else #973

Merged
exarkun merged 6 commits from 3600.eliotutil-vs-skips into master 2021-02-12 17:10:38 +00:00
Conversation 1 Commits 6 Files Changed 3 +182 -99
exarkun commented 2021-01-27 16:36:32 +00:00 (Migrated from github.com)
Copy Link

https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3600

https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3600
codecov[bot] commented 2021-01-27 16:39:12 +00:00 (Migrated from github.com)
Copy Link

Codecov Report

Merging #973 (81edda8) into master (27e223a) will increase coverage by 14%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #973     +/-   ##
========================================
+ Coverage      77%     92%    +14%     
========================================
  Files         151     151             
  Lines       27066   27047     -19     
  Branches     4051    4051             
========================================
+ Hits        20924   24824   +3900     
+ Misses       5499    1585   -3914     
+ Partials      643     638      -5
Impacted Files Coverage Δ
src/allmydata/web/unlinked.py 86% <0%> (-<1%) ⬇️
src/allmydata/frontends/sftpd.py 91% <0%> (+<1%) ⬆️
src/allmydata/mutable/layout.py 93% <0%> (+<1%) ⬆️
src/allmydata/web/common.py 95% <0%> (+<1%) ⬆️
src/allmydata/mutable/filenode.py 99% <0%> (+<1%) ⬆️
src/allmydata/mutable/retrieve.py 96% <0%> (+<1%) ⬆️
src/allmydata/interfaces.py 99% <0%> (+<1%) ⬆️
src/allmydata/immutable/upload.py 95% <0%> (+<1%) ⬆️
src/allmydata/immutable/encode.py 95% <0%> (+<1%) ⬆️
src/allmydata/web/directory.py 92% <0%> (+1%) ⬆️
... and 126 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27e223a...9a9b4bb. Read the comment docs.

# [Codecov](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/973?src=pr&el=h1) Report > Merging [#973](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/973?src=pr&el=desc) (81edda8) into [master](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/commit/27e223aba8ce96a30ebb2f7b725e6080ce7cf05b?el=desc) (27e223a) will **increase** coverage by `14%`. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/973/graphs/tree.svg?width=650&height=150&src=pr&token=Ztmu9sr4vi)](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/973?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #973 +/- ## ======================================== + Coverage 77% 92% +14% ======================================== Files 151 151 Lines 27066 27047 -19 Branches 4051 4051 ======================================== + Hits 20924 24824 +3900 + Misses 5499 1585 -3914 + Partials 643 638 -5 ``` | [Impacted Files](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/973?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [src/allmydata/web/unlinked.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/973/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS93ZWIvdW5saW5rZWQucHk=) | `86% <0%> (-<1%)` | :arrow_down: | | [src/allmydata/frontends/sftpd.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/973/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS9mcm9udGVuZHMvc2Z0cGQucHk=) | `91% <0%> (+<1%)` | :arrow_up: | | [src/allmydata/mutable/layout.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/973/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS9tdXRhYmxlL2xheW91dC5weQ==) | `93% <0%> (+<1%)` | :arrow_up: | | [src/allmydata/web/common.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/973/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS93ZWIvY29tbW9uLnB5) | `95% <0%> (+<1%)` | :arrow_up: | | [src/allmydata/mutable/filenode.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/973/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS9tdXRhYmxlL2ZpbGVub2RlLnB5) | `99% <0%> (+<1%)` | :arrow_up: | | [src/allmydata/mutable/retrieve.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/973/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS9tdXRhYmxlL3JldHJpZXZlLnB5) | `96% <0%> (+<1%)` | :arrow_up: | | [src/allmydata/interfaces.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/973/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS9pbnRlcmZhY2VzLnB5) | `99% <0%> (+<1%)` | :arrow_up: | | [src/allmydata/immutable/upload.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/973/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS9pbW11dGFibGUvdXBsb2FkLnB5) | `95% <0%> (+<1%)` | :arrow_up: | | [src/allmydata/immutable/encode.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/973/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS9pbW11dGFibGUvZW5jb2RlLnB5) | `95% <0%> (+<1%)` | :arrow_up: | | [src/allmydata/web/directory.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/973/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS93ZWIvZGlyZWN0b3J5LnB5) | `92% <0%> (+1%)` | :arrow_up: | | ... and [126 more](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/973/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/973?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/973?src=pr&el=footer). Last update [27e223a...9a9b4bb](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/973?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
meejah (Migrated from github.com) approved these changes 2021-02-07 03:15:49 +00:00
meejah (Migrated from github.com) left a comment
Copy Link

Looks good. One inline thing to fix then merge.

Looks good. One inline thing to fix then merge.
src/allmydata/test/eliotutil.py
meejah (Migrated from github.com) commented 2021-02-07 03:04:03 +00:00
Copy Link

For proper cleanup, original should be set again I think.

For proper cleanup, `original` should be set again I think.
src/allmydata/test/eliotutil.py
meejah (Migrated from github.com) commented 2021-02-07 03:15:18 +00:00
Copy Link

So "a logger" is just anything that has a .write method?

So "a logger" is just anything that has a `.write` method?
exarkun (Migrated from github.com) reviewed 2021-02-12 15:23:20 +00:00
src/allmydata/test/eliotutil.py
exarkun (Migrated from github.com) commented 2021-02-12 15:22:59 +00:00
Copy Link

Almost. Added more docs to make this clear.

Almost. Added more docs to make this clear.
Sign in to join this conversation.
Reviewers
No reviewers
meejah
Labels
Clear labels   
Benchmarking and Performance

   
HTTP Storage Protocol

   
Nevow Removal

   
Python 3 Porting

   
not-for-merge
No Label
Benchmarking and Performance
HTTP Storage Protocol
Nevow Removal
Python 3 Porting
not-for-merge
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: tahoe-lafs/tahoe-lafs#973
No description provided.
Delete Branch "3600.eliotutil-vs-skips"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?