Port unknown to Python 3 #947

2020-12-29T15:41:49Z

chadwhitacre commented

2020-12-29 15:41:49 +00:00

(Migrated from github.com)

This is covered by test_dirnode/test_grid (so perhaps merge #945 first).

https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3576

This is covered by test_dirnode/test_grid (so perhaps merge #945 first). https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3576

itamarst (Migrated from github.com) reviewed 2020-12-29 15:41:49 +00:00

exarkun (Migrated from github.com) reviewed 2020-12-29 15:41:49 +00:00

codecov[bot] commented

2020-12-29 15:55:59 +00:00

(Migrated from github.com)

Codecov Report

Merging #947 (f717250) into master (4a7da34) will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master    #947   +/-   ##
======================================
  Coverage      92%     92%           
======================================
  Files         150     150           
  Lines       26931   26938    +7     
  Branches     4041    4042    +1     
======================================
+ Hits        24879   24888    +9     
+ Misses       1407    1406    -1     
+ Partials      645     644    -1

Impacted Files	Coverage Δ
src/allmydata/util/_python3.py	`100% <ø> (ø)`
src/allmydata/unknown.py	`92% <100%> (+1%)`	⬆️
src/allmydata/web/status.py	`95% <0%> (+<1%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a7da34...f717250. Read the comment docs.

# [Codecov](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/947?src=pr&el=h1) Report > Merging [#947](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/947?src=pr&el=desc) (f717250) into [master](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/commit/4a7da34a6a0c90d469e10ed7e9024de781d85c2f?el=desc) (4a7da34) will **increase** coverage by `0%`. > The diff coverage is `100%`. [![Impacted file tree graph](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/947/graphs/tree.svg?width=650&height=150&src=pr&token=Ztmu9sr4vi)](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/947?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #947 +/- ## ====================================== Coverage 92% 92% ====================================== Files 150 150 Lines 26931 26938 +7 Branches 4041 4042 +1 ====================================== + Hits 24879 24888 +9 + Misses 1407 1406 -1 + Partials 645 644 -1 ``` | [Impacted Files](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/947?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [src/allmydata/util/\_python3.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/947/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS91dGlsL19weXRob24zLnB5) | `100% <ø> (ø)` | | | [src/allmydata/unknown.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/947/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS91bmtub3duLnB5) | `92% <100%> (+1%)` | :arrow_up: | | [src/allmydata/web/status.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/947/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS93ZWIvc3RhdHVzLnB5) | `95% <0%> (+<1%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/947?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/947?src=pr&el=footer). Last update [4a7da34...f717250](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/947?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

meejah (Migrated from github.com) approved these changes 2021-01-04 20:30:50 +00:00

meejah (Migrated from github.com) left a comment

LGTM

chadwhitacre commented

2021-01-05 11:05:09 +00:00

(Migrated from github.com)

Hackishly trying to tickle CircleCI into doing its job.

Sign in to join this conversation.

No reviewers

itamarst

exarkun

meejah