tahoe-lafs/tahoe-lafs
tahoe-lafs
/
tahoe-lafs
2
0
Fork 0
Code Issues Pull Requests 23 Packages Projects Releases 1 Wiki Activity

Makes furls not bytes #914

Merged
itamarst merged 10 commits from 3544.furls-not-bytes-maybe into master 2020-12-09 14:20:33 +00:00
Conversation 1 Commits 10 Files Changed 10 +48 -52
itamarst commented 2020-12-02 20:27:05 +00:00 (Migrated from github.com)
Copy Link

Seemed like it was just extra effort and confusion.

Fixes https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3544

Seemed like it was just extra effort and confusion. Fixes https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3544
codecov[bot] commented 2020-12-02 21:26:03 +00:00 (Migrated from github.com)
Copy Link

Codecov Report

Merging #914 (0cf9be1) into master (8f3acb7) will increase coverage by 0%.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #914   +/-   ##
======================================
  Coverage      92%     92%           
======================================
  Files         157     157           
  Lines       27479   27475    -4     
  Branches     4111    4109    -2     
======================================
- Hits        25276   25273    -3     
  Misses       1537    1537           
+ Partials      666     665    -1
Impacted Files Coverage Δ
src/allmydata/introducer/common.py 100% <100%> (+2%) ⬆️
src/allmydata/storage_client.py 96% <100%> (-<1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f3acb7...0cf9be1. Read the comment docs.

# [Codecov](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/914?src=pr&el=h1) Report > Merging [#914](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/914?src=pr&el=desc) (0cf9be1) into [master](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/commit/8f3acb7eb6f6b8b3f903b312b8757d5ef50e9efb?el=desc) (8f3acb7) will **increase** coverage by `0%`. > The diff coverage is `100%`. [![Impacted file tree graph](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/914/graphs/tree.svg?width=650&height=150&src=pr&token=Ztmu9sr4vi)](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/914?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #914 +/- ## ====================================== Coverage 92% 92% ====================================== Files 157 157 Lines 27479 27475 -4 Branches 4111 4109 -2 ====================================== - Hits 25276 25273 -3 Misses 1537 1537 + Partials 666 665 -1 ``` | [Impacted Files](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/914?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [src/allmydata/introducer/common.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/914/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS9pbnRyb2R1Y2VyL2NvbW1vbi5weQ==) | `100% <100%> (+2%)` | :arrow_up: | | [src/allmydata/storage\_client.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/914/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS9zdG9yYWdlX2NsaWVudC5weQ==) | `96% <100%> (-<1%)` | :arrow_down: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/914?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/914?src=pr&el=footer). Last update [8f3acb7...0cf9be1](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/914?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
exarkun (Migrated from github.com) approved these changes 2020-12-04 15:46:42 +00:00
exarkun (Migrated from github.com) left a comment
Copy Link

Thanks. Seems fine. One minor inline comment; please address then merge.

Thanks. Seems fine. One minor inline comment; please address then merge.
src/allmydata/storage_client.py
@ -562,6 +562,7 @@ class _FoolscapStorage(object):
exarkun (Migrated from github.com) commented 2020-12-04 15:41:19 +00:00
Copy Link

Maybe adding type docs to the docstring here would be good

Maybe adding type docs to the docstring here would be good
itamarst (Migrated from github.com) reviewed 2020-12-08 15:29:47 +00:00
src/allmydata/storage_client.py
@ -562,6 +562,7 @@ class _FoolscapStorage(object):
itamarst (Migrated from github.com) commented 2020-12-08 15:29:47 +00:00
Copy Link

Ugggh I did it in the follow-up branch by mistake. So I'll just merge this and it'll be in the next PR, since it's not a significant change.

Ugggh I did it in the follow-up branch by mistake. So I'll just merge this and it'll be in the next PR, since it's not a significant change.
Sign in to join this conversation.
Reviewers
No reviewers
exarkun
Labels
Clear labels   
Benchmarking and Performance

   
HTTP Storage Protocol

   
Nevow Removal

   
Python 3 Porting

   
not-for-merge
No Label
Benchmarking and Performance
HTTP Storage Protocol
Nevow Removal
Python 3 Porting
not-for-merge
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: tahoe-lafs/tahoe-lafs#914
No description provided.
Delete Branch "3544.furls-not-bytes-maybe"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?