Port mutable tests to Python 3, part 3 of N #889

Merged

itamarst merged 10 commits from 3496.mutable-tests-python-3-part-3 into master 2020-11-11 16:41:23 +00:00

Conversation 0 Commits 10 Files Changed 8 +106 -48

itamarst commented 2020-11-06 16:44:59 +00:00 (Migrated from github.com)

Copy Link

Fixes https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3496

Fixes https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3496

exarkun (Migrated from github.com) approved these changes 2020-11-11 15:40:18 +00:00

exarkun (Migrated from github.com) left a comment

Copy Link

Thanks. Looks good. Just one inline comment about sorted, what's up with that?

Thanks. Looks good. Just one inline comment about `sorted`, what's up with that?

src/allmydata/mutable/publish.py

exarkun (Migrated from github.com) commented 2020-11-11 15:21:55 +00:00

Copy Link

Hey this looks familiar :)

Hey this looks familiar :)

itamarst (Migrated from github.com) reviewed 2020-11-11 15:46:21 +00:00

src/allmydata/mutable/publish.py

itamarst (Migrated from github.com) commented 2020-11-11 15:46:21 +00:00

Copy Link

I think that's due to building branches on branches :( Or maybe it's another sorted? I'll fix it.

I think that's due to building branches on branches :( Or maybe it's another `sorted`? I'll fix it.

Sign in to join this conversation.

Reviewers

No reviewers

exarkun

Labels

Clear labels   

Benchmarking and Performance

  

HTTP Storage Protocol

  

Nevow Removal

  

Python 3 Porting

  

not-for-merge

No Label

Benchmarking and Performance

HTTP Storage Protocol

Nevow Removal

Python 3 Porting

not-for-merge

Milestone

Clear milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

No Assignees

1 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: tahoe-lafs/tahoe-lafs#889

No description provided.