Switch to netifaces #872

2020-10-23T13:33:55Z

exarkun commented

2020-10-23 13:33:55 +00:00

(Migrated from github.com)

https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1064
https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1536
https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3486

https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1064 https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1536 https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3486

sajith (Migrated from github.com) approved these changes 2020-10-24 14:52:14 +00:00

sajith (Migrated from github.com) left a comment

This change looks good, useful, and necessary to me! 👍

This change looks good, useful, and necessary to me! :+1:

codecov[bot] commented

2020-10-26 14:03:29 +00:00

(Migrated from github.com)

Codecov Report

❗ No coverage uploaded for pull request base (master@c8cf910). Click here to learn what that means.
The diff coverage is 100%.

@@           Coverage Diff            @@
##             master    #872   +/-   ##
========================================
  Coverage          ?     92%           
========================================
  Files             ?     158           
  Lines             ?   27480           
  Branches          ?    4112           
========================================
  Hits              ?   25312           
  Misses            ?    1494           
  Partials          ?     674

Impacted Files	Coverage Δ
src/allmydata/util/iputil.py	`83% <100%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8cf910...ed5d472. Read the comment docs.

# [Codecov](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/872?src=pr&el=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@c8cf910`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `100%`. [![Impacted file tree graph](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/872/graphs/tree.svg?width=650&height=150&src=pr&token=Ztmu9sr4vi)](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/872?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #872 +/- ## ======================================== Coverage ? 92% ======================================== Files ? 158 Lines ? 27480 Branches ? 4112 ======================================== Hits ? 25312 Misses ? 1494 Partials ? 674 ``` | [Impacted Files](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/872?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [src/allmydata/util/iputil.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/872/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS91dGlsL2lwdXRpbC5weQ==) | `83% <100%> (ø)` | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/872?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/872?src=pr&el=footer). Last update [c8cf910...ed5d472](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/872?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Sign in to join this conversation.

No reviewers

sajith