tahoe-lafs/tahoe-lafs
tahoe-lafs/tahoe-lafs
2
0
Fork 0
Code Issues Pull Requests 23 Packages Projects Releases 1 Wiki Activity

Port some easy files to Python 3 #861

Merged
chadwhitacre merged 1 commits from 3474.easy-ports into master 2020-10-30 17:33:35 +00:00
Conversation 3 Commits 1 Files Changed 5 +30 -2
chadwhitacre commented 2020-10-15 12:03:34 +00:00 (Migrated from github.com)
Copy Link

https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3474

https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3474
itamarst (Migrated from github.com) reviewed 2020-10-15 12:03:34 +00:00
meejah (Migrated from github.com) reviewed 2020-10-15 12:03:34 +00:00
chadwhitacre commented 2020-10-15 12:20:33 +00:00 (Migrated from github.com)
Copy Link

Not as easy as I thought. Converting to draft while I work through typing of versions.

Not as easy as I thought. Converting to draft while I work through typing of versions.
itamarst commented 2020-10-15 12:40:51 +00:00 (Migrated from github.com)
Copy Link

Oh, yeah, IIRC there's maybe some bits where versions percolate through to the Foolscap API? In which case they might need to be converted to bytes for wire-compatibility.

Oh, yeah, IIRC there's maybe some bits where versions percolate through to the Foolscap API? In which case they might need to be converted to bytes for wire-compatibility.
chadwhitacre (Migrated from github.com) reviewed 2020-10-28 19:06:14 +00:00
src/allmydata/test/test_version.py
@ -273,3 +273,3 @@
foolscap_stuffs = [stuff for (pkg, stuff) in vers_and_locs if pkg == 'foolscap']
self.failUnlessEqual(len(foolscap_stuffs), 1)
self.failUnless([e for e in errors if "dependency \'foolscap\' could not be imported" in e])
self.failUnless([e for e in errors if "\'foolscap\' could not be imported" in e])
chadwhitacre (Migrated from github.com) commented 2020-10-28 19:06:14 +00:00
Copy Link

Under Python 2 the message is now: dependency u'foolscap' could not be imported.

Under Python 2 the message is now: `dependency u'foolscap' could not be imported.`
chadwhitacre (Migrated from github.com) reviewed 2020-10-28 19:06:23 +00:00
src/allmydata/util/_python3.py
chadwhitacre (Migrated from github.com) commented 2020-10-28 19:06:23 +00:00
Copy Link

Drive-by reordering.

Drive-by reordering.
codecov[bot] commented 2020-10-28 19:30:52 +00:00 (Migrated from github.com)
Copy Link

Codecov Report

Merging #861 into master will increase coverage by 0%.
The diff coverage is 93%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #861   +/-   ##
======================================
  Coverage      92%     92%           
======================================
  Files         158     158           
  Lines       27500   27514   +14     
  Branches     4118    4120    +2     
======================================
+ Hits        25327   25340   +13     
  Misses       1497    1497           
- Partials      676     677    +1
Impacted Files Coverage Δ
src/allmydata/util/_python3.py 100% <ø> (ø)
src/allmydata/__main__.py 73% <86%> (+23%) ⬆️
src/allmydata/_auto_deps.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91c055a...d04b6c1. Read the comment docs.

# [Codecov](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/861?src=pr&el=h1) Report > Merging [#861](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/861?src=pr&el=desc) into [master](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/commit/91c055a821bb336e4ea4c60ea153bfc04a91b6e7?el=desc) will **increase** coverage by `0%`. > The diff coverage is `93%`. [![Impacted file tree graph](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/861/graphs/tree.svg?width=650&height=150&src=pr&token=Ztmu9sr4vi)](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/861?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #861 +/- ## ====================================== Coverage 92% 92% ====================================== Files 158 158 Lines 27500 27514 +14 Branches 4118 4120 +2 ====================================== + Hits 25327 25340 +13 Misses 1497 1497 - Partials 676 677 +1 ``` | [Impacted Files](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/861?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [src/allmydata/util/\_python3.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/861/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS91dGlsL19weXRob24zLnB5) | `100% <ø> (ø)` | | | [src/allmydata/\_\_main\_\_.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/861/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS9fX21haW5fXy5weQ==) | `73% <86%> (+23%)` | :arrow_up: | | [src/allmydata/\_auto\_deps.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/861/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS9fYXV0b19kZXBzLnB5) | `100% <100%> (ø)` | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/861?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/861?src=pr&el=footer). Last update [91c055a...d04b6c1](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/861?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
exarkun (Migrated from github.com) approved these changes 2020-10-30 16:32:53 +00:00
exarkun (Migrated from github.com) left a comment
Copy Link

Thanks. Looks good. Please merge.

Thanks. Looks good. Please merge.
Sign in to join this conversation.
Reviewers
No reviewers
itamarst
meejah
exarkun
Labels
Clear labels   
Benchmarking and Performance

   
HTTP Storage Protocol

   
Nevow Removal

   
Python 3 Porting

   
not-for-merge
No Label
Benchmarking and Performance
HTTP Storage Protocol
Nevow Removal
Python 3 Porting
not-for-merge
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: tahoe-lafs/tahoe-lafs#861
No description provided.
Delete Branch "3474.easy-ports"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?