3424 Return ErrorPage from web.operations #820

2020-09-21T20:52:52Z

sajith commented

2020-09-21 20:52:52 +00:00

(Migrated from github.com)

Fixes 3424.

Fixes [3424](https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3424).

codecov-commenter commented

2020-09-22 01:22:19 +00:00

(Migrated from github.com)

Codecov Report

Merging #820 into master will decrease coverage by 1%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #820    +/-   ##
=======================================
- Coverage      92%     91%    -1%     
=======================================
  Files         155     155            
  Lines       27428   27428            
  Branches     4109    3906   -203     
=======================================
- Hits        25229   25081   -148     
- Misses       1522    1602    +80     
- Partials      677     745    +68

Impacted Files	Coverage Δ
src/allmydata/web/operations.py	`96% <100%> (ø)`
src/allmydata/util/humanreadable.py	`65% <0%> (-16%)`	⬇️
src/allmydata/crypto/__init__.py	`86% <0%> (-14%)`	⬇️
src/allmydata/storage/common.py	`88% <0%> (-12%)`	⬇️
src/allmydata/crypto/error.py	`89% <0%> (-11%)`	⬇️
src/allmydata/util/_python3.py	`89% <0%> (-11%)`	⬇️
src/allmydata/util/assertutil.py	`89% <0%> (-11%)`	⬇️
src/allmydata/web/common_py3.py	`82% <0%> (-9%)`	⬇️
src/allmydata/crypto/util.py	`92% <0%> (-8%)`	⬇️
src/allmydata/util/mathutil.py	`92% <0%> (-8%)`	⬇️
... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58c99d0...e8f7643. Read the comment docs.

# [Codecov](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/820?src=pr&el=h1) Report > Merging [#820](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/820?src=pr&el=desc) into [master](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/commit/58c99d0c0c000daa7d64b6084b2787190c6c5b71?el=desc) will **decrease** coverage by `1%`. > The diff coverage is `100%`. [![Impacted file tree graph](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/820/graphs/tree.svg?width=650&height=150&src=pr&token=Ztmu9sr4vi)](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/820?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #820 +/- ## ======================================= - Coverage 92% 91% -1% ======================================= Files 155 155 Lines 27428 27428 Branches 4109 3906 -203 ======================================= - Hits 25229 25081 -148 - Misses 1522 1602 +80 - Partials 677 745 +68 ``` | [Impacted Files](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/820?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [src/allmydata/web/operations.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/820/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS93ZWIvb3BlcmF0aW9ucy5weQ==) | `96% <100%> (ø)` | | | [src/allmydata/util/humanreadable.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/820/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS91dGlsL2h1bWFucmVhZGFibGUucHk=) | `65% <0%> (-16%)` | :arrow_down: | | [src/allmydata/crypto/\_\_init\_\_.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/820/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS9jcnlwdG8vX19pbml0X18ucHk=) | `86% <0%> (-14%)` | :arrow_down: | | [src/allmydata/storage/common.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/820/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS9zdG9yYWdlL2NvbW1vbi5weQ==) | `88% <0%> (-12%)` | :arrow_down: | | [src/allmydata/crypto/error.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/820/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS9jcnlwdG8vZXJyb3IucHk=) | `89% <0%> (-11%)` | :arrow_down: | | [src/allmydata/util/\_python3.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/820/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS91dGlsL19weXRob24zLnB5) | `89% <0%> (-11%)` | :arrow_down: | | [src/allmydata/util/assertutil.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/820/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS91dGlsL2Fzc2VydHV0aWwucHk=) | `89% <0%> (-11%)` | :arrow_down: | | [src/allmydata/web/common\_py3.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/820/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS93ZWIvY29tbW9uX3B5My5weQ==) | `82% <0%> (-9%)` | :arrow_down: | | [src/allmydata/crypto/util.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/820/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS9jcnlwdG8vdXRpbC5weQ==) | `92% <0%> (-8%)` | :arrow_down: | | [src/allmydata/util/mathutil.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/820/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS91dGlsL21hdGh1dGlsLnB5) | `92% <0%> (-8%)` | :arrow_down: | | ... and [49 more](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/820/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/820?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/820?src=pr&el=footer). Last update [58c99d0...e8f7643](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/820?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

meejah (Migrated from github.com) approved these changes 2020-09-22 23:50:40 +00:00

Sign in to join this conversation.

No reviewers

meejah