Port the rest of allmydata.test.test_storage_web to Python 3 #795

2020-08-26T14:40:41Z

itamarst commented

2020-08-26 14:40:41 +00:00

(Migrated from github.com)

Fixes https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3395#ticket

codecov-commenter commented

2020-08-26 16:26:41 +00:00

(Migrated from github.com)

Codecov Report

Merging #795 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #795      +/-   ##
==========================================
+ Coverage   91.42%   91.43%   +0.01%     
==========================================
  Files         156      156              
  Lines       27312    27312              
  Branches     3888     3888              
==========================================
+ Hits        24971    24974       +3     
+ Misses       1605     1603       -2     
+ Partials      736      735       -1

Impacted Files	Coverage Δ
src/allmydata/util/_python3.py	`88.88% <ø> (ø)`
src/allmydata/mutable/servermap.py	`94.22% <0.00%> (+0.48%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d8851e...3617757. Read the comment docs.

# [Codecov](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/795?src=pr&el=h1) Report > Merging [#795](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/795?src=pr&el=desc) into [master](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/commit/2d8851e4ccd27ffaf204d55e03dc471821ae8873?el=desc) will **increase** coverage by `0.01%`. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/795/graphs/tree.svg?width=650&height=150&src=pr&token=Ztmu9sr4vi)](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/795?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #795 +/- ## ========================================== + Coverage 91.42% 91.43% +0.01% ========================================== Files 156 156 Lines 27312 27312 Branches 3888 3888 ========================================== + Hits 24971 24974 +3 + Misses 1605 1603 -2 + Partials 736 735 -1 ``` | [Impacted Files](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/795?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [src/allmydata/util/\_python3.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/795/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS91dGlsL19weXRob24zLnB5) | `88.88% <ø> (ø)` | | | [src/allmydata/mutable/servermap.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/795/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS9tdXRhYmxlL3NlcnZlcm1hcC5weQ==) | `94.22% <0.00%> (+0.48%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/795?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/795?src=pr&el=footer). Last update [2d8851e...3617757](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/795?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

sajith (Migrated from github.com) approved these changes 2020-08-27 00:11:26 +00:00

sajith (Migrated from github.com) left a comment

Looks good to me. Thank you!

Should have reviewed sooner, sorry. This got buried in a bunch of browser tabs as the day progressed. :-)

Looks good to me. Thank you! Should have reviewed sooner, sorry. This got buried in a bunch of browser tabs as the day progressed. :-)

Sign in to join this conversation.

No reviewers

sajith