tahoe-lafs/tahoe-lafs
tahoe-lafs
/
tahoe-lafs
2
0
Fork 0
Code Issues Pull Requests 23 Packages Projects Releases 1 Wiki Activity

Port URI to Python 3 #794

Merged
itamarst merged 4 commits from 3367.port-uri-to-python-3-take-2 into master 2020-08-25 15:41:06 +00:00
Conversation 1 Commits 4 Files Changed 4 +228 -178
itamarst commented 2020-08-24 18:08:06 +00:00 (Migrated from github.com)
Copy Link

Fixes https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3367

Builds on work by Maciej, but continues with everything-in-bytes for now (unicode is accepted, though).

Fixes https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3367 Builds on work by Maciej, but continues with everything-in-bytes for now (unicode is accepted, though).
codecov-commenter commented 2020-08-24 18:37:18 +00:00 (Migrated from github.com)
Copy Link

Codecov Report

Merging #794 into master will increase coverage by 0.03%.
The diff coverage is 95.93%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #794      +/-   ##
==========================================
+ Coverage   91.41%   91.45%   +0.03%     
==========================================
  Files         155      155              
  Lines       27277    27293      +16     
  Branches     3879     3884       +5     
==========================================
+ Hits        24936    24961      +25     
+ Misses       1607     1600       -7     
+ Partials      734      732       -2
Impacted Files Coverage Δ
src/allmydata/uri.py 92.35% <95.90%> (-0.29%) ⬇️
src/allmydata/util/_python3.py 88.88% <100.00%> (ø)
src/allmydata/mutable/servermap.py 93.73% <0.00%> (-0.49%) ⬇️
src/allmydata/web/status.py 94.92% <0.00%> (+0.22%) ⬆️
src/allmydata/immutable/checker.py 88.46% <0.00%> (+0.51%) ⬆️
src/allmydata/immutable/downloader/share.py 95.29% <0.00%> (+2.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b79e9c4...2cc21e9. Read the comment docs.

# [Codecov](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/794?src=pr&el=h1) Report > Merging [#794](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/794?src=pr&el=desc) into [master](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/commit/b79e9c4d612d53d6706f17d7b829d56ee17e765e?el=desc) will **increase** coverage by `0.03%`. > The diff coverage is `95.93%`. [![Impacted file tree graph](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/794/graphs/tree.svg?width=650&height=150&src=pr&token=Ztmu9sr4vi)](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/794?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #794 +/- ## ========================================== + Coverage 91.41% 91.45% +0.03% ========================================== Files 155 155 Lines 27277 27293 +16 Branches 3879 3884 +5 ========================================== + Hits 24936 24961 +25 + Misses 1607 1600 -7 + Partials 734 732 -2 ``` | [Impacted Files](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/794?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [src/allmydata/uri.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/794/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS91cmkucHk=) | `92.35% <95.90%> (-0.29%)` | :arrow_down: | | [src/allmydata/util/\_python3.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/794/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS91dGlsL19weXRob24zLnB5) | `88.88% <100.00%> (ø)` | | | [src/allmydata/mutable/servermap.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/794/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS9tdXRhYmxlL3NlcnZlcm1hcC5weQ==) | `93.73% <0.00%> (-0.49%)` | :arrow_down: | | [src/allmydata/web/status.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/794/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS93ZWIvc3RhdHVzLnB5) | `94.92% <0.00%> (+0.22%)` | :arrow_up: | | [src/allmydata/immutable/checker.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/794/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS9pbW11dGFibGUvY2hlY2tlci5weQ==) | `88.46% <0.00%> (+0.51%)` | :arrow_up: | | [src/allmydata/immutable/downloader/share.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/794/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS9pbW11dGFibGUvZG93bmxvYWRlci9zaGFyZS5weQ==) | `95.29% <0.00%> (+2.46%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/794?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/794?src=pr&el=footer). Last update [b79e9c4...2cc21e9](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/794?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
sajith (Migrated from github.com) approved these changes 2020-08-25 14:37:48 +00:00
sajith (Migrated from github.com) left a comment
Copy Link

Thanks, looks good to me!

Thanks, looks good to me!
src/allmydata/uri.py
sajith (Migrated from github.com) commented 2020-08-25 14:37:26 +00:00
Copy Link

Is there anything interesting or worth documenting in this change? I can't think of anything from eyeballing the tests or running this in a REPL, so I thought I should just ask.

Is there anything interesting or worth documenting in this change? I can't think of anything from eyeballing the tests or running this in a REPL, so I thought I should just ask.
itamarst (Migrated from github.com) reviewed 2020-08-25 15:40:55 +00:00
src/allmydata/uri.py
itamarst (Migrated from github.com) commented 2020-08-25 15:40:55 +00:00
Copy Link

Don't think so, it's not meaningful insofar as so far everything is bytes anyway. Just added that in case it turns out to be useful for Python 3.

Don't think so, it's not meaningful insofar as so far everything is bytes anyway. Just added that in case it turns out to be useful for Python 3.
Sign in to join this conversation.
Reviewers
No reviewers
sajith
Labels
Clear labels   
Benchmarking and Performance

   
HTTP Storage Protocol

   
Nevow Removal

   
Python 3 Porting

   
not-for-merge
No Label
Benchmarking and Performance
HTTP Storage Protocol
Nevow Removal
Python 3 Porting
not-for-merge
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: tahoe-lafs/tahoe-lafs#794
No description provided.
Delete Branch "3367.port-uri-to-python-3-take-2"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?