replaced all remaining instances of the print statement with the print function #582

2019-03-24T13:15:14Z

heartsucker commented

2019-03-24 13:15:14 +00:00

(Migrated from github.com)

Fixes https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3010#ticket

This is a little over the +/- 500 limit, but it's the last in this series.

This change is

Fixes https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3010#ticket This is a little over the +/- 500 limit, but it's the last in this series.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/tahoe-lafs/tahoe-lafs/582)

meejah (Migrated from github.com) approved these changes 2019-03-26 00:19:20 +00:00

meejah (Migrated from github.com) left a comment

looks great :)

codecov-io commented

2019-03-26 01:03:11 +00:00

(Migrated from github.com)

Codecov Report

Merging #582 into master will increase coverage by 0.41%.
The diff coverage is 80.51%.

@@            Coverage Diff             @@
##           master     #582      +/-   ##
==========================================
+ Coverage   86.13%   86.55%   +0.41%     
==========================================
  Files         155      159       +4     
  Lines       28500    29394     +894     
  Branches     4069     4448     +379     
==========================================
+ Hits        24549    25441     +892     
- Misses       3256     3270      +14     
+ Partials      695      683      -12

Impacted Files	Coverage Δ
src/allmydata/scripts/stats_gatherer.py	`97.56% <100%> (+0.06%)`	⬆️
src/allmydata/scripts/backupdb.py	`100% <100%> (ø)`	⬆️
src/allmydata/mutable/servermap.py	`94.2% <100%> (ø)`	⬆️
src/allmydata/scripts/common_http.py	`84.21% <100%> (+0.21%)`	⬆️
src/allmydata/scripts/admin.py	`74.5% <100%> (+0.5%)`	⬆️
src/allmydata/scripts/cli.py	`98.08% <100%> (ø)`	⬆️
src/allmydata/scripts/create_node.py	`98.33% <100%> (ø)`	⬆️
src/allmydata/util/statistics.py	`96.9% <100%> (ø)`	⬆️
src/allmydata/scripts/common.py	`94.77% <100%> (+0.03%)`	⬆️
src/allmydata/stats.py	`86.26% <16.66%> (+0.05%)`	⬆️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70c461d...64f4dfa. Read the comment docs.

# [Codecov](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/582?src=pr&el=h1) Report > Merging [#582](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/582?src=pr&el=desc) into [master](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/commit/70c461dfe2f739feffd634b64b56e4ff6f0fbfdf?src=pr&el=desc) will **increase** coverage by `0.41%`. > The diff coverage is `80.51%`. [![Impacted file tree graph](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/582/graphs/tree.svg?width=650&token=Ztmu9sr4vi&height=150&src=pr)](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/582?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #582 +/- ## ========================================== + Coverage 86.13% 86.55% +0.41% ========================================== Files 155 159 +4 Lines 28500 29394 +894 Branches 4069 4448 +379 ========================================== + Hits 24549 25441 +892 - Misses 3256 3270 +14 + Partials 695 683 -12 ``` | [Impacted Files](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/582?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [src/allmydata/scripts/stats\_gatherer.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/582/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS9zY3JpcHRzL3N0YXRzX2dhdGhlcmVyLnB5) | `97.56% <100%> (+0.06%)` | :arrow_up: | | [src/allmydata/scripts/backupdb.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/582/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS9zY3JpcHRzL2JhY2t1cGRiLnB5) | `100% <100%> (ø)` | :arrow_up: | | [src/allmydata/mutable/servermap.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/582/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS9tdXRhYmxlL3NlcnZlcm1hcC5weQ==) | `94.2% <100%> (ø)` | :arrow_up: | | [src/allmydata/scripts/common\_http.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/582/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS9zY3JpcHRzL2NvbW1vbl9odHRwLnB5) | `84.21% <100%> (+0.21%)` | :arrow_up: | | [src/allmydata/scripts/admin.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/582/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS9zY3JpcHRzL2FkbWluLnB5) | `74.5% <100%> (+0.5%)` | :arrow_up: | | [src/allmydata/scripts/cli.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/582/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS9zY3JpcHRzL2NsaS5weQ==) | `98.08% <100%> (ø)` | :arrow_up: | | [src/allmydata/scripts/create\_node.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/582/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS9zY3JpcHRzL2NyZWF0ZV9ub2RlLnB5) | `98.33% <100%> (ø)` | :arrow_up: | | [src/allmydata/util/statistics.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/582/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS91dGlsL3N0YXRpc3RpY3MucHk=) | `96.9% <100%> (ø)` | :arrow_up: | | [src/allmydata/scripts/common.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/582/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS9zY3JpcHRzL2NvbW1vbi5weQ==) | `94.77% <100%> (+0.03%)` | :arrow_up: | | [src/allmydata/stats.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/582/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS9zdGF0cy5weQ==) | `86.26% <16.66%> (+0.05%)` | :arrow_up: | | ... and [32 more](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/582/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/582?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/582?src=pr&el=footer). Last update [70c461d...64f4dfa](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/582?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Sign in to join this conversation.

No reviewers

meejah