test_eliotutil improvements #567

2019-03-08T17:19:41Z

exarkun commented

2019-03-08 17:19:41 +00:00

(Migrated from github.com)

Fixes: ticket:2991

This change is

Fixes: ticket:2991  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/tahoe-lafs/tahoe-lafs/567)

codecov-io commented

2019-03-08 18:01:10 +00:00

(Migrated from github.com)

Codecov Report

Merging #567 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #567      +/-   ##
==========================================
- Coverage   85.46%   85.45%   -0.01%     
==========================================
  Files         153      153              
  Lines       28362    28362              
  Branches     4049     4049              
==========================================
- Hits        24239    24238       -1     
  Misses       3439     3439              
- Partials      684      685       +1

Impacted Files	Coverage Δ
src/allmydata/web/filenode.py	`93.93% <0%> (-0.31%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64c5796...7e4a69e. Read the comment docs.

# [Codecov](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/567?src=pr&el=h1) Report > Merging [#567](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/567?src=pr&el=desc) into [master](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/commit/64c5796a212a040cfb92cf3975fe52bd0a1215b4?src=pr&el=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/567/graphs/tree.svg?width=650&token=Ztmu9sr4vi&height=150&src=pr)](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/567?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #567 +/- ## ========================================== - Coverage 85.46% 85.45% -0.01% ========================================== Files 153 153 Lines 28362 28362 Branches 4049 4049 ========================================== - Hits 24239 24238 -1 Misses 3439 3439 - Partials 684 685 +1 ``` | [Impacted Files](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/567?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [src/allmydata/web/filenode.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/567/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS93ZWIvZmlsZW5vZGUucHk=) | `93.93% <0%> (-0.31%)` | :arrow_down: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/567?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/567?src=pr&el=footer). Last update [64c5796...7e4a69e](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/567?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

vu3rdd (Migrated from github.com) reviewed 2019-03-11 04:23:06 +00:00

vu3rdd (Migrated from github.com) left a comment

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

<img class="emoji" title=":lgtm:" alt=":lgtm:" align="absmiddle" src="https://reviewable.io/lgtm.png" height="20" width="61"/> > Reviewed 3 of 3 files at r1. > *[Reviewable](https://reviewable.io/reviews/tahoe-lafs/tahoe-lafs/567#-:-L_ezKDg7teoeAqJ7z5y:bnfp4nl)* status: :shipit: complete! all files reviewed, all discussions resolved

Sign in to join this conversation.

No reviewers