updated Tor release key #527

2018-08-31T20:12:05Z

meejah commented

2018-08-31 20:12:05 +00:00

(Migrated from github.com)

Looks like the Tor release key changed, which breaks new runs of integration tests.

codecov-io commented

2018-09-04 18:41:20 +00:00

(Migrated from github.com)

Codecov Report

Merging #527 into master will increase coverage by 2%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master     #527    +/-   ##
========================================
+ Coverage   83.11%   85.11%    +2%     
========================================
  Files         152      152            
  Lines       28049    28049            
  Branches     4013     4013            
========================================
+ Hits        23313    23875   +562     
+ Misses       4045     3475   -570     
- Partials      691      699     +8

Impacted Files	Coverage Δ
src/allmydata/web/filenode.py	`93.93% <0%> (-0.31%)`	⬇️
src/allmydata/uri.py	`92.96% <0%> (+0.31%)`	⬆️
src/allmydata/util/encodingutil.py	`90.05% <0%> (+0.52%)`	⬆️
src/allmydata/immutable/upload.py	`95.53% <0%> (+0.55%)`	⬆️
src/allmydata/util/fileutil.py	`50.56% <0%> (+0.56%)`	⬆️
src/allmydata/immutable/encode.py	`95.94% <0%> (+0.95%)`	⬆️
src/allmydata/nodemaker.py	`100% <0%> (+2.06%)`	⬆️
src/allmydata/immutable/literal.py	`91.35% <0%> (+3.7%)`	⬆️
src/allmydata/util/consumer.py	`100% <0%> (+8%)`	⬆️
src/allmydata/magicfolderdb.py	`85.36% <0%> (+12.19%)`	⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efa0b26...2824ca4. Read the comment docs.

# [Codecov](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/527?src=pr&el=h1) Report > Merging [#527](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/527?src=pr&el=desc) into [master](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/commit/efa0b2650be0ee479820afbd40be7c4ea6493cf3?src=pr&el=desc) will **increase** coverage by `2%`. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/527/graphs/tree.svg?width=650&token=Ztmu9sr4vi&height=150&src=pr)](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/527?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #527 +/- ## ======================================== + Coverage 83.11% 85.11% +2% ======================================== Files 152 152 Lines 28049 28049 Branches 4013 4013 ======================================== + Hits 23313 23875 +562 + Misses 4045 3475 -570 - Partials 691 699 +8 ``` | [Impacted Files](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/527?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [src/allmydata/web/filenode.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/527/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS93ZWIvZmlsZW5vZGUucHk=) | `93.93% <0%> (-0.31%)` | :arrow_down: | | [src/allmydata/uri.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/527/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS91cmkucHk=) | `92.96% <0%> (+0.31%)` | :arrow_up: | | [src/allmydata/util/encodingutil.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/527/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS91dGlsL2VuY29kaW5ndXRpbC5weQ==) | `90.05% <0%> (+0.52%)` | :arrow_up: | | [src/allmydata/immutable/upload.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/527/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS9pbW11dGFibGUvdXBsb2FkLnB5) | `95.53% <0%> (+0.55%)` | :arrow_up: | | [src/allmydata/util/fileutil.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/527/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS91dGlsL2ZpbGV1dGlsLnB5) | `50.56% <0%> (+0.56%)` | :arrow_up: | | [src/allmydata/immutable/encode.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/527/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS9pbW11dGFibGUvZW5jb2RlLnB5) | `95.94% <0%> (+0.95%)` | :arrow_up: | | [src/allmydata/nodemaker.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/527/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS9ub2RlbWFrZXIucHk=) | `100% <0%> (+2.06%)` | :arrow_up: | | [src/allmydata/immutable/literal.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/527/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS9pbW11dGFibGUvbGl0ZXJhbC5weQ==) | `91.35% <0%> (+3.7%)` | :arrow_up: | | [src/allmydata/util/consumer.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/527/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS91dGlsL2NvbnN1bWVyLnB5) | `100% <0%> (+8%)` | :arrow_up: | | [src/allmydata/magicfolderdb.py](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/527/diff?src=pr&el=tree#diff-c3JjL2FsbG15ZGF0YS9tYWdpY2ZvbGRlcmRiLnB5) | `85.36% <0%> (+12.19%)` | :arrow_up: | | ... and [5 more](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/527/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/527?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/527?src=pr&el=footer). Last update [efa0b26...2824ca4](https://codecov.io/gh/tahoe-lafs/tahoe-lafs/pull/527?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

exarkun commented

2018-09-05 12:42:40 +00:00

(Migrated from github.com)

It looks like the key expired on August 30th 2018. So someone updated the expiration date to 2020. The "key" itself is the "same" (same fingerprint, for example) but it has a new signature with the new expiration date.

I guess that apt was unhappy because even though it is the same signing key and the signatures on the packages should still be the same and valid, the key itself that the install script is giving to apt is expired and so apt refuses to respect it.

It looks like the key expired on August 30th 2018. So someone updated the expiration date to 2020. The "key" itself is the "same" (same fingerprint, for example) but it has a new signature with the new expiration date. I guess that apt was unhappy because even though it is the same signing key and the signatures on the packages _should_ still be the same and valid, the key itself that the install script is giving to apt is expired and so apt refuses to respect it.

exarkun (Migrated from github.com) approved these changes 2018-09-05 12:54:59 +00:00

exarkun (Migrated from github.com) left a comment

Thanks. I inspected the new key here with gpg -v <key and saw that it has the same fingerprint as the old key and the same fingerprint as the Tor project gives on their own website (https://www.torproject.org/docs/signing-keys.html.en) and I see that the integration tests are now installing the Tor packages and passing.

Thanks. I inspected the new key here with `gpg -v <key` and saw that it has the same fingerprint as the old key and the same fingerprint as the Tor project gives on their own website (https://www.torproject.org/docs/signing-keys.html.en) and I see that the integration tests are now installing the Tor packages and passing.

Sign in to join this conversation.

No reviewers

exarkun